fix type errors, most <Select /> errors

Signed-off-by: Sebastian Malton <sebastian@malton.name>
This commit is contained in:
Sebastian Malton committed 2022-05-04 08:47:19 -04:00
1 parent d55b363df9
commit 595bb715a9
25 files changed
+203 -182

No files matched your search

+1 -1
View File
@@ -73,7 +73,7 @@ const clusterStub = {
} as unknown as Cluster;
describe("ContextHandler", () => {
let createContextHandler: (cluster: Cluster) => ClusterContextHandler;
let createContextHandler: (cluster: Cluster) => ClusterContextHandler | undefined;
beforeEach(async () => {
const di = getDiForUnitTesting({ doGeneralOverrides: true });
+6 -1
View File
@@ -19,12 +19,13 @@ import type { DiContainer } from "@ogre-tools/injectable";
import { parse } from "url";
import loggerInjectable from "../../common/logger.injectable";
import type { Logger } from "../../common/logger";
import assert from "assert";
console = new Console(process.stdout, process.stderr); // fix mockFS
describe("kubeconfig manager tests", () => {
let clusterFake: Cluster;
let createKubeconfigManager: (cluster: Cluster) => KubeconfigManager;
let createKubeconfigManager: (cluster: Cluster) => KubeconfigManager | undefined;
let di: DiContainer;
let logger: jest.Mocked<Logger>;
@@ -92,6 +93,8 @@ describe("kubeconfig manager tests", () => {
it("should create 'temp' kube config with proxy", async () => {
const kubeConfManager = createKubeconfigManager(clusterFake);
assert(kubeConfManager, "should actually create one");
expect(logger.error).not.toBeCalled();
expect(await kubeConfManager.getPath()).toBe(`some-directory-for-temp${path.sep}kubeconfig-foo`);
// this causes an intermittent "ENXIO: no such device or address, read" error
@@ -107,6 +110,8 @@ describe("kubeconfig manager tests", () => {
it("should remove 'temp' kube config on unlink and remove reference from inside class", async () => {
const kubeConfManager = createKubeconfigManager(clusterFake);
assert(kubeConfManager, "should actually create one");
const configPath = await kubeConfManager.getPath();
expect(await fse.pathExists(configPath)).toBe(true);
+1
View File
@@ -4,3 +4,4 @@
*/
export * from "./catalog-entity-registry";
export * from "./entity-registry";
@@ -51,7 +51,12 @@ export class NodeShellSession extends ShellSession {
data: `Error occurred: ${get(error, "response.body.message", error ? String(error) : "unknown error")}`,
});
throw new ShellOpenError("failed to create node pod", error);
throw new ShellOpenError(
"failed to create node pod",
error instanceof Error
? { cause: error }
: undefined,
);
}
const env = await this.getCachedShellEnv();
+2 -2
View File
@@ -23,8 +23,8 @@ import { stat } from "fs/promises";
import { getOrInsertWith } from "../../common/utils";
export class ShellOpenError extends Error {
constructor(message: string, public cause: unknown) {
super(`${message}: ${cause}`);
constructor(message: string, options?: ErrorOptions) {
super(`${message}`, options);
this.name = this.constructor.name;
Error.captureStackTrace(this);
}