Upgrade js-yaml to 4.X (#3623)

src/main/helm/helm-chart-manager.ts

@@ -29,6 +29,11 @@ import { helmCli } from "./helm-cli";
 import type { RepoHelmChartList } from "../../common/k8s-api/endpoints/helm-charts.api";
 import { sortCharts } from "../../common/utils";
 
+export interface HelmCacheFile {
+  apiVersion: string;
+  entries: RepoHelmChartList;
+}
+
 export class HelmChartManager {
   static #cache = new Map<string, Buffer>();
 
@@ -82,7 +87,11 @@ export class HelmChartManager {
   protected async cachedYaml(): Promise<RepoHelmChartList> {
     if (!HelmChartManager.#cache.has(this.repo.name)) {
       const cacheFile = await fs.promises.readFile(this.repo.cacheFilePath, "utf-8");
-      const { entries } = yaml.safeLoad(cacheFile) as { entries: RepoHelmChartList };
+      const data = yaml.load(cacheFile) as string | number | HelmCacheFile;
+
+      if (typeof data !== "object" || !data) {
+        return {};
+      }
 
       /**
        * Do some initial preprocessing on the data, so as to avoid needing to do it later
@@ -92,7 +101,7 @@ export class HelmChartManager {
        */
 
       const normalized = Object.fromEntries(
-        Object.entries(entries)
+        Object.entries(data.entries)
           .map(([name, charts]) => [
             name,
             sortCharts(

src/main/helm/helm-release-manager.ts

@@ -53,7 +53,7 @@ export async function installChart(chart: string, values: any, name: string | un
   const helm = await helmCli.binaryPath();
   const fileName = tempy.file({ name: "values.yaml" });
 
-  await fse.writeFile(fileName, yaml.safeDump(values));
+  await fse.writeFile(fileName, yaml.dump(values));
 
   try {
     let generateName = "";
@@ -83,7 +83,7 @@ export async function upgradeRelease(name: string, chart: string, values: any, n
   const helm = await helmCli.binaryPath();
   const fileName = tempy.file({ name: "values.yaml" });
 
-  await fse.writeFile(fileName, yaml.safeDump(values));
+  await fse.writeFile(fileName, yaml.dump(values));
 
   try {
     const proxyKubeconfig = await cluster.getProxyKubeconfigPath();

src/main/helm/helm-repo-manager.ts

@@ -101,18 +101,28 @@ export class HelmRepoManager extends Singleton {
     return repos.find(repo => repo.name === name);
   }
 
+  private async readConfig(): Promise<HelmRepoConfig> {
+    try {
+      const rawConfig = await readFile(this.helmEnv.HELM_REPOSITORY_CONFIG, "utf8");
+      const parsedConfig = yaml.load(rawConfig);
+
+      if (typeof parsedConfig === "object" && parsedConfig) {
+        return parsedConfig as HelmRepoConfig;
+      }
+    } catch { }
+
+    return {
+      repositories: []
+    };
+  }
+
   public async repositories(): Promise<HelmRepo[]> {
     try {
       if (!this.initialized) {
         await this.init();
       }
 
-      const repoConfigFile = this.helmEnv.HELM_REPOSITORY_CONFIG;
-      const { repositories }: HelmRepoConfig = await readFile(repoConfigFile, "utf8")
-        .then((yamlContent: string) => yaml.safeLoad(yamlContent))
-        .catch(() => ({
-          repositories: []
-        }));
+      const { repositories } = await this.readConfig();
 
       if (!repositories.length) {
         await HelmRepoManager.addRepo({ name: "bitnami", url: "https://charts.bitnami.com/bitnami" });

src/main/resource-applier.ts

@@ -78,7 +78,7 @@ export class ResourceApplier {
     resource = this.sanitizeObject(resource);
     appEventBus.emit({ name: "resource", action: "apply" });
 
-    return this.kubectlApply(yaml.safeDump(resource));
+    return this.kubectlApply(yaml.dump(resource));
   }
 
   protected async kubectlApply(content: string): Promise<string> {