diff --git a/.adr.json b/.adr.json
new file mode 100644
index 0000000000..39e4f9f139
--- /dev/null
+++ b/.adr.json
@@ -0,0 +1,6 @@
+{
+ "language": "en",
+ "path": "docs/architecture/decisions/",
+ "prefix": "",
+ "digits": 4
+}
diff --git a/build/notarize.js b/build/notarize.js
index 3fb8cdee42..ded81f6dd1 100644
--- a/build/notarize.js
+++ b/build/notarize.js
@@ -18,7 +18,7 @@ exports.default = async function notarizing(context) {
const appName = context.packager.appInfo.productFilename;
return await notarize({
- appBundleId: "io.kontena.lens-app",
+ appBundleId: process.env.APPBUNDLEID || "io.kontena.lens-app",
appPath: `${appOutDir}/${appName}.app`,
appleId: process.env.APPLEID,
appleIdPassword: process.env.APPLEIDPASS,
diff --git a/docs/architecture/decisions/README.md b/docs/architecture/decisions/README.md
new file mode 100644
index 0000000000..ff03a7ca8a
--- /dev/null
+++ b/docs/architecture/decisions/README.md
@@ -0,0 +1,2 @@
+# Architecture Decision Records
+
diff --git a/package.json b/package.json
index 0caa48feed..3f0e438dea 100644
--- a/package.json
+++ b/package.json
@@ -12,6 +12,10 @@
"email": "info@k8slens.dev"
},
"scripts": {
+ "adr:create": "echo \"What is the title?\"; read title; adr new \"$title\"",
+ "adr:change-status": "echo \"Decision number?:\"; read decision; adr status $decision",
+ "adr:update-readme": "adr update",
+ "adr:list": "adr list",
"dev": "concurrently -i -k \"yarn run dev-run -C\" yarn:dev:*",
"dev-build": "concurrently yarn:compile:*",
"debug-build": "concurrently yarn:compile:main yarn:compile:extension-types",
@@ -210,10 +214,10 @@
"@kubernetes/client-node": "^0.17.0",
"@material-ui/styles": "^4.11.5",
"@ogre-tools/fp": "9.0.1",
- "@ogre-tools/injectable": "9.0.1",
- "@ogre-tools/injectable-extension-for-auto-registration": "9.0.1",
- "@ogre-tools/injectable-extension-for-mobx": "9.0.1",
- "@ogre-tools/injectable-react": "9.0.1",
+ "@ogre-tools/injectable": "9.0.2",
+ "@ogre-tools/injectable-extension-for-auto-registration": "9.0.2",
+ "@ogre-tools/injectable-extension-for-mobx": "9.0.2",
+ "@ogre-tools/injectable-react": "9.0.2",
"@sentry/electron": "^3.0.7",
"@sentry/integrations": "^6.19.3",
"@side/jest-runtime": "^1.0.1",
@@ -248,7 +252,7 @@
"mobx-observable-history": "^2.0.3",
"mobx-react": "^7.5.2",
"mobx-utils": "^6.0.4",
- "mock-fs": "^5.1.2",
+ "mock-fs": "^5.1.4",
"moment": "^2.29.4",
"moment-timezone": "^0.5.34",
"monaco-editor": "^0.29.1",
@@ -282,7 +286,8 @@
"winston": "^3.8.1",
"winston-console-format": "^1.0.8",
"winston-transport-browserconsole": "^1.0.5",
- "ws": "^8.8.0"
+ "ws": "^8.8.1",
+ "xterm-link-provider": "^1.3.1"
},
"devDependencies": {
"@async-fn/jest": "1.6.4",
@@ -291,7 +296,7 @@
"@material-ui/lab": "^4.0.0-alpha.60",
"@pmmmwh/react-refresh-webpack-plugin": "^0.5.7",
"@sentry/types": "^6.19.7",
- "@swc/core": "^1.2.218",
+ "@swc/core": "^1.2.223",
"@swc/jest": "^0.2.22",
"@testing-library/dom": "^7.31.2",
"@testing-library/jest-dom": "^5.16.4",
@@ -313,7 +318,7 @@
"@types/hapi__subtext": "^7.0.0",
"@types/html-webpack-plugin": "^3.2.6",
"@types/http-proxy": "^1.17.9",
- "@types/jest": "^28.1.3",
+ "@types/jest": "^28.1.6",
"@types/js-yaml": "^4.0.5",
"@types/jsdom": "^16.2.14",
"@types/lodash": "^4.14.181",
@@ -321,7 +326,7 @@
"@types/md5-file": "^4.0.2",
"@types/mini-css-extract-plugin": "^2.4.0",
"@types/mock-fs": "^4.13.1",
- "@types/node": "^16.11.45",
+ "@types/node": "^16.11.47",
"@types/node-fetch": "^2.6.2",
"@types/npm": "^2.0.32",
"@types/proper-lockfile": "^4.1.2",
@@ -351,8 +356,9 @@
"@types/webpack-dev-server": "^4.7.2",
"@types/webpack-env": "^1.17.0",
"@types/webpack-node-externals": "^2.5.3",
- "@typescript-eslint/eslint-plugin": "^5.30.7",
- "@typescript-eslint/parser": "^5.30.5",
+ "@typescript-eslint/eslint-plugin": "^5.32.0",
+ "@typescript-eslint/parser": "^5.31.0",
+ "adr": "^1.4.1",
"ansi_up": "^5.1.0",
"chart.js": "^2.9.4",
"circular-dependency-plugin": "^5.2.2",
@@ -364,11 +370,11 @@
"deepdash": "^5.3.9",
"dompurify": "^2.3.10",
"electron": "^15.5.7",
- "electron-builder": "^23.1.0",
+ "electron-builder": "^23.3.3",
"electron-notarize": "^0.3.0",
- "esbuild": "^0.14.49",
+ "esbuild": "^0.14.53",
"esbuild-loader": "^2.19.0",
- "eslint": "^8.20.0",
+ "eslint": "^8.21.0",
"eslint-plugin-header": "^3.1.1",
"eslint-plugin-import": "^2.26.0",
"eslint-plugin-react": "^7.30.1",
@@ -381,7 +387,7 @@
"identity-obj-proxy": "^3.0.0",
"ignore-loader": "^0.1.2",
"include-media": "^1.4.9",
- "jest": "^28.1.2",
+ "jest": "^28.1.3",
"jest-canvas-mock": "^2.3.1",
"jest-environment-jsdom": "^28.1.3",
"jest-fetch-mock": "^3.0.3",
@@ -392,7 +398,7 @@
"node-gyp": "^8.3.0",
"node-loader": "^2.0.0",
"nodemon": "^2.0.19",
- "playwright": "^1.24.1",
+ "playwright": "^1.24.2",
"postcss": "^8.4.14",
"postcss-loader": "^6.2.1",
"randomcolor": "^0.6.2",
@@ -401,10 +407,10 @@
"react-refresh-typescript": "^2.0.7",
"react-router-dom": "^5.3.3",
"react-select": "^5.4.0",
- "react-select-event": "^5.5.0",
+ "react-select-event": "^5.5.1",
"react-table": "^7.8.0",
"react-window": "^1.8.7",
- "sass": "^1.53.0",
+ "sass": "^1.54.2",
"sass-loader": "^12.6.0",
"sharp": "^0.30.7",
"style-loader": "^3.3.1",
@@ -418,7 +424,7 @@
"typedoc-plugin-markdown": "^3.13.1",
"typescript": "^4.7.4",
"typescript-plugin-css-modules": "^3.4.0",
- "webpack": "^5.73.0",
+ "webpack": "^5.74.0",
"webpack-cli": "^4.9.2",
"webpack-dev-server": "^4.9.3",
"webpack-node-externals": "^3.0.0",
diff --git a/src/behaviours/add-cluster/__snapshots__/navigation-using-application-menu.test.tsx.snap b/src/behaviours/add-cluster/__snapshots__/navigation-using-application-menu.test.tsx.snap
index 46cb3aeaa1..991a77480a 100644
--- a/src/behaviours/add-cluster/__snapshots__/navigation-using-application-menu.test.tsx.snap
+++ b/src/behaviours/add-cluster/__snapshots__/navigation-using-application-menu.test.tsx.snap
@@ -288,7 +288,11 @@ exports[`add-cluster - navigation using application menu when navigating to add
+ >
+
+
@@ -299,6 +303,7 @@ exports[`add-cluster - navigation using application menu when navigating to add
>
Add clusters
+
({
- withTooltip: (Target: any) => ({ tooltip, tooltipOverrideDisabled, ...props }: any) =>
,
-}));
-
-jest.mock("../../renderer/components/monaco-editor/monaco-editor", () => ({
- MonacoEditor: () => null,
-}));
describe("add-cluster - navigation using application menu", () => {
let applicationBuilder: ApplicationBuilder;
diff --git a/src/behaviours/application-update/installing-update-using-topbar-button.test.tsx b/src/behaviours/application-update/installing-update-using-topbar-button.test.tsx
index 855f1332d1..c6ff69d145 100644
--- a/src/behaviours/application-update/installing-update-using-topbar-button.test.tsx
+++ b/src/behaviours/application-update/installing-update-using-topbar-button.test.tsx
@@ -73,15 +73,14 @@ describe("encourage user to update when sufficient time passed since update was
});
describe("given the update check", () => {
- let processCheckingForUpdates: (source: string) => Promise
;
- let processCheckingForUpdatesPromise: Promise;
+ let processCheckingForUpdates: (source: string) => Promise<{ updateIsReadyToBeInstalled: boolean }>;
beforeEach(async () => {
processCheckingForUpdates = applicationBuilder.dis.mainDi.inject(
processCheckingForUpdatesInjectable,
);
- processCheckingForUpdatesPromise = processCheckingForUpdates("irrelevant");
+ processCheckingForUpdates("irrelevant");
});
describe("when update downloaded", () => {
@@ -94,7 +93,6 @@ describe("encourage user to update when sufficient time passed since update was
});
await downloadPlatformUpdateMock.resolve({ downloadWasSuccessful: true });
- await processCheckingForUpdatesPromise;
button = rendered.getByTestId("update-button");
});
@@ -107,6 +105,11 @@ describe("encourage user to update when sufficient time passed since update was
expect(button).toHaveAttribute("data-warning-level", "light");
});
+ // TODO: Implement after starting main and renderer is separated in ApplicationBuilder
+ xit("given closing the application window, when starting the application window again, still shows the button", () => {
+ expect(button).toBeInTheDocument();
+ });
+
describe("given some time passes, when checking for updates again", () => {
beforeEach(() => {
advanceFakeTime(daysToMilliseconds(2));
diff --git a/src/behaviours/application-update/installing-update-using-tray.test.ts b/src/behaviours/application-update/installing-update-using-tray.test.ts
index 251cae45c8..1f8bf8992c 100644
--- a/src/behaviours/application-update/installing-update-using-tray.test.ts
+++ b/src/behaviours/application-update/installing-update-using-tray.test.ts
@@ -13,13 +13,14 @@ import type { AsyncFnMock } from "@async-fn/jest";
import asyncFn from "@async-fn/jest";
import type { DownloadPlatformUpdate } from "../../main/application-update/download-platform-update/download-platform-update.injectable";
import downloadPlatformUpdateInjectable from "../../main/application-update/download-platform-update/download-platform-update.injectable";
-import showApplicationWindowInjectable from "../../main/start-main-application/lens-window/show-application-window.injectable";
+import closeAllWindowsInjectable from "../../main/start-main-application/lens-window/hide-all-windows/close-all-windows.injectable";
+import applicationWindowInjectable from "../../main/start-main-application/lens-window/application-window/application-window.injectable";
+import type { LensWindow } from "../../main/start-main-application/lens-window/application-window/lens-window-injection-token";
describe("installing update using tray", () => {
let applicationBuilder: ApplicationBuilder;
let checkForPlatformUpdatesMock: AsyncFnMock;
let downloadPlatformUpdateMock: AsyncFnMock;
- let showApplicationWindowMock: jest.Mock;
beforeEach(() => {
applicationBuilder = getApplicationBuilder();
@@ -27,9 +28,6 @@ describe("installing update using tray", () => {
applicationBuilder.beforeApplicationStart(({ mainDi }) => {
checkForPlatformUpdatesMock = asyncFn();
downloadPlatformUpdateMock = asyncFn();
- showApplicationWindowMock = jest.fn();
-
- mainDi.override(showApplicationWindowInjectable, () => showApplicationWindowMock);
mainDi.override(
checkForPlatformUpdatesInjectable,
@@ -61,15 +59,77 @@ describe("installing update using tray", () => {
expect(applicationBuilder.tray.get("install-update")).toBeNull();
});
- describe("when user checks for updates using tray", () => {
- let processCheckingForUpdatesPromise: Promise;
+ describe("given all application windows are closed, when checking for updates", () => {
+ let applicationWindow: LensWindow;
+ let closeAllWindows: () => void;
- beforeEach(async () => {
- processCheckingForUpdatesPromise = applicationBuilder.tray.click("check-for-updates");
+ beforeEach(() => {
+ const mainDi = applicationBuilder.dis.mainDi;
+
+ closeAllWindows = mainDi.inject(closeAllWindowsInjectable);
+
+ applicationWindow = mainDi.inject(applicationWindowInjectable);
+
+ closeAllWindows();
+
+ applicationBuilder.tray.click("check-for-updates");
});
- it("does not show application window yet", () => {
- expect(showApplicationWindowMock).not.toHaveBeenCalled();
+ describe("when check for update resolves with new update", () => {
+ beforeEach(async () => {
+ await checkForPlatformUpdatesMock.resolve({
+ updateWasDiscovered: true,
+ version: "some-version",
+ });
+ });
+
+ it("does not show application window yet", () => {
+ expect(applicationWindow.isVisible).toBe(false);
+ });
+
+ describe("when download of update resolves with success", () => {
+ beforeEach(async () => {
+
+ await downloadPlatformUpdateMock.resolve({ downloadWasSuccessful: true });
+ });
+
+ it("shows the application window", () => {
+ expect(applicationWindow.isVisible).toBe(true);
+ });
+
+ it("given closing application window again and checking for updates again using tray, when check resolves with same version that was earlier downloaded, shows the application window", async () => {
+ closeAllWindows();
+
+ applicationBuilder.tray.click("check-for-updates");
+
+ await checkForPlatformUpdatesMock.resolve({
+ updateWasDiscovered: true,
+ version: "some-version",
+ });
+
+ expect(applicationWindow.isVisible).toBe(true);
+ });
+ });
+
+ it("when download of update resolves with failure, does not show the application window", async () => {
+ await downloadPlatformUpdateMock.resolve({ downloadWasSuccessful: false });
+
+ expect(applicationWindow.isVisible).toBe(false);
+ });
+ });
+
+ it("when process resolves without new update, does not show the application window", async () => {
+ await checkForPlatformUpdatesMock.resolve({
+ updateWasDiscovered: false,
+ });
+
+ expect(applicationWindow.isVisible).toBe(false);
+ });
+ });
+
+ describe("when user checks for updates using tray", () => {
+ beforeEach(() => {
+ applicationBuilder.tray.click("check-for-updates");
});
it("user cannot check for updates again", () => {
@@ -97,12 +157,6 @@ describe("installing update using tray", () => {
await checkForPlatformUpdatesMock.resolve({
updateWasDiscovered: false,
});
-
- await processCheckingForUpdatesPromise;
- });
-
- it("shows application window", () => {
- expect(showApplicationWindowMock).toHaveBeenCalled();
});
it("user cannot install update", () => {
@@ -132,12 +186,6 @@ describe("installing update using tray", () => {
updateWasDiscovered: true,
version: "some-version",
});
-
- await processCheckingForUpdatesPromise;
- });
-
- it("shows application window", () => {
- expect(showApplicationWindowMock).toHaveBeenCalled();
});
it("user cannot check for updates again yet", () => {
diff --git a/src/behaviours/application-update/installing-update.test.ts b/src/behaviours/application-update/installing-update.test.ts
index 305e95d525..efc7da8498 100644
--- a/src/behaviours/application-update/installing-update.test.ts
+++ b/src/behaviours/application-update/installing-update.test.ts
@@ -63,7 +63,7 @@ describe("installing update", () => {
describe("when started", () => {
let rendered: RenderResult;
- let processCheckingForUpdates: (source: string) => Promise;
+ let processCheckingForUpdates: (source: string) => Promise<{ updateIsReadyToBeInstalled: boolean }>;
beforeEach(async () => {
rendered = await applicationBuilder.render();
@@ -84,10 +84,8 @@ describe("installing update", () => {
});
describe("when user checks for updates", () => {
- let processCheckingForUpdatesPromise: Promise;
-
- beforeEach(async () => {
- processCheckingForUpdatesPromise = processCheckingForUpdates("irrelevant");
+ beforeEach(() => {
+ processCheckingForUpdates("irrelevant");
});
it("checks for updates", () => {
@@ -112,8 +110,6 @@ describe("installing update", () => {
await checkForPlatformUpdatesMock.resolve({
updateWasDiscovered: false,
});
-
- await processCheckingForUpdatesPromise;
});
it("shows tray icon for normal", () => {
@@ -137,8 +133,6 @@ describe("installing update", () => {
updateWasDiscovered: true,
version: "some-version",
});
-
- await processCheckingForUpdatesPromise;
});
it("starts downloading the update", () => {
@@ -243,7 +237,6 @@ describe("installing update", () => {
"/some-static-files-directory/icons/trayIconCheckingForUpdatesTemplate.png",
);
});
-
});
});
});
diff --git a/src/behaviours/application-update/periodical-checking-of-updates.test.ts b/src/behaviours/application-update/periodical-checking-of-updates.test.ts
index 37c9d4e92b..997f46f8e9 100644
--- a/src/behaviours/application-update/periodical-checking-of-updates.test.ts
+++ b/src/behaviours/application-update/periodical-checking-of-updates.test.ts
@@ -7,8 +7,6 @@ import { getApplicationBuilder } from "../../renderer/components/test-utils/get-
import type { RenderResult } from "@testing-library/react";
import electronUpdaterIsActiveInjectable from "../../main/electron-app/features/electron-updater-is-active.injectable";
import publishIsConfiguredInjectable from "../../main/application-update/publish-is-configured.injectable";
-import type { AsyncFnMock } from "@async-fn/jest";
-import asyncFn from "@async-fn/jest";
import processCheckingForUpdatesInjectable from "../../main/application-update/check-for-updates/process-checking-for-updates.injectable";
import periodicalCheckForUpdatesInjectable from "../../main/application-update/periodical-check-for-updates/periodical-check-for-updates.injectable";
import { advanceFakeTime, useFakeTime } from "../../common/test-utils/use-fake-time";
@@ -17,7 +15,7 @@ const ENOUGH_TIME = 1000 * 60 * 60 * 2;
describe("periodical checking of updates", () => {
let applicationBuilder: ApplicationBuilder;
- let processCheckingForUpdatesMock: AsyncFnMock<() => Promise>;
+ let processCheckingForUpdatesMock: jest.Mock;
beforeEach(() => {
useFakeTime("2015-10-21T07:28:00Z");
@@ -28,7 +26,7 @@ describe("periodical checking of updates", () => {
mainDi.unoverride(periodicalCheckForUpdatesInjectable);
mainDi.permitSideEffects(periodicalCheckForUpdatesInjectable);
- processCheckingForUpdatesMock = asyncFn();
+ processCheckingForUpdatesMock = jest.fn();
mainDi.override(
processCheckingForUpdatesInjectable,
diff --git a/src/behaviours/application-update/selection-of-update-stability.test.ts b/src/behaviours/application-update/selection-of-update-stability.test.ts
index e90d92770f..c2407079df 100644
--- a/src/behaviours/application-update/selection-of-update-stability.test.ts
+++ b/src/behaviours/application-update/selection-of-update-stability.test.ts
@@ -67,7 +67,7 @@ describe("selection of update stability", () => {
describe("when started", () => {
let rendered: RenderResult;
- let processCheckingForUpdates: (source: string) => Promise;
+ let processCheckingForUpdates: (source: string) => Promise<{ updateIsReadyToBeInstalled: boolean }>;
beforeEach(async () => {
rendered = await applicationBuilder.render();
diff --git a/src/behaviours/cluster/__snapshots__/order-of-sidebar-items.test.tsx.snap b/src/behaviours/cluster/__snapshots__/order-of-sidebar-items.test.tsx.snap
index 0b424f4ce2..3dccc2e925 100644
--- a/src/behaviours/cluster/__snapshots__/order-of-sidebar-items.test.tsx.snap
+++ b/src/behaviours/cluster/__snapshots__/order-of-sidebar-items.test.tsx.snap
@@ -503,7 +503,6 @@ exports[`cluster - order of sidebar items when rendered renders 1`] = `
>
close
-
+
+ Close ⌘+W
+
@@ -537,12 +538,13 @@ exports[`cluster - order of sidebar items when rendered renders 1`] = `
>
add
-
+
+ New tab
+
fullscreen
-
+
+ Fit to window
+
keyboard_arrow_up
-
+
+ Open
+
@@ -1135,7 +1140,6 @@ exports[`cluster - order of sidebar items when rendered when parent is expanded
>
close
-
+
+ Close ⌘+W
+
@@ -1169,12 +1175,13 @@ exports[`cluster - order of sidebar items when rendered when parent is expanded
>
add
-
+
+ New tab
+
fullscreen
-
+
+ Fit to window
+
keyboard_arrow_up
-
+
+ Open
+
diff --git a/src/behaviours/cluster/__snapshots__/sidebar-and-tab-navigation-for-core.test.tsx.snap b/src/behaviours/cluster/__snapshots__/sidebar-and-tab-navigation-for-core.test.tsx.snap
index a8c3fc1cd3..8928a59b25 100644
--- a/src/behaviours/cluster/__snapshots__/sidebar-and-tab-navigation-for-core.test.tsx.snap
+++ b/src/behaviours/cluster/__snapshots__/sidebar-and-tab-navigation-for-core.test.tsx.snap
@@ -472,7 +472,6 @@ exports[`cluster - sidebar and tab navigation for core given core registrations
>
close
-
+
+ Close ⌘+W
+
@@ -506,12 +507,13 @@ exports[`cluster - sidebar and tab navigation for core given core registrations
>
add
-
+
+ New tab
+
fullscreen
-
+
+ Fit to window
+
keyboard_arrow_up
-
+
+ Open
+
@@ -1015,7 +1020,6 @@ exports[`cluster - sidebar and tab navigation for core given core registrations
>
close
-
+
+ Close ⌘+W
+
@@ -1049,12 +1055,13 @@ exports[`cluster - sidebar and tab navigation for core given core registrations
>
add
-
+
+ New tab
+
fullscreen
-
+
+ Fit to window
+
keyboard_arrow_up
-
+
+ Open
+
@@ -1580,7 +1590,6 @@ exports[`cluster - sidebar and tab navigation for core given core registrations
>
close
-
+
+ Close ⌘+W
+
@@ -1614,12 +1625,13 @@ exports[`cluster - sidebar and tab navigation for core given core registrations
>
add
-
+
+ New tab
+
fullscreen
-
+
+ Fit to window
+
keyboard_arrow_up
-
+
+ Open
+
@@ -2026,7 +2041,6 @@ exports[`cluster - sidebar and tab navigation for core given core registrations
>
close
-
+
+ Close ⌘+W
+
@@ -2060,12 +2076,13 @@ exports[`cluster - sidebar and tab navigation for core given core registrations
>
add
-
+
+ New tab
+
fullscreen
-
+
+ Fit to window
+
keyboard_arrow_up
-
+
+ Open
+
@@ -2449,7 +2469,6 @@ exports[`cluster - sidebar and tab navigation for core given core registrations
>
close
-
+
+ Close ⌘+W
+
@@ -2483,12 +2504,13 @@ exports[`cluster - sidebar and tab navigation for core given core registrations
>
add
-
+
+ New tab
+
fullscreen
-
+
+ Fit to window
+
keyboard_arrow_up
-
+
+ Open
+
@@ -3014,7 +3039,6 @@ exports[`cluster - sidebar and tab navigation for core given core registrations
>
close
-
+
+ Close ⌘+W
+
@@ -3048,12 +3074,13 @@ exports[`cluster - sidebar and tab navigation for core given core registrations
>
add
-
+
+ New tab
+
fullscreen
-
+
+ Fit to window
+
keyboard_arrow_up
-
+
+ Open
+
@@ -3557,7 +3587,6 @@ exports[`cluster - sidebar and tab navigation for core given core registrations
>
close
-
+
+ Close ⌘+W
+
@@ -3591,12 +3622,13 @@ exports[`cluster - sidebar and tab navigation for core given core registrations
>
add
-
+
+ New tab
+
fullscreen
-
+
+ Fit to window
+
keyboard_arrow_up
-
+
+ Open
+
diff --git a/src/behaviours/cluster/__snapshots__/sidebar-and-tab-navigation-for-extensions.test.tsx.snap b/src/behaviours/cluster/__snapshots__/sidebar-and-tab-navigation-for-extensions.test.tsx.snap
index 4c2b28d53e..b9cc0addaf 100644
--- a/src/behaviours/cluster/__snapshots__/sidebar-and-tab-navigation-for-extensions.test.tsx.snap
+++ b/src/behaviours/cluster/__snapshots__/sidebar-and-tab-navigation-for-extensions.test.tsx.snap
@@ -473,7 +473,6 @@ exports[`cluster - sidebar and tab navigation for extensions given extension wit
+
+ Close ⌘+W
+
@@ -498,7 +500,6 @@ exports[`cluster - sidebar and tab navigation for extensions given extension wit
class="Icon new-dock-tab material interactive focusable"
id="menu-actions-for-dock"
tabindex="0"
- tooltip="New tab"
>
+
+ New tab
+
+
+ Fit to window
+
+
+ Open
+
@@ -1013,7 +1021,6 @@ exports[`cluster - sidebar and tab navigation for extensions given extension wit
+
+ Close ⌘+W
+
@@ -1038,7 +1048,6 @@ exports[`cluster - sidebar and tab navigation for extensions given extension wit
class="Icon new-dock-tab material interactive focusable"
id="menu-actions-for-dock"
tabindex="0"
- tooltip="New tab"
>
+
+ New tab
+
+
+ Fit to window
+
+
+ Open
+
@@ -1593,7 +1609,6 @@ exports[`cluster - sidebar and tab navigation for extensions given extension wit
+
+ Close ⌘+W
+
@@ -1618,7 +1636,6 @@ exports[`cluster - sidebar and tab navigation for extensions given extension wit
class="Icon new-dock-tab material interactive focusable"
id="menu-actions-for-dock"
tabindex="0"
- tooltip="New tab"
>
+
+ New tab
+
+
+ Fit to window
+
+
+ Open
+
@@ -2093,7 +2117,6 @@ exports[`cluster - sidebar and tab navigation for extensions given extension wit
+
+ Close ⌘+W
+
@@ -2118,7 +2144,6 @@ exports[`cluster - sidebar and tab navigation for extensions given extension wit
class="Icon new-dock-tab material interactive focusable"
id="menu-actions-for-dock"
tabindex="0"
- tooltip="New tab"
>
+
+ New tab
+
+
+ Fit to window
+
+
+ Open
+
@@ -2593,7 +2625,6 @@ exports[`cluster - sidebar and tab navigation for extensions given extension wit
+
+ Close ⌘+W
+
@@ -2618,7 +2652,6 @@ exports[`cluster - sidebar and tab navigation for extensions given extension wit
class="Icon new-dock-tab material interactive focusable"
id="menu-actions-for-dock"
tabindex="0"
- tooltip="New tab"
>
+
+ New tab
+
+
+ Fit to window
+
+
+ Open
+
@@ -3052,7 +3092,6 @@ exports[`cluster - sidebar and tab navigation for extensions given extension wit
+
+ Close ⌘+W
+
@@ -3077,7 +3119,6 @@ exports[`cluster - sidebar and tab navigation for extensions given extension wit
class="Icon new-dock-tab material interactive focusable"
id="menu-actions-for-dock"
tabindex="0"
- tooltip="New tab"
>
+
+ New tab
+
+
+ Fit to window
+
+
+ Open
+
@@ -3632,7 +3680,6 @@ exports[`cluster - sidebar and tab navigation for extensions given extension wit
+
+ Close ⌘+W
+
@@ -3657,7 +3707,6 @@ exports[`cluster - sidebar and tab navigation for extensions given extension wit
class="Icon new-dock-tab material interactive focusable"
id="menu-actions-for-dock"
tabindex="0"
- tooltip="New tab"
>
+
+ New tab
+
+
+ Fit to window
+
+
+ Open
+
@@ -4172,7 +4228,6 @@ exports[`cluster - sidebar and tab navigation for extensions given extension wit
+
+ Close ⌘+W
+
@@ -4197,7 +4255,6 @@ exports[`cluster - sidebar and tab navigation for extensions given extension wit
class="Icon new-dock-tab material interactive focusable"
id="menu-actions-for-dock"
tabindex="0"
- tooltip="New tab"
>
+
+ New tab
+
+
+ Fit to window
+
+
+ Open
+
diff --git a/src/behaviours/cluster/__snapshots__/visibility-of-sidebar-items.test.tsx.snap b/src/behaviours/cluster/__snapshots__/visibility-of-sidebar-items.test.tsx.snap
index 52e34c351e..bba303f5b7 100644
--- a/src/behaviours/cluster/__snapshots__/visibility-of-sidebar-items.test.tsx.snap
+++ b/src/behaviours/cluster/__snapshots__/visibility-of-sidebar-items.test.tsx.snap
@@ -442,7 +442,6 @@ exports[`cluster - visibility of sidebar items given kube resource for route is
>
close
-
+
+ Close ⌘+W
+
@@ -476,12 +477,13 @@ exports[`cluster - visibility of sidebar items given kube resource for route is
>
add
-
+
+ New tab
+
fullscreen
-
+
+ Fit to window
+
keyboard_arrow_up
-
+
+ Open
+
@@ -999,7 +1004,6 @@ exports[`cluster - visibility of sidebar items given kube resource for route is
>
close
-
+
+ Close ⌘+W
+
@@ -1033,12 +1039,13 @@ exports[`cluster - visibility of sidebar items given kube resource for route is
>
add
-
+
+ New tab
+
fullscreen
-
+
+ Fit to window
+
keyboard_arrow_up
-
+
+ Open
+
diff --git a/src/behaviours/cluster/extension-api/__snapshots__/disable-cluster-pages-when-cluster-is-not-relevant.test.tsx.snap b/src/behaviours/cluster/extension-api/__snapshots__/disable-cluster-pages-when-cluster-is-not-relevant.test.tsx.snap
index 06e67e8ef2..1ec0fb09cb 100644
--- a/src/behaviours/cluster/extension-api/__snapshots__/disable-cluster-pages-when-cluster-is-not-relevant.test.tsx.snap
+++ b/src/behaviours/cluster/extension-api/__snapshots__/disable-cluster-pages-when-cluster-is-not-relevant.test.tsx.snap
@@ -324,7 +324,6 @@ exports[`disable-cluster-pages-when-cluster-is-not-relevant given extension shou
>
close
-
+
+ Close ⌘+W
+
@@ -358,12 +359,13 @@ exports[`disable-cluster-pages-when-cluster-is-not-relevant given extension shou
>
add
-
+
+ New tab
+
fullscreen
-
+
+ Fit to window
+
keyboard_arrow_up
-
+
+ Open
+
@@ -839,7 +844,6 @@ exports[`disable-cluster-pages-when-cluster-is-not-relevant given extension shou
>
close
-
+
+ Close ⌘+W
+
@@ -873,12 +879,13 @@ exports[`disable-cluster-pages-when-cluster-is-not-relevant given extension shou
>
add
-
+
+ New tab
+
fullscreen
-
+
+ Fit to window
+
keyboard_arrow_up
-
+
+ Open
+
@@ -1354,7 +1364,6 @@ exports[`disable-cluster-pages-when-cluster-is-not-relevant given not yet known
>
close
-
+
+ Close ⌘+W
+
@@ -1388,12 +1399,13 @@ exports[`disable-cluster-pages-when-cluster-is-not-relevant given not yet known
>
add
-
+
+ New tab
+
fullscreen
-
+
+ Fit to window
+
keyboard_arrow_up
-
+
+ Open
+
diff --git a/src/behaviours/cluster/extension-api/__snapshots__/disable-sidebar-items-when-cluster-is-not-relevant.test.tsx.snap b/src/behaviours/cluster/extension-api/__snapshots__/disable-sidebar-items-when-cluster-is-not-relevant.test.tsx.snap
index f145e3fb44..2a7214e3cd 100644
--- a/src/behaviours/cluster/extension-api/__snapshots__/disable-sidebar-items-when-cluster-is-not-relevant.test.tsx.snap
+++ b/src/behaviours/cluster/extension-api/__snapshots__/disable-sidebar-items-when-cluster-is-not-relevant.test.tsx.snap
@@ -463,7 +463,6 @@ exports[`disable sidebar items when cluster is not relevant given extension shou
>
close
-
+
+ Close ⌘+W
+
@@ -497,12 +498,13 @@ exports[`disable sidebar items when cluster is not relevant given extension shou
>
add
-
+
+ New tab
+
fullscreen
-
+
+ Fit to window
+
keyboard_arrow_up
-
+
+ Open
+
@@ -978,7 +983,6 @@ exports[`disable sidebar items when cluster is not relevant given extension shou
>
close
-
+
+ Close ⌘+W
+
@@ -1012,12 +1018,13 @@ exports[`disable sidebar items when cluster is not relevant given extension shou
>
add
-
+
+ New tab
+
fullscreen
-
+
+ Fit to window
+
keyboard_arrow_up
-
+
+ Open
+
@@ -1493,7 +1503,6 @@ exports[`disable sidebar items when cluster is not relevant given not yet known
>
close
-
+
+ Close ⌘+W
+
@@ -1527,12 +1538,13 @@ exports[`disable sidebar items when cluster is not relevant given not yet known
>
add
-
+
+ New tab
+
fullscreen
-
+
+ Fit to window
+
keyboard_arrow_up
-
+
+ Open
+
diff --git a/src/behaviours/cluster/kube-object-details/extension-api/__snapshots__/disable-kube-object-detail-items-when-cluster-is-not-relevant.test.tsx.snap b/src/behaviours/cluster/kube-object-details/extension-api/__snapshots__/disable-kube-object-detail-items-when-cluster-is-not-relevant.test.tsx.snap
index 0db43bda6f..4d415c6ae4 100644
--- a/src/behaviours/cluster/kube-object-details/extension-api/__snapshots__/disable-kube-object-detail-items-when-cluster-is-not-relevant.test.tsx.snap
+++ b/src/behaviours/cluster/kube-object-details/extension-api/__snapshots__/disable-kube-object-detail-items-when-cluster-is-not-relevant.test.tsx.snap
@@ -281,7 +281,6 @@ exports[`disable kube object detail items when cluster is not relevant given ext
some-kind: some-name
content_copy
-
+
+ Copy
+
close
-
+
+ Close
+
@@ -413,12 +416,13 @@ exports[`disable kube object detail items when cluster is not relevant given ext
>
add
-
+
+ New tab
+
fullscreen
-
+
+ Fit to window
+
keyboard_arrow_up
-
+
+ Open
+
@@ -732,7 +739,6 @@ exports[`disable kube object detail items when cluster is not relevant given ext
some-kind: some-name
content_copy
-
+
+ Copy
+
close
-
+
+ Close
+
@@ -902,12 +912,13 @@ exports[`disable kube object detail items when cluster is not relevant given ext
>
add
-
+
+ New tab
+
fullscreen
-
+
+ Fit to window
+
keyboard_arrow_up
-
+
+ Open
+
@@ -1221,7 +1235,6 @@ exports[`disable kube object detail items when cluster is not relevant given not
some-kind: some-name
content_copy
-
+
+ Copy
+
close
-
+
+ Close
+
@@ -1391,12 +1408,13 @@ exports[`disable kube object detail items when cluster is not relevant given not
>
add
-
+
+ New tab
+
fullscreen
-
+
+ Fit to window
+
keyboard_arrow_up
-
+
+ Open
+
diff --git a/src/behaviours/cluster/kube-object-menu/extension-api/__snapshots__/disable-kube-object-menu-items-when-cluster-is-not-relevant.test.tsx.snap b/src/behaviours/cluster/kube-object-menu/extension-api/__snapshots__/disable-kube-object-menu-items-when-cluster-is-not-relevant.test.tsx.snap
index 8f3d0685f6..9ae3f382cf 100644
--- a/src/behaviours/cluster/kube-object-menu/extension-api/__snapshots__/disable-kube-object-menu-items-when-cluster-is-not-relevant.test.tsx.snap
+++ b/src/behaviours/cluster/kube-object-menu/extension-api/__snapshots__/disable-kube-object-menu-items-when-cluster-is-not-relevant.test.tsx.snap
@@ -329,7 +329,6 @@ exports[`disable kube object menu items when cluster is not relevant given exten
>
close
-
+
+ Close ⌘+W
+
@@ -363,12 +364,13 @@ exports[`disable kube object menu items when cluster is not relevant given exten
>
add
-
+
+ New tab
+
fullscreen
-
+
+ Fit to window
+
keyboard_arrow_up
-
+
+ Open
+
@@ -724,7 +729,6 @@ exports[`disable kube object menu items when cluster is not relevant given exten
>
close
-
+
+ Close ⌘+W
+
@@ -758,12 +764,13 @@ exports[`disable kube object menu items when cluster is not relevant given exten
>
add
-
+
+ New tab
+
fullscreen
-
+
+ Fit to window
+
keyboard_arrow_up
-
+
+ Open
+
@@ -1119,7 +1129,6 @@ exports[`disable kube object menu items when cluster is not relevant given not y
>
close
-
+
+ Close ⌘+W
+
@@ -1153,12 +1164,13 @@ exports[`disable kube object menu items when cluster is not relevant given not y
>
add
-
+
+ New tab
+
fullscreen
-
+
+ Fit to window
+
keyboard_arrow_up
-
+
+ Open
+
diff --git a/src/behaviours/cluster/kube-object-status-icon/__snapshots__/show-status-for-a-kube-object.test.tsx.snap b/src/behaviours/cluster/kube-object-status-icon/__snapshots__/show-status-for-a-kube-object.test.tsx.snap
index ec1b142188..3a9398de2c 100644
--- a/src/behaviours/cluster/kube-object-status-icon/__snapshots__/show-status-for-a-kube-object.test.tsx.snap
+++ b/src/behaviours/cluster/kube-object-status-icon/__snapshots__/show-status-for-a-kube-object.test.tsx.snap
@@ -319,7 +319,6 @@ exports[`show status for a kube object given application starts and in test page
+
@@ -366,12 +393,13 @@ exports[`disable kube object statuses when cluster is not relevant given extensi
>
add
-
+
+ New tab
+
fullscreen
-
+
+ Fit to window
+
keyboard_arrow_up
-
+
+ Open
+
@@ -722,7 +753,6 @@ exports[`disable kube object statuses when cluster is not relevant given extensi
>
close
-
+
+ Close ⌘+W
+
@@ -756,12 +788,13 @@ exports[`disable kube object statuses when cluster is not relevant given extensi
>
add
-
+
+ New tab
+
fullscreen
-
+
+ Fit to window
+
keyboard_arrow_up
-
+
+ Open
+
@@ -1112,7 +1148,6 @@ exports[`disable kube object statuses when cluster is not relevant given not yet
>
close
-
+
+ Close ⌘+W
+
@@ -1146,12 +1183,13 @@ exports[`disable kube object statuses when cluster is not relevant given not yet
>
add
-
+
+ New tab
+
fullscreen
-
+
+ Fit to window
+
keyboard_arrow_up
-
+
+ Open
+
diff --git a/src/behaviours/cluster/kube-object-status-icon/show-status-for-a-kube-object.test.tsx b/src/behaviours/cluster/kube-object-status-icon/show-status-for-a-kube-object.test.tsx
index b8af696848..a63344271d 100644
--- a/src/behaviours/cluster/kube-object-status-icon/show-status-for-a-kube-object.test.tsx
+++ b/src/behaviours/cluster/kube-object-status-icon/show-status-for-a-kube-object.test.tsx
@@ -21,31 +21,6 @@ import { observer } from "mobx-react";
import { kubeObjectStatusTextInjectionToken } from "../../../renderer/components/kube-object-status-icon/kube-object-status-text-injection-token";
import { KubeObjectStatusIcon } from "../../../renderer/components/kube-object-status-icon";
-// TODO: Make tooltips free of side effects by making it deterministic
-jest.mock("../../../renderer/components/tooltip/withTooltip", () => ({
- withTooltip:
- (Target: any) =>
- ({ tooltip, ...props }: any) => {
- if (tooltip) {
- const testId = props["data-testid"];
-
- return (
- <>
-
-
- {tooltip.children || tooltip}
-
- >
- );
- }
-
- return ;
- },
-}));
-
describe("show status for a kube object", () => {
let builder: ApplicationBuilder;
let infoStatusIsShown: boolean;
diff --git a/src/behaviours/cluster/namespaces/__snapshots__/edit-namespace-from-new-tab.test.tsx.snap b/src/behaviours/cluster/namespaces/__snapshots__/edit-namespace-from-new-tab.test.tsx.snap
index 3ae620ccf6..3d062ac38e 100644
--- a/src/behaviours/cluster/namespaces/__snapshots__/edit-namespace-from-new-tab.test.tsx.snap
+++ b/src/behaviours/cluster/namespaces/__snapshots__/edit-namespace-from-new-tab.test.tsx.snap
@@ -489,7 +489,6 @@ exports[`cluster/namespaces - edit namespace from new tab when navigating to nam
>
+
+ Remove
+
@@ -4017,7 +4033,6 @@ exports[`add helm repository from list in preferences when navigating to prefere
class="Icon material interactive focusable"
data-testid="remove-helm-repository-Some already active repository"
tabindex="0"
- tooltip="Remove"
>
+
+ Remove
+
@@ -4634,7 +4658,6 @@ exports[`add helm repository from list in preferences when navigating to prefere
class="Icon material interactive focusable"
data-testid="remove-helm-repository-Some already active repository"
tabindex="0"
- tooltip="Remove"
>
+
+ Remove
+
@@ -5310,7 +5342,6 @@ exports[`add helm repository from list in preferences when navigating to prefere
class="Icon material interactive focusable"
data-testid="remove-helm-repository-Some already active repository"
tabindex="0"
- tooltip="Remove"
>
+
+ Remove
+
diff --git a/src/behaviours/helm-charts/__snapshots__/listing-active-helm-repositories-in-preferences.test.ts.snap b/src/behaviours/helm-charts/__snapshots__/listing-active-helm-repositories-in-preferences.test.ts.snap
index f98cea253c..146fb371aa 100644
--- a/src/behaviours/helm-charts/__snapshots__/listing-active-helm-repositories-in-preferences.test.ts.snap
+++ b/src/behaviours/helm-charts/__snapshots__/listing-active-helm-repositories-in-preferences.test.ts.snap
@@ -3720,7 +3720,6 @@ exports[`listing active helm repositories in preferences when navigating to pref
class="Icon material interactive focusable"
data-testid="remove-helm-repository-some-repository"
tabindex="0"
- tooltip="Remove"
>
+
+ Remove
+
diff --git a/src/behaviours/helm-charts/__snapshots__/remove-helm-repository-from-list-of-active-repository-in-preferences.test.ts.snap b/src/behaviours/helm-charts/__snapshots__/remove-helm-repository-from-list-of-active-repository-in-preferences.test.ts.snap
index 8724f1900e..2cb3b4e60d 100644
--- a/src/behaviours/helm-charts/__snapshots__/remove-helm-repository-from-list-of-active-repository-in-preferences.test.ts.snap
+++ b/src/behaviours/helm-charts/__snapshots__/remove-helm-repository-from-list-of-active-repository-in-preferences.test.ts.snap
@@ -1046,7 +1046,6 @@ exports[`remove helm repository from list of active repositories in preferences
class="Icon material interactive focusable"
data-testid="remove-helm-repository-some-active-repository"
tabindex="0"
- tooltip="Remove"
>
+
+ Remove
+
@@ -1631,7 +1635,6 @@ exports[`remove helm repository from list of active repositories in preferences
class="Icon material interactive focusable"
data-testid="remove-helm-repository-some-active-repository"
tabindex="0"
- tooltip="Remove"
>
+
+ Remove
+
diff --git a/src/behaviours/helm-charts/add-custom-helm-repository-in-preferences.test.ts b/src/behaviours/helm-charts/add-custom-helm-repository-in-preferences.test.ts
index 943aca900f..b8d9fd0661 100644
--- a/src/behaviours/helm-charts/add-custom-helm-repository-in-preferences.test.ts
+++ b/src/behaviours/helm-charts/add-custom-helm-repository-in-preferences.test.ts
@@ -18,11 +18,6 @@ import showSuccessNotificationInjectable from "../../renderer/components/notific
import showErrorNotificationInjectable from "../../renderer/components/notifications/show-error-notification.injectable";
import type { AsyncResult } from "../../common/utils/async-result";
-// TODO: Make tooltips free of side effects by making it deterministic
-jest.mock("../../renderer/components/tooltip/withTooltip", () => ({
- withTooltip: (target: any) => target,
-}));
-
describe("add custom helm repository in preferences", () => {
let applicationBuilder: ApplicationBuilder;
let showSuccessNotificationMock: jest.Mock;
diff --git a/src/behaviours/helm-charts/add-helm-repository-from-list-in-preferences.test.ts b/src/behaviours/helm-charts/add-helm-repository-from-list-in-preferences.test.ts
index 74e57cb693..c16fcd893f 100644
--- a/src/behaviours/helm-charts/add-helm-repository-from-list-in-preferences.test.ts
+++ b/src/behaviours/helm-charts/add-helm-repository-from-list-in-preferences.test.ts
@@ -16,11 +16,6 @@ import showSuccessNotificationInjectable from "../../renderer/components/notific
import showErrorNotificationInjectable from "../../renderer/components/notifications/show-error-notification.injectable";
import type { AsyncResult } from "../../common/utils/async-result";
-// TODO: Make tooltips free of side effects by making it deterministic
-jest.mock("../../renderer/components/tooltip/withTooltip", () => ({
- withTooltip: (target: any) => target,
-}));
-
describe("add helm repository from list in preferences", () => {
let applicationBuilder: ApplicationBuilder;
let showSuccessNotificationMock: jest.Mock;
diff --git a/src/behaviours/helm-charts/installing-chart/__snapshots__/installing-helm-chart-from-new-tab.test.ts.snap b/src/behaviours/helm-charts/installing-chart/__snapshots__/installing-helm-chart-from-new-tab.test.ts.snap
index 745c657614..2a9f1f3ed8 100644
--- a/src/behaviours/helm-charts/installing-chart/__snapshots__/installing-helm-chart-from-new-tab.test.ts.snap
+++ b/src/behaviours/helm-charts/installing-chart/__snapshots__/installing-helm-chart-from-new-tab.test.ts.snap
@@ -660,7 +660,6 @@ exports[`installing helm chart from new tab given tab for installing chart was n
class="Icon new-dock-tab material interactive focusable"
id="menu-actions-for-dock"
tabindex="0"
- tooltip="New tab"
>
+
+ New tab
+
@@ -693,7 +695,6 @@ exports[`installing helm chart from new tab given tab for installing chart was n
+
+ Copy
+
+
+ Close
+
@@ -1629,7 +1637,6 @@ exports[`installing helm chart from new tab given tab for installing chart was n
class="Icon new-dock-tab material interactive focusable"
id="menu-actions-for-dock"
tabindex="0"
- tooltip="New tab"
>
+
+ New tab
+
+
+ Fit to window
+
+
+ Minimize
+
@@ -2390,7 +2406,6 @@ exports[`installing helm chart from new tab given tab for installing chart was n
class="Icon new-dock-tab material interactive focusable"
id="menu-actions-for-dock"
tabindex="0"
- tooltip="New tab"
>
+
+ New tab
+
+
+ Fit to window
+
+
+ Minimize
+
@@ -3395,7 +3419,6 @@ exports[`installing helm chart from new tab given tab for installing chart was n
class="Icon new-dock-tab material interactive focusable"
id="menu-actions-for-dock"
tabindex="0"
- tooltip="New tab"
>
+
+ New tab
+
+
+ Fit to window
+
+
+ Minimize
+
@@ -4374,7 +4406,6 @@ exports[`installing helm chart from new tab given tab for installing chart was n
class="Icon new-dock-tab material interactive focusable"
id="menu-actions-for-dock"
tabindex="0"
- tooltip="New tab"
>
+
+ New tab
+
+
+ Fit to window
+
+
+ Minimize
+
@@ -5348,7 +5388,6 @@ exports[`installing helm chart from new tab given tab for installing chart was n
class="Icon new-dock-tab material interactive focusable"
id="menu-actions-for-dock"
tabindex="0"
- tooltip="New tab"
>
+
+ New tab
+
+
+ Fit to window
+
+
+ Minimize
+
@@ -6322,7 +6370,6 @@ exports[`installing helm chart from new tab given tab for installing chart was n
class="Icon new-dock-tab material interactive focusable"
id="menu-actions-for-dock"
tabindex="0"
- tooltip="New tab"
>
+
+ New tab
+
+
+ Fit to window
+
+
+ Minimize
+
+
+ YAMLException: end of the stream or a document separator is expected (1:1)
+
+ 1 | @some-invalid-configuration@
+-----^
+
+
+ Close ⌘+W
+
@@ -7316,7 +7374,6 @@ exports[`installing helm chart from new tab given tab for installing chart was n
class="Icon new-dock-tab material interactive focusable"
id="menu-actions-for-dock"
tabindex="0"
- tooltip="New tab"
>
+
+ New tab
+
+
+ Fit to window
+
+
+ Minimize
+
@@ -8321,7 +8387,6 @@ exports[`installing helm chart from new tab given tab for installing chart was n
class="Icon new-dock-tab material interactive focusable"
id="menu-actions-for-dock"
tabindex="0"
- tooltip="New tab"
>
+
+ New tab
+
+
+ Fit to window
+
+
+ Minimize
+
@@ -9295,7 +9369,6 @@ exports[`installing helm chart from new tab given tab for installing chart was n
class="Icon new-dock-tab material interactive focusable"
id="menu-actions-for-dock"
tabindex="0"
- tooltip="New tab"
>
+
+ New tab
+
+
+ Fit to window
+
+
+ Minimize
+
@@ -10324,7 +10406,6 @@ exports[`installing helm chart from new tab given tab for installing chart was n
class="Icon new-dock-tab material interactive focusable"
id="menu-actions-for-dock"
tabindex="0"
- tooltip="New tab"
>
+
+ New tab
+
+
+ Fit to window
+
+
+ Minimize
+
@@ -11151,7 +11241,6 @@ exports[`installing helm chart from new tab given tab for installing chart was n
class="Icon material interactive focusable"
data-testid="close-helm-release-detail"
tabindex="0"
- tooltip="Close"
>
+
+ Close
+
@@ -11932,7 +12028,6 @@ exports[`installing helm chart from new tab given tab for installing chart was n
class="Icon new-dock-tab material interactive focusable"
id="menu-actions-for-dock"
tabindex="0"
- tooltip="New tab"
>
+
+ New tab
+
+
+ Fit to window
+
+
+ Minimize
+
@@ -12786,7 +12890,6 @@ exports[`installing helm chart from new tab given tab for installing chart was n
class="Icon new-dock-tab material interactive focusable"
id="menu-actions-for-dock"
tabindex="0"
- tooltip="New tab"
>
+
+ New tab
+
+
+ Fit to window
+
+
+ Minimize
+
+
+ Close
+
@@ -14024,7 +14140,6 @@ exports[`installing helm chart from new tab given tab for installing chart was n
+
+ Close ⌘+W
+
@@ -14049,7 +14167,6 @@ exports[`installing helm chart from new tab given tab for installing chart was n
class="Icon new-dock-tab material interactive focusable"
id="menu-actions-for-dock"
tabindex="0"
- tooltip="New tab"
>
+
+ New tab
+
+
+ Fit to window
+
+
+ Minimize
+
@@ -14832,7 +14958,6 @@ exports[`installing helm chart from new tab given tab for installing chart was n
+
+ Close ⌘+W
+
@@ -14857,7 +14985,6 @@ exports[`installing helm chart from new tab given tab for installing chart was n
class="Icon new-dock-tab material interactive focusable"
id="menu-actions-for-dock"
tabindex="0"
- tooltip="New tab"
>
+
+ New tab
+
+
+ Fit to window
+
+
+ Minimize
+
@@ -15855,7 +15991,6 @@ exports[`installing helm chart from new tab given tab for installing chart was n
+
+ Close ⌘+W
+
@@ -15880,7 +16018,6 @@ exports[`installing helm chart from new tab given tab for installing chart was n
class="Icon new-dock-tab material interactive focusable"
id="menu-actions-for-dock"
tabindex="0"
- tooltip="New tab"
>
+
+ New tab
+
+
+ Fit to window
+
+
+ Minimize
+
@@ -16854,7 +17000,6 @@ exports[`installing helm chart from new tab given tab for installing chart was n
class="Icon new-dock-tab material interactive focusable"
id="menu-actions-for-dock"
tabindex="0"
- tooltip="New tab"
>
+
+ New tab
+
+
+ Fit to window
+
+
+ Minimize
+
@@ -17828,7 +17982,6 @@ exports[`installing helm chart from new tab given tab for installing chart was n
class="Icon new-dock-tab material interactive focusable"
id="menu-actions-for-dock"
tabindex="0"
- tooltip="New tab"
>
+
+ New tab
+
+
+ Fit to window
+
+
+ Minimize
+
diff --git a/src/behaviours/helm-charts/installing-chart/__snapshots__/installing-helm-chart-from-previously-opened-tab.test.ts.snap b/src/behaviours/helm-charts/installing-chart/__snapshots__/installing-helm-chart-from-previously-opened-tab.test.ts.snap
index 8c5475a888..7bd7f19eae 100644
--- a/src/behaviours/helm-charts/installing-chart/__snapshots__/installing-helm-chart-from-previously-opened-tab.test.ts.snap
+++ b/src/behaviours/helm-charts/installing-chart/__snapshots__/installing-helm-chart-from-previously-opened-tab.test.ts.snap
@@ -444,7 +444,6 @@ exports[`installing helm chart from previously opened tab given tab for installi
+
+ Close ⌘+W
+
@@ -469,7 +471,6 @@ exports[`installing helm chart from previously opened tab given tab for installi
class="Icon new-dock-tab material interactive focusable"
id="menu-actions-for-dock"
tabindex="0"
- tooltip="New tab"
>
+
+ New tab
+
+
+ Fit to window
+
+
+ Minimize
+
@@ -991,7 +1001,6 @@ exports[`installing helm chart from previously opened tab given tab for installi
class="Icon new-dock-tab material interactive focusable"
id="menu-actions-for-dock"
tabindex="0"
- tooltip="New tab"
>
+
+ New tab
+
+
+ Fit to window
+
+
+ Minimize
+
@@ -1175,7 +1177,6 @@ exports[`opening dock tab for installing helm chart given application is started
class="Icon new-dock-tab material interactive focusable"
id="menu-actions-for-dock"
tabindex="0"
- tooltip="New tab"
>
+
+ New tab
+
@@ -1854,7 +1858,6 @@ exports[`opening dock tab for installing helm chart given application is started
class="Icon new-dock-tab material interactive focusable"
id="menu-actions-for-dock"
tabindex="0"
- tooltip="New tab"
>
+
+ New tab
+
@@ -1887,7 +1893,6 @@ exports[`opening dock tab for installing helm chart given application is started
+
+ Copy
+
+
+ Close
+
@@ -2619,7 +2631,6 @@ exports[`opening dock tab for installing helm chart given application is started
+
+ Copy
+
+
+ Close
+
@@ -3530,7 +3548,6 @@ exports[`opening dock tab for installing helm chart given application is started
+
+ Copy
+
+
+ Close
+
@@ -4451,7 +4475,6 @@ exports[`opening dock tab for installing helm chart given application is started
+
+ Copy
+
+
+ Close
+
@@ -5362,7 +5392,6 @@ exports[`opening dock tab for installing helm chart given application is started
+
+ Copy
+
+
+ Close
+
@@ -6298,7 +6334,6 @@ exports[`opening dock tab for installing helm chart given application is started
class="Icon new-dock-tab material interactive focusable"
id="menu-actions-for-dock"
tabindex="0"
- tooltip="New tab"
>
+
+ New tab
+
+
+ Fit to window
+
+
+ Minimize
+
({
- withTooltip: (target: any) => target,
-}));
-
describe("installing helm chart from new tab", () => {
let builder: ApplicationBuilder;
let rendererDi: DiContainer;
diff --git a/src/behaviours/helm-charts/installing-chart/installing-helm-chart-from-previously-opened-tab.test.ts b/src/behaviours/helm-charts/installing-chart/installing-helm-chart-from-previously-opened-tab.test.ts
index 1fdde9130c..c9fa77f8aa 100644
--- a/src/behaviours/helm-charts/installing-chart/installing-helm-chart-from-previously-opened-tab.test.ts
+++ b/src/behaviours/helm-charts/installing-chart/installing-helm-chart-from-previously-opened-tab.test.ts
@@ -24,11 +24,6 @@ import { controlWhenStoragesAreReady } from "../../../renderer/utils/create-stor
import type { DiContainer } from "@ogre-tools/injectable";
import callForCreateHelmReleaseInjectable from "../../../renderer/components/+helm-releases/create-release/call-for-create-helm-release.injectable";
-// TODO: Make tooltips free of side effects by making it deterministic
-jest.mock("../../../renderer/components/tooltip/withTooltip", () => ({
- withTooltip: (target: any) => target,
-}));
-
describe("installing helm chart from previously opened tab", () => {
let builder: ApplicationBuilder;
let rendererDi: DiContainer;
diff --git a/src/behaviours/helm-charts/installing-chart/opening-dock-tab-for-installing-helm-chart.test.ts b/src/behaviours/helm-charts/installing-chart/opening-dock-tab-for-installing-helm-chart.test.ts
index 79ad98a1dc..16c4f236a3 100644
--- a/src/behaviours/helm-charts/installing-chart/opening-dock-tab-for-installing-helm-chart.test.ts
+++ b/src/behaviours/helm-charts/installing-chart/opening-dock-tab-for-installing-helm-chart.test.ts
@@ -25,11 +25,6 @@ import hostedClusterIdInjectable from "../../../renderer/cluster-frame-context/h
import dockStoreInjectable from "../../../renderer/components/dock/dock/store.injectable";
import type { DiContainer } from "@ogre-tools/injectable";
-// TODO: Make tooltips free of side effects by making it deterministic
-jest.mock("../../../renderer/components/tooltip/withTooltip", () => ({
- withTooltip: (target: any) => target,
-}));
-
describe("opening dock tab for installing helm chart", () => {
let builder: ApplicationBuilder;
let rendererDi: DiContainer;
diff --git a/src/behaviours/helm-charts/listing-active-helm-repositories-in-preferences.test.ts b/src/behaviours/helm-charts/listing-active-helm-repositories-in-preferences.test.ts
index a801487d10..d7939e890a 100644
--- a/src/behaviours/helm-charts/listing-active-helm-repositories-in-preferences.test.ts
+++ b/src/behaviours/helm-charts/listing-active-helm-repositories-in-preferences.test.ts
@@ -17,11 +17,6 @@ import type { Logger } from "../../common/logger";
import callForPublicHelmRepositoriesInjectable from "../../renderer/components/+preferences/kubernetes/helm-charts/adding-of-public-helm-repository/public-helm-repositories/call-for-public-helm-repositories.injectable";
import showErrorNotificationInjectable from "../../renderer/components/notifications/show-error-notification.injectable";
-// TODO: Make tooltips free of side effects by making it deterministic
-jest.mock("../../renderer/components/tooltip/withTooltip", () => ({
- withTooltip: (target: any) => target,
-}));
-
describe("listing active helm repositories in preferences", () => {
let applicationBuilder: ApplicationBuilder;
let rendered: RenderResult;
diff --git a/src/behaviours/helm-charts/remove-helm-repository-from-list-of-active-repository-in-preferences.test.ts b/src/behaviours/helm-charts/remove-helm-repository-from-list-of-active-repository-in-preferences.test.ts
index 096d37ed68..ca7ec95b24 100644
--- a/src/behaviours/helm-charts/remove-helm-repository-from-list-of-active-repository-in-preferences.test.ts
+++ b/src/behaviours/helm-charts/remove-helm-repository-from-list-of-active-repository-in-preferences.test.ts
@@ -15,11 +15,6 @@ import type { HelmRepo } from "../../common/helm/helm-repo";
import callForPublicHelmRepositoriesInjectable from "../../renderer/components/+preferences/kubernetes/helm-charts/adding-of-public-helm-repository/public-helm-repositories/call-for-public-helm-repositories.injectable";
import type { AsyncResult } from "../../common/utils/async-result";
-// TODO: Make tooltips free of side effects by making it deterministic
-jest.mock("../../renderer/components/tooltip/withTooltip", () => ({
- withTooltip: (target: any) => target,
-}));
-
describe("remove helm repository from list of active repositories in preferences", () => {
let applicationBuilder: ApplicationBuilder;
let rendered: RenderResult;
diff --git a/src/behaviours/helm-releases/__snapshots__/showing-details-for-helm-release.test.ts.snap b/src/behaviours/helm-releases/__snapshots__/showing-details-for-helm-release.test.ts.snap
index ba191595b2..ae169ab2f4 100644
--- a/src/behaviours/helm-releases/__snapshots__/showing-details-for-helm-release.test.ts.snap
+++ b/src/behaviours/helm-releases/__snapshots__/showing-details-for-helm-release.test.ts.snap
@@ -676,7 +676,6 @@ exports[`showing details for helm release given application is started when navi
+
+ Close ⌘+W
+
@@ -701,7 +703,6 @@ exports[`showing details for helm release given application is started when navi
class="Icon new-dock-tab material interactive focusable"
id="menu-actions-for-dock"
tabindex="0"
- tooltip="New tab"
>
+
+ New tab
+
+
+ Fit to window
+
+
+ Open
+
@@ -1425,7 +1433,6 @@ exports[`showing details for helm release given application is started when navi
+
+ Close ⌘+W
+
@@ -1450,7 +1460,6 @@ exports[`showing details for helm release given application is started when navi
class="Icon new-dock-tab material interactive focusable"
id="menu-actions-for-dock"
tabindex="0"
- tooltip="New tab"
>
+
+ New tab
+
+
+ Fit to window
+
+
+ Open
+
@@ -2342,7 +2358,6 @@ exports[`showing details for helm release given application is started when navi
+
+ Close ⌘+W
+
@@ -2367,7 +2385,6 @@ exports[`showing details for helm release given application is started when navi
class="Icon new-dock-tab material interactive focusable"
id="menu-actions-for-dock"
tabindex="0"
- tooltip="New tab"
>
+
+ New tab
+
+
+ Fit to window
+
+
+ Open
+
@@ -3259,7 +3283,6 @@ exports[`showing details for helm release given application is started when navi
+
+ Close ⌘+W
+
@@ -3284,7 +3310,6 @@ exports[`showing details for helm release given application is started when navi
class="Icon new-dock-tab material interactive focusable"
id="menu-actions-for-dock"
tabindex="0"
- tooltip="New tab"
>
+
+ New tab
+
+
+ Fit to window
+
+
+ Open
+
@@ -3344,7 +3376,6 @@ exports[`showing details for helm release given application is started when navi
class="Icon material interactive focusable"
data-testid="close-helm-release-detail"
tabindex="0"
- tooltip="Close"
>
+
+ Close
+
@@ -4244,7 +4282,6 @@ exports[`showing details for helm release given application is started when navi
class="Icon new-dock-tab material interactive focusable"
id="menu-actions-for-dock"
tabindex="0"
- tooltip="New tab"
>
+
+ New tab
+
+
+ Fit to window
+
+
+ Open
+
@@ -5136,7 +5180,6 @@ exports[`showing details for helm release given application is started when navi
+
+ Close ⌘+W
+
@@ -5161,7 +5207,6 @@ exports[`showing details for helm release given application is started when navi
class="Icon new-dock-tab material interactive focusable"
id="menu-actions-for-dock"
tabindex="0"
- tooltip="New tab"
>
+
+ New tab
+
+
+ Fit to window
+
+
+ Open
+
@@ -5221,7 +5273,6 @@ exports[`showing details for helm release given application is started when navi
class="Icon material interactive focusable"
data-testid="close-helm-release-detail"
tabindex="0"
- tooltip="Close"
>
+
+ Close
+
@@ -6121,7 +6179,6 @@ exports[`showing details for helm release given application is started when navi
class="Icon new-dock-tab material interactive focusable"
id="menu-actions-for-dock"
tabindex="0"
- tooltip="New tab"
>
+
+ New tab
+
+
+ Fit to window
+
+
+ Open
+
@@ -6181,7 +6245,6 @@ exports[`showing details for helm release given application is started when navi
class="Icon material interactive focusable"
data-testid="close-helm-release-detail"
tabindex="0"
- tooltip="Close"
>
+
+ Close
+
@@ -7081,7 +7151,6 @@ exports[`showing details for helm release given application is started when navi
class="Icon new-dock-tab material interactive focusable"
id="menu-actions-for-dock"
tabindex="0"
- tooltip="New tab"
>
+
+ New tab
+
+
+ Fit to window
+
+
+ Open
+
@@ -7139,7 +7215,6 @@ exports[`showing details for helm release given application is started when navi
+
+ Copy
+