Add better type safety around Channels (#6133)

* Add better type safety around Channels

- Reallow non-JSON serializable complex types

- Remove unnecessary JSON serialization step to IPC

- Remove unnecesary injectable-ization of MessageChannel and
  RequestChannel declarations

- Add channel listener injectable getter function to remove general need
  for type casting and improve type safety

Signed-off-by: Sebastian Malton <sebastian@malton.name>

* Add check to verify data in IPC related tests

Signed-off-by: Sebastian Malton <sebastian@malton.name>

* Fix implementation in light of new safety check in tests

Signed-off-by: Sebastian Malton <sebastian@malton.name>

* Fix listener ID clash potential

Signed-off-by: Sebastian Malton <sebastian@malton.name>

* Switch to not forcing split of request channel handlers being seperate from the listener decl

Signed-off-by: Sebastian Malton <sebastian@malton.name>

* Move message channels to changed signature too

Signed-off-by: Sebastian Malton <sebastian@malton.name>

* Fix not registering listener

Signed-off-by: Sebastian Malton <sebastian@malton.name>

* Fix test imports

Signed-off-by: Sebastian Malton <sebastian@malton.name>

* Fix type errors

Signed-off-by: Sebastian Malton <sebastian@malton.name>

* Refactor listening of different channel kinds

Signed-off-by: Sebastian Malton <sebastian@malton.name>

* Add test covering new checking code for request channel handlers

Signed-off-by: Sebastian Malton <sebastian@malton.name>

Signed-off-by: Sebastian Malton <sebastian@malton.name>

src/common/fs/exec-file.injectable.ts

@@ -5,22 +5,33 @@
 import { getInjectable } from "@ogre-tools/injectable";
 import type { ExecFileOptions } from "child_process";
 import { execFile } from "child_process";
-import { promisify } from "util";
+import type { AsyncResult } from "../utils/async-result";
 
-export type ExecFile = (filePath: string, args: string[], options: ExecFileOptions) => Promise<string>;
+export interface ExecFile {
+  (filePath: string, args: string[], options: ExecFileOptions): Promise<AsyncResult<string, { stderr: string; error: Error }>>;
+}
 
 const execFileInjectable = getInjectable({
   id: "exec-file",
 
-  instantiate: (): ExecFile => {
-    const asyncExecFile = promisify(execFile);
-
-    return async (filePath, args, options) => {
-      const result = await asyncExecFile(filePath, args, options);
-
-      return result.stdout;
-    };
-  },
+  instantiate: (): ExecFile => (filePath, args, options) => new Promise((resolve) => {
+    execFile(filePath, args, options, (error, stdout, stderr) => {
+      if (error) {
+        resolve({
+          callWasSuccessful: false,
+          error: {
+            error,
+            stderr,
+          },
+        });
+      } else {
+        resolve({
+          callWasSuccessful: true,
+          response: stdout,
+        });
+      }
+    });
+  }),
 
   causesSideEffects: true,
 });