Add better type safety around Channels (#6133)

* Add better type safety around Channels

- Reallow non-JSON serializable complex types

- Remove unnecessary JSON serialization step to IPC

- Remove unnecesary injectable-ization of MessageChannel and
  RequestChannel declarations

- Add channel listener injectable getter function to remove general need
  for type casting and improve type safety

Signed-off-by: Sebastian Malton <sebastian@malton.name>

* Add check to verify data in IPC related tests

Signed-off-by: Sebastian Malton <sebastian@malton.name>

* Fix implementation in light of new safety check in tests

Signed-off-by: Sebastian Malton <sebastian@malton.name>

* Fix listener ID clash potential

Signed-off-by: Sebastian Malton <sebastian@malton.name>

* Switch to not forcing split of request channel handlers being seperate from the listener decl

Signed-off-by: Sebastian Malton <sebastian@malton.name>

* Move message channels to changed signature too

Signed-off-by: Sebastian Malton <sebastian@malton.name>

* Fix not registering listener

Signed-off-by: Sebastian Malton <sebastian@malton.name>

* Fix test imports

Signed-off-by: Sebastian Malton <sebastian@malton.name>

* Fix type errors

Signed-off-by: Sebastian Malton <sebastian@malton.name>

* Refactor listening of different channel kinds

Signed-off-by: Sebastian Malton <sebastian@malton.name>

* Add test covering new checking code for request channel handlers

Signed-off-by: Sebastian Malton <sebastian@malton.name>

Signed-off-by: Sebastian Malton <sebastian@malton.name>

src/common/helm/add-helm-repository-channel.ts

@@ -2,22 +2,12 @@
  * Copyright (c) OpenLens Authors. All rights reserved.
  * Licensed under MIT License. See LICENSE in root directory for more information.
  */
-import { getInjectable } from "@ogre-tools/injectable";
 import type { HelmRepo } from "./helm-repo";
-import type { RequestChannel } from "../utils/channel/request-channel-injection-token";
-import { requestChannelInjectionToken } from "../utils/channel/request-channel-injection-token";
 import type { AsyncResult } from "../utils/async-result";
+import type { RequestChannel } from "../utils/channel/request-channel-listener-injection-token";
 
 export type AddHelmRepositoryChannel = RequestChannel<HelmRepo, AsyncResult<string>>;
 
-const addHelmRepositoryChannelInjectable = getInjectable({
+export const addHelmRepositoryChannel: AddHelmRepositoryChannel = {
   id: "add-helm-repository-channel",
-
-  instantiate: (): AddHelmRepositoryChannel => ({
-    id: "add-helm-repository-channel",
-  }),
-
-  injectionToken: requestChannelInjectionToken,
-});
-
-export default addHelmRepositoryChannelInjectable;
+};

src/common/helm/get-active-helm-repositories-channel.injectable.ts

@@ -1,23 +0,0 @@
-/**
- * Copyright (c) OpenLens Authors. All rights reserved.
- * Licensed under MIT License. See LICENSE in root directory for more information.
- */
-import { getInjectable } from "@ogre-tools/injectable";
-import type { RequestChannel } from "../utils/channel/request-channel-injection-token";
-import type { HelmRepo } from "./helm-repo";
-import { requestChannelInjectionToken } from "../utils/channel/request-channel-injection-token";
-import type { AsyncResult } from "../utils/async-result";
-
-export type GetHelmRepositoriesChannel = RequestChannel<void, AsyncResult<HelmRepo[]>>;
-
-const getActiveHelmRepositoriesChannelInjectable = getInjectable({
-  id: "get-active-helm-repositories-channel",
-
-  instantiate: (): GetHelmRepositoriesChannel => ({
-    id: "get-helm-active-list-repositories",
-  }),
-
-  injectionToken: requestChannelInjectionToken,
-});
-
-export default getActiveHelmRepositoriesChannelInjectable;

src/common/helm/get-active-helm-repositories-channel.ts

@@ -0,0 +1,13 @@
+/**
+ * Copyright (c) OpenLens Authors. All rights reserved.
+ * Licensed under MIT License. See LICENSE in root directory for more information.
+ */
+import type { HelmRepo } from "./helm-repo";
+import type { AsyncResult } from "../utils/async-result";
+import type { RequestChannel } from "../utils/channel/request-channel-listener-injection-token";
+
+export type GetActiveHelmRepositoriesChannel = RequestChannel<void, AsyncResult<HelmRepo[]>>;
+
+export const getActiveHelmRepositoriesChannel: GetActiveHelmRepositoriesChannel = {
+  id: "get-helm-active-list-repositories",
+};

src/common/helm/remove-helm-repository-channel.injectable.ts

@@ -1,22 +0,0 @@
-/**
- * Copyright (c) OpenLens Authors. All rights reserved.
- * Licensed under MIT License. See LICENSE in root directory for more information.
- */
-import { getInjectable } from "@ogre-tools/injectable";
-import type { HelmRepo } from "./helm-repo";
-import type { RequestChannel } from "../utils/channel/request-channel-injection-token";
-import { requestChannelInjectionToken } from "../utils/channel/request-channel-injection-token";
-
-export type RemoveHelmRepositoryChannel = RequestChannel<HelmRepo>;
-
-const removeHelmRepositoryChannelInjectable = getInjectable({
-  id: "remove-helm-repository-channel",
-
-  instantiate: (): RemoveHelmRepositoryChannel => ({
-    id: "remove-helm-repository-channel",
-  }),
-
-  injectionToken: requestChannelInjectionToken,
-});
-
-export default removeHelmRepositoryChannelInjectable;

src/common/helm/remove-helm-repository-channel.ts

@@ -0,0 +1,13 @@
+/**
+ * Copyright (c) OpenLens Authors. All rights reserved.
+ * Licensed under MIT License. See LICENSE in root directory for more information.
+ */
+import type { AsyncResult } from "../utils/async-result";
+import type { RequestChannel } from "../utils/channel/request-channel-listener-injection-token";
+import type { HelmRepo } from "./helm-repo";
+
+export type RemoveHelmRepositoryChannel = RequestChannel<HelmRepo, AsyncResult<string, string>>;
+
+export const removeHelmRepositoryChannel: RemoveHelmRepositoryChannel = {
+  id: "remove-helm-repository-channel",
+};