hendrik/lens
1
0
Fork 0
mirror of https://github.com/lensapp/lens.git synced 2025-05-20 05:10:56 +00:00
Code Issues Projects Releases Wiki Activity

Fix installing extension dependencies (#6537)

Browse Source 
- The --only option was removed in v7 and the --omit option was
  introduced then too.

Signed-off-by: Sebastian Malton <sebastian@malton.name>

Signed-off-by: Sebastian Malton <sebastian@malton.name>
This commit is contained in:
Sebastian Malton 2022-11-08 07:00:35 -08:00 committed by GitHub
parent 4cf16e1aee
commit 5ae60e218c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 13 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/extensions/extension-installer/extension-installer.ts
View File

@ -16,6 +16,16 @@ interface Dependencies {
extensionPackageRootDirectory: string; extensionPackageRootDirectory: string;
} }
const baseNpmInstallArgs = [
"install",
"--audit=false",
"--fund=false",
"--omit=dev",
"--omit=optional",
"--omit=peer",
"--prefer-offline",
];
/** /**
* Installs dependencies for extensions * Installs dependencies for extensions
*/ */
@ -42,7 +52,7 @@ export class ExtensionInstaller {
}); });
logger.info(`${logModule} installing dependencies at ${this.dependencies.extensionPackageRootDirectory}`); logger.info(`${logModule} installing dependencies at ${this.dependencies.extensionPackageRootDirectory}`);
await this.npm(["install", "--audit=false", "--fund=false", "--only=prod", "--prefer-offline"]); await this.npm(...baseNpmInstallArgs);
logger.info(`${logModule} dependencies installed at ${this.dependencies.extensionPackageRootDirectory}`); logger.info(`${logModule} dependencies installed at ${this.dependencies.extensionPackageRootDirectory}`);
} finally { } finally {
this.installLock.release(); this.installLock.release();
@ -58,14 +68,14 @@ export class ExtensionInstaller {
try { try {
logger.info(`${logModule} installing package from ${name} to ${this.dependencies.extensionPackageRootDirectory}`); logger.info(`${logModule} installing package from ${name} to ${this.dependencies.extensionPackageRootDirectory}`);
await this.npm(["install", "--audit=false", "--fund=false", "--only=prod", "--prefer-offline", name]); await this.npm(...baseNpmInstallArgs, name);
logger.info(`${logModule} package ${name} installed to ${this.dependencies.extensionPackageRootDirectory}`); logger.info(`${logModule} package ${name} installed to ${this.dependencies.extensionPackageRootDirectory}`);
} finally { } finally {
this.installLock.release(); this.installLock.release();
} }
}; };
private npm(args: string[]): Promise<void> { private npm(...args: string[]): Promise<void> {
return new Promise((resolve, reject) => { return new Promise((resolve, reject) => {
const child = child_process.fork(this.npmPath, args, { const child = child_process.fork(this.npmPath, args, {
cwd: this.dependencies.extensionPackageRootDirectory, cwd: this.dependencies.extensionPackageRootDirectory,