From 5bf3d3a188b88710bb608fc937607eef361b9120 Mon Sep 17 00:00:00 2001 From: Alex Andreev Date: Fri, 12 Mar 2021 15:25:23 +0300 Subject: [PATCH] Fine-tune rootMargin to catch intersections on small screen Signed-off-by: Alex Andreev --- src/renderer/components/+preferences/preferences.tsx | 2 +- src/renderer/components/scroll-spy/scroll-spy.tsx | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/renderer/components/+preferences/preferences.tsx b/src/renderer/components/+preferences/preferences.tsx index a2143652b2..9fe45ef420 100644 --- a/src/renderer/components/+preferences/preferences.tsx +++ b/src/renderer/components/+preferences/preferences.tsx @@ -32,7 +32,7 @@ export class Preferences extends React.Component { render() { const { preferences } = userStore; const header =

Preferences

; - const rootMargin = "80px 0px -85%"; // Cut header size from the top and 85% from the bottom of viewport + const rootMargin = "80px 0px -80%"; let defaultShell = process.env.SHELL || process.env.PTYSHELL; if (!defaultShell) { diff --git a/src/renderer/components/scroll-spy/scroll-spy.tsx b/src/renderer/components/scroll-spy/scroll-spy.tsx index 0a47abe85c..4264c80f31 100644 --- a/src/renderer/components/scroll-spy/scroll-spy.tsx +++ b/src/renderer/components/scroll-spy/scroll-spy.tsx @@ -8,7 +8,7 @@ interface Props extends React.DOMAttributes { rootMargin?: string // https://developer.mozilla.org/en-US/docs/Web/API/Intersection_Observer_API#creating_an_intersection_observer } -export const ScrollSpy = observer(({ render, rootMargin = "0px 0px -85%" }: Props) => { +export const ScrollSpy = observer(({ render, rootMargin = "0px 0px -80%" }: Props) => { const parent = useRef(); const sections = useRef>(); const [tree, setTree] = useState([]);