hendrik/lens
1
0
Fork 0
mirror of https://github.com/lensapp/lens.git synced 2025-05-20 05:10:56 +00:00
Code Issues Projects Releases Wiki Activity

Allowing any[] type for VirtualList items prop

Browse Source 
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
This commit is contained in:
Alex Andreev 2020-11-26 15:35:23 +03:00
parent ccd38b5cbe
commit 5e9762c11d
2 changed files with 5 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/renderer/components/table/table.tsx
View File

@ -20,7 +20,7 @@ export type TableSortParams = { sortBy: TableSortBy; orderBy: TableOrderBy };
export type TableSortCallback<D = any> = (data: D) => string | number | (string | number)[]; export type TableSortCallback<D = any> = (data: D) => string | number | (string | number)[];
export interface TableProps extends React.DOMAttributes<HTMLDivElement> { export interface TableProps extends React.DOMAttributes<HTMLDivElement> {
items?: ItemObject[]; // Raw items data items?: any[]; // Raw items data
className?: string; className?: string;
autoSize?: boolean; // Setup auto-sizing for all columns (flex: 1 0) autoSize?: boolean; // Setup auto-sizing for all columns (flex: 1 0)
selectable?: boolean; // Highlight rows on hover selectable?: boolean; // Highlight rows on hover
@ -40,7 +40,7 @@ export interface TableProps extends React.DOMAttributes<HTMLDivElement> {
rowPadding?: string; rowPadding?: string;
rowLineHeight?: string; rowLineHeight?: string;
customRowHeights?: (item: object, lineHeight: number, paddings: number) => number; customRowHeights?: (item: object, lineHeight: number, paddings: number) => number;
getTableRow?: (uid: string) => React.ReactElement<TableRowProps>; getTableRow?: (uid: string | number) => React.ReactElement<TableRowProps>;
} }
@observer @observer

7
src/renderer/components/virtual-list/virtual-list.tsx
View File

@ -13,8 +13,8 @@ import debounce from "lodash/debounce";
import isEqual from "lodash/isEqual"; import isEqual from "lodash/isEqual";
import ResizeSensor from "css-element-queries/src/ResizeSensor"; import ResizeSensor from "css-element-queries/src/ResizeSensor";
interface Props<T extends ItemObject = any> { interface Props {
items: T[]; items: any[];
rowHeights: number[]; rowHeights: number[];
className?: string; className?: string;
width?: number | string; width?: number | string;
@ -126,8 +126,7 @@ interface RowProps extends ListChildComponentProps {
const Row = observer((props: RowProps) => { const Row = observer((props: RowProps) => {
const { index, style, data } = props; const { index, style, data } = props;
const { items, getRow } = data; const { items, getRow } = data;
const item = items[index]; const uid = items[index].getId ? items[index].getId() : index;
const uid = typeof item == "string" ? index : items[index].getId();
const row = getRow(uid); const row = getRow(uid);
if (!row) return null; if (!row) return null;
return React.cloneElement(row, { return React.cloneElement(row, {