Turn on noUnusedLocals, noImplicitReturns, importsNotUsedAsValues: error, and isolatedModules (#2777)

src/extensions/__tests__/extension-loader.test.ts

@@ -77,6 +77,8 @@ jest.mock(
             ],
           ];
         }
+
+        return [];
       }),
       on: jest.fn(
         (channel: string, listener: (event: any, ...args: any[]) => void) => {

src/extensions/extension-loader.ts

@@ -325,6 +325,8 @@ export class ExtensionLoader extends Singleton {
     } catch (error) {
       logger.error(`${logModule}: can't load extension main at ${extAbsolutePath}: ${error}`, { extension, error });
     }
+
+    return null;
   }
 
   getExtension(extId: LensExtensionId): InstalledExtension {

src/extensions/extension-store.ts

@@ -21,7 +21,7 @@
 
 import { BaseStore } from "../common/base-store";
 import * as path from "path";
-import { LensExtension } from "./lens-extension";
+import type { LensExtension } from "./lens-extension";
 
 export abstract class ExtensionStore<T> extends BaseStore<T> {
   protected extension: LensExtension;

src/extensions/ipc-store.ts

@@ -19,7 +19,7 @@
  * CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
  */
 import { Singleton } from "../common/utils";
-import { LensExtension } from "./lens-extension";
+import type { LensExtension } from "./lens-extension";
 import { createHash } from "crypto";
 import { broadcastMessage } from "../common/ipc";
 

src/extensions/lens-extension.ts

@@ -23,7 +23,7 @@ import type { InstalledExtension } from "./extension-discovery";
 import { action, observable, reaction } from "mobx";
 import { FilesystemProvisionerStore } from "../main/extension-filesystem";
 import logger from "../main/logger";
-import { ProtocolHandlerRegistration } from "./registries";
+import type { ProtocolHandlerRegistration } from "./registries";
 import { disposer } from "../common/utils";
 
 export type LensExtensionId = string; // path to manifest (package.json)

src/extensions/lens-main-extension.ts

@@ -23,8 +23,8 @@ import { LensExtension } from "./lens-extension";
 import { WindowManager } from "../main/window-manager";
 import { getExtensionPageUrl } from "./registries/page-registry";
 import { CatalogEntity, catalogEntityRegistry } from "../common/catalog";
-import { IObservableArray } from "mobx";
-import { MenuRegistration } from "./registries";
+import type { IObservableArray } from "mobx";
+import type { MenuRegistration } from "./registries";
 
 export class LensMainExtension extends LensExtension {
   appMenus: MenuRegistration[] = [];

src/extensions/lens-renderer-extension.ts

@@ -26,8 +26,8 @@ import type {
 import type { Cluster } from "../main/cluster";
 import { LensExtension } from "./lens-extension";
 import { getExtensionPageUrl } from "./registries/page-registry";
-import { CommandRegistration } from "./registries/command-registry";
-import { EntitySettingRegistration } from "./registries/entity-setting-registry";
+import type { CommandRegistration } from "./registries/command-registry";
+import type { EntitySettingRegistration } from "./registries/entity-setting-registry";
 
 export class LensRendererExtension extends LensExtension {
   globalPages: PageRegistration[] = [];

src/extensions/main-ipc-store.ts

@@ -21,7 +21,7 @@
 import { ipcMain } from "electron";
 import { IpcPrefix, IpcStore } from "./ipc-store";
 import { Disposers } from "./lens-extension";
-import { LensMainExtension } from "./lens-main-extension";
+import type { LensMainExtension } from "./lens-main-extension";
 
 export abstract class MainIpcStore extends IpcStore {
   constructor(extension: LensMainExtension) {

src/extensions/registries/entity-setting-registry.ts

@@ -20,7 +20,7 @@
  */
 
 import type React from "react";
-import { CatalogEntity } from "../../common/catalog";
+import type { CatalogEntity } from "../../common/catalog";
 import { BaseRegistry } from "./base-registry";
 
 export interface EntitySettingViewProps {

src/extensions/registries/kube-object-detail-registry.ts

@@ -19,7 +19,7 @@
  * CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
  */
 
-import React from "react";
+import type React from "react";
 import { BaseRegistry } from "./base-registry";
 
 export interface KubeObjectDetailComponents {

src/extensions/registries/kube-object-menu-registry.ts

@@ -19,7 +19,7 @@
  * CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
  */
 
-import React from "react";
+import type React from "react";
 import { BaseRegistry } from "./base-registry";
 
 export interface KubeObjectMenuComponents {

src/extensions/registries/kube-object-status-registry.ts

@@ -19,7 +19,7 @@
  * CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
  */
 
-import { KubeObject, KubeObjectStatus } from "../renderer-api/k8s-api";
+import type { KubeObject, KubeObjectStatus } from "../renderer-api/k8s-api";
 import { BaseRegistry } from "./base-registry";
 
 export interface KubeObjectStatusRegistration {

src/extensions/registries/page-registry.ts

@@ -25,7 +25,7 @@ import React from "react";
 import { observer } from "mobx-react";
 import { BaseRegistry } from "./base-registry";
 import { LensExtension, sanitizeExtensionName } from "../lens-extension";
-import { PageParam, PageParamInit } from "../../renderer/navigation/page-param";
+import type { PageParam, PageParamInit } from "../../renderer/navigation/page-param";
 import { createPageParam } from "../../renderer/navigation/helpers";
 
 export interface PageRegistration {
@@ -119,9 +119,9 @@ export class PageRegistry extends BaseRegistry<PageRegistration, RegisteredPage>
     return components;
   }
 
-  protected normalizeParams(params?: PageParams<string | ExtensionPageParamInit>): PageParams<PageParam> {
+  protected normalizeParams(params?: PageParams<string | ExtensionPageParamInit>): PageParams<PageParam> | undefined {
     if (!params) {
-      return;
+      return undefined;
     }
     Object.entries(params).forEach(([name, value]) => {
       const paramInit: PageParamInit = typeof value === "object"

src/extensions/registries/status-bar-registry.ts

@@ -21,7 +21,7 @@
 
 // Extensions API -> Status bar customizations
 
-import React from "react";
+import type React from "react";
 import { BaseRegistry } from "./base-registry";
 
 interface StatusBarComponents {

src/extensions/renderer-api/k8s-api.ts

@@ -23,9 +23,9 @@ export { isAllowedResource } from "../../common/rbac";
 export { ResourceStack } from "../../common/k8s/resource-stack";
 export { apiManager } from "../../renderer/api/api-manager";
 export { KubeObjectStore } from "../../renderer/kube-object.store";
-export { KubeApi, forCluster, IKubeApiCluster } from "../../renderer/api/kube-api";
+export { KubeApi, forCluster } from "../../renderer/api/kube-api";
 export { KubeObject } from "../../renderer/api/kube-object";
-export { Pod, podsApi, PodsApi, IPodContainer, IPodContainerStatus } from "../../renderer/api/endpoints";
+export { Pod, podsApi, PodsApi } from "../../renderer/api/endpoints";
 export { Node, nodesApi, NodesApi } from "../../renderer/api/endpoints";
 export { Deployment, deploymentApi, DeploymentApi } from "../../renderer/api/endpoints";
 export { DaemonSet, daemonSetApi } from "../../renderer/api/endpoints";
@@ -33,7 +33,7 @@ export { StatefulSet, statefulSetApi } from "../../renderer/api/endpoints";
 export { Job, jobApi } from "../../renderer/api/endpoints";
 export { CronJob, cronJobApi } from "../../renderer/api/endpoints";
 export { ConfigMap, configMapApi } from "../../renderer/api/endpoints";
-export { Secret, secretsApi, ISecretRef } from "../../renderer/api/endpoints";
+export { Secret, secretsApi } from "../../renderer/api/endpoints";
 export { ReplicaSet, replicaSetApi } from "../../renderer/api/endpoints";
 export { ResourceQuota, resourceQuotaApi } from "../../renderer/api/endpoints";
 export { LimitRange, limitRangeApi } from "../../renderer/api/endpoints";
@@ -54,7 +54,13 @@ export { RoleBinding, roleBindingApi } from "../../renderer/api/endpoints";
 export { ClusterRole, clusterRoleApi } from "../../renderer/api/endpoints";
 export { ClusterRoleBinding, clusterRoleBindingApi } from "../../renderer/api/endpoints";
 export { CustomResourceDefinition, crdApi } from "../../renderer/api/endpoints";
-export { KubeObjectStatus, KubeObjectStatusLevel } from "./kube-object-status";
+export { KubeObjectStatusLevel } from "./kube-object-status";
+
+// types
+export type { IKubeApiCluster } from "../../renderer/api/kube-api";
+export type { IPodContainer, IPodContainerStatus } from "../../renderer/api/endpoints";
+export type { ISecretRef } from "../../renderer/api/endpoints";
+export type { KubeObjectStatus } from "./kube-object-status";
 
 // stores
 export type { EventStore } from "../../renderer/components/+events/event.store";

src/extensions/renderer-api/navigation.ts

@@ -25,7 +25,7 @@ import { navigation } from "../../renderer/navigation";
 export type { PageParamInit, PageParam } from "../../renderer/navigation/page-param";
 export { navigate, isActiveRoute } from "../../renderer/navigation/helpers";
 export { hideDetails, showDetails, getDetailsUrl } from "../../renderer/components/kube-object/kube-object-details";
-export { IURLParams } from "../../common/utils/buildUrl";
+export type { IURLParams } from "../../common/utils/buildUrl";
 
 // exporting to extensions-api version of helper without `isSystem` flag
 export function createPageParam<V = string>(init: PageParamInit<V>) {

src/extensions/renderer-ipc-store.ts

@@ -21,7 +21,7 @@
 import { ipcRenderer } from "electron";
 import { IpcPrefix, IpcStore } from "./ipc-store";
 import { Disposers } from "./lens-extension";
-import { LensRendererExtension } from "./lens-renderer-extension";
+import type { LensRendererExtension } from "./lens-renderer-extension";
 
 export abstract class RendererIpcStore extends IpcStore {
   constructor(extension: LensRendererExtension) {