Turn on noUnusedLocals, noImplicitReturns, importsNotUsedAsValues: error, and isolatedModules (#2777)

src/main/__test__/kube-auth-proxy.test.ts

@@ -44,6 +44,12 @@ jest.mock("winston", () => ({
   }
 }));
 
+jest.mock("electron", () => ({
+  app: {
+    getPath: () => "/foo",
+  },
+}));
+
 jest.mock("../../common/ipc");
 jest.mock("child_process");
 jest.mock("tcp-port-used");
@@ -56,7 +62,7 @@ import { ChildProcess, spawn } from "child_process";
 import { bundledKubectlPath, Kubectl } from "../kubectl";
 import { mock, MockProxy } from "jest-mock-extended";
 import { waitUntilUsed } from "tcp-port-used";
-import { Readable } from "stream";
+import type { Readable } from "stream";
 import { UserStore } from "../../common/user-store";
 import { Console } from "console";
 import { stdout, stderr } from "process";

src/main/__test__/kubeconfig-manager.test.ts

@@ -28,6 +28,12 @@ const logger = {
   crit: jest.fn(),
 };
 
+jest.mock("electron", () => ({
+  app: {
+    getPath: () => `/tmp`,
+  },
+}));
+
 jest.mock("winston", () => ({
   format: {
     colorize: jest.fn(),
@@ -47,7 +53,7 @@ jest.mock("winston", () => ({
 import { KubeconfigManager } from "../kubeconfig-manager";
 import mockFs from "mock-fs";
 import { Cluster } from "../cluster";
-import { ContextHandler } from "../context-handler";
+import type { ContextHandler } from "../context-handler";
 import fse from "fs-extra";
 import { loadYaml } from "@kubernetes/client-node";
 import { Console } from "console";
@@ -91,7 +97,9 @@ describe("kubeconfig manager tests", () => {
       contextName: "minikube",
       kubeConfigPath: "minikube-config.yml",
     });
-    contextHandler = jest.fn() as any;
+    contextHandler = {
+      ensureServer: () => Promise.resolve(),
+    } as any;
     jest.spyOn(KubeconfigManager.prototype, "resolveProxyUrl", "get").mockReturnValue("http://127.0.0.1:9191/foo");
   });
 
@@ -103,7 +111,7 @@ describe("kubeconfig manager tests", () => {
     const kubeConfManager = new KubeconfigManager(cluster, contextHandler);
 
     expect(logger.error).not.toBeCalled();
-    expect(await kubeConfManager.getPath()).toBe(`tmp${path.sep}kubeconfig-foo`);
+    expect(await kubeConfManager.getPath()).toBe(`${path.sep}tmp${path.sep}kubeconfig-foo`);
     // this causes an intermittent "ENXIO: no such device or address, read" error
     //    const file = await fse.readFile(await kubeConfManager.getPath());
     const file = fse.readFileSync(await kubeConfManager.getPath());

src/main/catalog-pusher.ts

@@ -21,9 +21,9 @@
 
 import { reaction, toJS } from "mobx";
 import { broadcastMessage, subscribeToBroadcast, unsubscribeFromBroadcast } from "../common/ipc";
-import { CatalogEntityRegistry} from "../common/catalog";
+import type { CatalogEntityRegistry} from "../common/catalog";
 import "../common/catalog-entities/kubernetes-cluster";
-import { Disposer } from "../common/utils";
+import type { Disposer } from "../common/utils";
 
 export class CatalogPusher {
   static init(catalog: CatalogEntityRegistry) {

src/main/catalog-sources/__test__/kubeconfig-sync.test.ts

@@ -20,9 +20,9 @@
  */
 
 import { ObservableMap } from "mobx";
-import { CatalogEntity } from "../../../common/catalog";
+import type { CatalogEntity } from "../../../common/catalog";
 import { loadFromOptions } from "../../../common/kube-helpers";
-import { Cluster } from "../../cluster";
+import type { Cluster } from "../../cluster";
 import { computeDiff, configToModels } from "../kubeconfig-sync";
 import mockFs from "mock-fs";
 import fs from "fs";

src/main/catalog-sources/kubeconfig-sync.ts

@@ -24,10 +24,10 @@ import { CatalogEntity, catalogEntityRegistry } from "../../common/catalog";
 import { watch } from "chokidar";
 import fs from "fs";
 import fse from "fs-extra";
-import stream from "stream";
+import type stream from "stream";
 import { Disposer, ExtendedObservableMap, iter, Singleton } from "../../common/utils";
 import logger from "../logger";
-import { KubeConfig } from "@kubernetes/client-node";
+import type { KubeConfig } from "@kubernetes/client-node";
 import { loadConfigFromString, splitConfig, validateKubeConfig } from "../../common/kube-helpers";
 import { Cluster } from "../cluster";
 import { catalogEntityFromCluster } from "../cluster-manager";

src/main/cluster-detectors/base-cluster-detector.ts

@@ -19,8 +19,8 @@
  * CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
  */
 
-import { RequestPromiseOptions } from "request-promise-native";
-import { Cluster } from "../cluster";
+import type { RequestPromiseOptions } from "request-promise-native";
+import type { Cluster } from "../cluster";
 import { k8sRequest } from "../k8s-request";
 
 export type ClusterDetectionResult = {

src/main/cluster-detectors/detector-registry.ts

@@ -20,9 +20,9 @@
  */
 
 import { observable } from "mobx";
-import { ClusterMetadata } from "../../common/cluster-store";
-import { Cluster } from "../cluster";
-import { BaseClusterDetector, ClusterDetectionResult } from "./base-cluster-detector";
+import type { ClusterMetadata } from "../../common/cluster-store";
+import type { Cluster } from "../cluster";
+import type { BaseClusterDetector, ClusterDetectionResult } from "./base-cluster-detector";
 import { ClusterIdDetector } from "./cluster-id-detector";
 import { DistributionDetector } from "./distribution-detector";
 import { LastSeenDetector } from "./last-seen-detector";

src/main/cluster-manager.ts

@@ -24,7 +24,7 @@ import type http from "http";
 import { ipcMain } from "electron";
 import { action, autorun, reaction, toJS } from "mobx";
 import { ClusterStore, getClusterIdFromHost } from "../common/cluster-store";
-import { Cluster } from "./cluster";
+import type { Cluster } from "./cluster";
 import logger from "./logger";
 import { apiKubePrefix } from "../common/vars";
 import { Singleton } from "../common/utils";

src/main/context-handler.ts

@@ -19,7 +19,7 @@
  * CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
  */
 
-import type { PrometheusProvider, PrometheusService } from "./prometheus/provider-registry";
+import type { PrometheusService } from "./prometheus/provider-registry";
 import type { ClusterPrometheusPreferences } from "../common/cluster-store";
 import type { Cluster } from "./cluster";
 import type httpProxy from "http-proxy";
@@ -75,16 +75,15 @@ export class ContextHandler {
     return prometheusProviders.find(p => p.id === this.prometheusProvider);
   }
 
-  async getPrometheusService(): Promise<PrometheusService> {
+  async getPrometheusService(): Promise<PrometheusService | void> {
     const providers = this.prometheusProvider ? prometheusProviders.filter(provider => provider.id == this.prometheusProvider) : prometheusProviders;
-    const prometheusPromises: Promise<PrometheusService>[] = providers.map(async (provider: PrometheusProvider): Promise<PrometheusService> => {
+    const prometheusPromises: Promise<PrometheusService | void>[] = providers.map(async provider => {
       const apiClient = (await this.cluster.getProxyKubeconfig()).makeApiClient(CoreV1Api);
 
-      return await provider.getPrometheusService(apiClient);
+      return provider.getPrometheusService(apiClient);
     });
-    const resolvedPrometheusServices = await Promise.all(prometheusPromises);
 
-    return resolvedPrometheusServices.filter(n => n)[0];
+    return (await Promise.all(prometheusPromises)).find(Boolean);
   }
 
   async getPrometheusPath(): Promise<string> {

src/main/extension-filesystem.ts

@@ -26,7 +26,7 @@ import fse from "fs-extra";
 import { action, observable, toJS } from "mobx";
 import path from "path";
 import { BaseStore } from "../common/base-store";
-import { LensExtensionId } from "../extensions/lens-extension";
+import type { LensExtensionId } from "../extensions/lens-extension";
 
 interface FSProvisionModel {
   extensions: Record<string, string>; // extension names to paths

src/main/helm/__mocks__/helm-chart-manager.ts

@@ -22,7 +22,7 @@
 import { HelmRepo, HelmRepoManager } from "../helm-repo-manager";
 
 export class HelmChartManager {
-  private cache: any = {};
+  cache: any = {};
   private repo: HelmRepo;
 
   constructor(repo: HelmRepo){

src/main/helm/helm-release-manager.ts

@@ -24,7 +24,7 @@ import fse from "fs-extra";
 import * as yaml from "js-yaml";
 import { promiseExec} from "../promise-exec";
 import { helmCli } from "./helm-cli";
-import { Cluster } from "../cluster";
+import type { Cluster } from "../cluster";
 import { toCamelCase } from "../../common/utils/camelCase";
 
 export async function listReleases(pathToKubeconfig: string, namespace?: string) {

src/main/helm/helm-service.ts

@@ -20,11 +20,11 @@
  */
 
 import semver from "semver";
-import { Cluster } from "../cluster";
+import type { Cluster } from "../cluster";
 import logger from "../logger";
 import { HelmRepoManager } from "./helm-repo-manager";
 import { HelmChartManager } from "./helm-chart-manager";
-import { HelmChartList, RepoHelmChartList } from "../../renderer/api/endpoints/helm-charts.api";
+import type { HelmChartList, RepoHelmChartList } from "../../renderer/api/endpoints/helm-charts.api";
 import { deleteRelease, getHistory, getRelease, getValues, installChart, listReleases, rollback, upgradeRelease } from "./helm-release-manager";
 
 class HelmService {

src/main/k8s-request.ts

@@ -21,9 +21,9 @@
 
 import request, { RequestPromiseOptions } from "request-promise-native";
 import { apiKubePrefix } from "../common/vars";
-import { IMetricsReqParams } from "../renderer/api/endpoints/metrics.api";
+import type { IMetricsReqParams } from "../renderer/api/endpoints/metrics.api";
 import { LensProxy } from "./proxy/lens-proxy";
-import { Cluster } from "./cluster";
+import type { Cluster } from "./cluster";
 
 export async function k8sRequest<T = any>(cluster: Cluster, path: string, options: RequestPromiseOptions = {}): Promise<T> {
   const kubeProxyUrl = `http://localhost:${LensProxy.getInstance().port}${apiKubePrefix}`;

src/main/kubeconfig-manager.ts

@@ -71,6 +71,7 @@ export class KubeconfigManager {
       await this.contextHandler.ensureServer();
       this.tempFile = await this.createProxyKubeconfig();
     } catch (err) {
+      console.log(err);
       logger.error(`Failed to created temp config for auth-proxy`, { err });
     }
   }
@@ -86,7 +87,7 @@ export class KubeconfigManager {
   protected async createProxyKubeconfig(): Promise<string> {
     const { configDir, cluster } = this;
     const { contextName, kubeConfigPath, id } = cluster;
-    const tempFile = path.join(configDir, `kubeconfig-${id}`);
+    const tempFile = path.normalize(path.join(configDir, `kubeconfig-${id}`));
     const kubeConfig = loadConfig(kubeConfigPath);
     const proxyConfig: Partial<KubeConfig> = {
       currentContext: contextName,

src/main/lens-binary.ts

@@ -25,7 +25,7 @@ import request from "request";
 import { ensureDir, pathExists } from "fs-extra";
 import * as tar from "tar";
 import { isWindows } from "../common/vars";
-import winston from "winston";
+import type winston from "winston";
 
 export type LensBinaryOpts = {
   version: string;
@@ -204,7 +204,7 @@ export class LensBinary {
       throw(error);
     });
 
-    return new Promise((resolve, reject) => {
+    return new Promise<void>((resolve, reject) => {
       file.on("close", () => {
         this.logger.debug(`${this.originalBinaryName} binary download closed`);
         if (!this.tarPath) fs.chmod(binaryPath, 0o755, (err) => {

src/main/menu.ts

@@ -21,7 +21,7 @@
 
 import { app, BrowserWindow, dialog, ipcMain, IpcMainEvent, Menu, MenuItem, MenuItemConstructorOptions, webContents, shell } from "electron";
 import { autorun } from "mobx";
-import { WindowManager } from "./window-manager";
+import type { WindowManager } from "./window-manager";
 import { appName, isMac, isWindows, isTestEnv, docsUrl, supportUrl, productName } from "../common/vars";
 import { addClusterURL } from "../renderer/components/+add-cluster/add-cluster.route";
 import { preferencesURL } from "../renderer/components/+preferences/preferences.route";

src/main/prometheus/helm.ts

@@ -20,8 +20,8 @@
  */
 
 import { PrometheusLens } from "./lens";
-import { CoreV1Api } from "@kubernetes/client-node";
-import { PrometheusService } from "./provider-registry";
+import type { CoreV1Api } from "@kubernetes/client-node";
+import type { PrometheusService } from "./provider-registry";
 import logger from "../logger";
 
 export class PrometheusHelm extends PrometheusLens {
@@ -29,7 +29,7 @@ export class PrometheusHelm extends PrometheusLens {
   name = "Helm";
   rateAccuracy = "5m";
 
-  public async getPrometheusService(client: CoreV1Api): Promise<PrometheusService> {
+  public async getPrometheusService(client: CoreV1Api): Promise<PrometheusService | void> {
     const labelSelector = "app=prometheus,component=server,heritage=Helm";
 
     try {

src/main/prometheus/lens.ts

@@ -19,8 +19,8 @@
  * CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
  */
 
-import { PrometheusProvider, PrometheusQueryOpts, PrometheusQuery, PrometheusService } from "./provider-registry";
-import { CoreV1Api } from "@kubernetes/client-node";
+import type { PrometheusProvider, PrometheusQueryOpts, PrometheusQuery, PrometheusService } from "./provider-registry";
+import type { CoreV1Api } from "@kubernetes/client-node";
 import logger from "../logger";
 
 export class PrometheusLens implements PrometheusProvider {
@@ -28,7 +28,7 @@ export class PrometheusLens implements PrometheusProvider {
   name = "Lens";
   rateAccuracy = "1m";
 
-  public async getPrometheusService(client: CoreV1Api): Promise<PrometheusService> {
+  public async getPrometheusService(client: CoreV1Api): Promise<PrometheusService | void> {
     try {
       const resp = await client.readNamespacedService("prometheus", "lens-metrics");
       const service = resp.body;
@@ -44,7 +44,7 @@ export class PrometheusLens implements PrometheusProvider {
     }
   }
 
-  public getQueries(opts: PrometheusQueryOpts): PrometheusQuery {
+  public getQueries(opts: PrometheusQueryOpts): PrometheusQuery | void {
     switch(opts.category) {
       case "cluster":
         return {

src/main/prometheus/operator.ts

@@ -19,8 +19,8 @@
  * CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
  */
 
-import { PrometheusProvider, PrometheusQueryOpts, PrometheusQuery, PrometheusService } from "./provider-registry";
-import { CoreV1Api, V1Service } from "@kubernetes/client-node";
+import type { PrometheusProvider, PrometheusQueryOpts, PrometheusQuery, PrometheusService } from "./provider-registry";
+import type { CoreV1Api, V1Service } from "@kubernetes/client-node";
 import logger from "../logger";
 
 export class PrometheusOperator implements PrometheusProvider {
@@ -28,7 +28,7 @@ export class PrometheusOperator implements PrometheusProvider {
   id = "operator";
   name = "Prometheus Operator";
 
-  public async getPrometheusService(client: CoreV1Api): Promise<PrometheusService> {
+  public async getPrometheusService(client: CoreV1Api): Promise<PrometheusService | void> {
     try {
       let service: V1Service;
 
@@ -54,7 +54,7 @@ export class PrometheusOperator implements PrometheusProvider {
     }
   }
 
-  public getQueries(opts: PrometheusQueryOpts): PrometheusQuery {
+  public getQueries(opts: PrometheusQueryOpts): PrometheusQuery | void {
     switch(opts.category) {
       case "cluster":
         return {

src/main/prometheus/provider-registry.ts

@@ -19,7 +19,7 @@
  * CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
  */
 
-import { CoreV1Api } from "@kubernetes/client-node";
+import type { CoreV1Api } from "@kubernetes/client-node";
 
 export type PrometheusClusterQuery = {
   memoryUsage: string;
@@ -83,8 +83,8 @@ export type PrometheusService = {
 export interface PrometheusProvider {
   id: string;
   name: string;
-  getQueries(opts: PrometheusQueryOpts): PrometheusQuery;
-  getPrometheusService(client: CoreV1Api): Promise<PrometheusService>;
+  getQueries(opts: PrometheusQueryOpts): PrometheusQuery | void;
+  getPrometheusService(client: CoreV1Api): Promise<PrometheusService | void>;
 }
 
 export type PrometheusProviderList = {

src/main/prometheus/stacklight.ts

@@ -19,8 +19,8 @@
  * CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
  */
 
-import { PrometheusProvider, PrometheusQueryOpts, PrometheusQuery, PrometheusService } from "./provider-registry";
-import { CoreV1Api } from "@kubernetes/client-node";
+import type { PrometheusProvider, PrometheusQueryOpts, PrometheusQuery, PrometheusService } from "./provider-registry";
+import type { CoreV1Api } from "@kubernetes/client-node";
 import logger from "../logger";
 
 export class PrometheusStacklight implements PrometheusProvider {
@@ -28,7 +28,7 @@ export class PrometheusStacklight implements PrometheusProvider {
   name = "Stacklight";
   rateAccuracy = "1m";
 
-  public async getPrometheusService(client: CoreV1Api): Promise<PrometheusService> {
+  public async getPrometheusService(client: CoreV1Api): Promise<PrometheusService | void> {
     try {
       const resp = await client.readNamespacedService("prometheus-server", "stacklight");
       const service = resp.body;
@@ -44,7 +44,7 @@ export class PrometheusStacklight implements PrometheusProvider {
     }
   }
 
-  public getQueries(opts: PrometheusQueryOpts): PrometheusQuery {
+  public getQueries(opts: PrometheusQueryOpts): PrometheusQuery | void {
     switch(opts.category) {
       case "cluster":
         return {

src/main/protocol-handler/router.ts

@@ -22,7 +22,7 @@
 import logger from "../logger";
 import * as proto from "../../common/protocol-handler";
 import Url from "url-parse";
-import { LensExtension } from "../../extensions/lens-extension";
+import type { LensExtension } from "../../extensions/lens-extension";
 import { broadcastMessage } from "../../common/ipc";
 import { observable, when } from "mobx";
 

src/main/proxy/index.ts

@@ -21,3 +21,5 @@
 
 // Don't export the contents here
 // It will break the extension webpack
+
+export default {};

src/main/proxy/lens-proxy.ts

@@ -20,13 +20,13 @@
  */
 
 import net from "net";
-import http from "http";
+import type http from "http";
 import spdy from "spdy";
 import httpProxy from "http-proxy";
 import url from "url";
 import { apiPrefix, apiKubePrefix } from "../../common/vars";
 import { Router } from "../router";
-import { ContextHandler } from "../context-handler";
+import type { ContextHandler } from "../context-handler";
 import logger from "../logger";
 import { Singleton } from "../../common/utils";
 import { ClusterManager } from "../cluster-manager";
@@ -205,13 +205,13 @@ export class LensProxy extends Singleton {
     return proxy;
   }
 
-  protected async getProxyTarget(req: http.IncomingMessage, contextHandler: ContextHandler): Promise<httpProxy.ServerOptions> {
+  protected async getProxyTarget(req: http.IncomingMessage, contextHandler: ContextHandler): Promise<httpProxy.ServerOptions | void> {
     if (req.url.startsWith(apiKubePrefix)) {
       delete req.headers.authorization;
       req.url = req.url.replace(apiKubePrefix, "");
       const isWatchRequest = req.url.includes("watch=");
 
-      return await contextHandler.getApiTarget(isWatchRequest);
+      return contextHandler.getApiTarget(isWatchRequest);
     }
   }
 

src/main/proxy/ws-upgrade.ts

@@ -26,8 +26,8 @@
  */
 
 import * as WebSocket from "ws";
-import http from "http";
-import net from "net";
+import type http from "http";
+import type net from "net";
 import url from "url";
 import { NodeShellSession, LocalShellSession } from "../shell-session";
 import { ClusterManager } from "../cluster-manager";

src/main/resource-applier.ts

@@ -20,7 +20,7 @@
  */
 
 import type { Cluster } from "./cluster";
-import { KubernetesObject } from "@kubernetes/client-node";
+import type { KubernetesObject } from "@kubernetes/client-node";
 import { exec } from "child_process";
 import fs from "fs";
 import * as yaml from "js-yaml";

src/main/router.ts

@@ -21,10 +21,10 @@
 
 import Call from "@hapi/call";
 import Subtext from "@hapi/subtext";
-import http from "http";
+import type http from "http";
 import path from "path";
 import { readFile } from "fs-extra";
-import { Cluster } from "./cluster";
+import type { Cluster } from "./cluster";
 import { apiPrefix, appName, publicPath, isDevelopment, webpackDevServerPort } from "../common/vars";
 import { HelmApiRoute, KubeconfigRoute, MetricsRoute, PortForwardRoute, ResourceApplierApiRoute, VersionRoute } from "./routes";
 import logger from "./logger";

src/main/routes/helm-route.ts

@@ -19,7 +19,7 @@
  * CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
  */
 
-import { LensApiRequest } from "../router";
+import type { LensApiRequest } from "../router";
 import { helmService } from "../helm/helm-service";
 import { respondJson, respondText } from "../utils/http-responses";
 import logger from "../logger";

src/main/routes/kubeconfig-route.ts

@@ -19,9 +19,9 @@
  * CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
  */
 
-import { LensApiRequest } from "../router";
+import type { LensApiRequest } from "../router";
 import { respondJson } from "../utils/http-responses";
-import { Cluster } from "../cluster";
+import type { Cluster } from "../cluster";
 import { CoreV1Api, V1Secret } from "@kubernetes/client-node";
 
 function generateKubeConfig(username: string, secret: V1Secret, cluster: Cluster) {

src/main/routes/metrics-route.ts

@@ -20,10 +20,10 @@
  */
 
 import _ from "lodash";
-import { LensApiRequest } from "../router";
+import type { LensApiRequest } from "../router";
 import { respondJson } from "../utils/http-responses";
 import { Cluster, ClusterMetadataKey } from "../cluster";
-import { ClusterPrometheusMetadata } from "../../common/cluster-store";
+import type { ClusterPrometheusMetadata } from "../../common/cluster-store";
 import logger from "../logger";
 import { getMetrics } from "../k8s-request";
 

src/main/routes/port-forward-route.ts

@@ -19,7 +19,7 @@
  * CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
  */
 
-import { LensApiRequest } from "../router";
+import type { LensApiRequest } from "../router";
 import { spawn, ChildProcessWithoutNullStreams } from "child_process";
 import { Kubectl } from "../kubectl";
 import { shell } from "electron";

src/main/routes/resource-applier-route.ts

@@ -19,7 +19,7 @@
  * CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
  */
 
-import { LensApiRequest } from "../router";
+import type { LensApiRequest } from "../router";
 import { respondJson, respondText } from "../utils/http-responses";
 import { ResourceApplier } from "../resource-applier";
 

src/main/routes/version-route.ts

@@ -19,7 +19,7 @@
  * CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
  */
 
-import { LensApiRequest } from "../router";
+import type { LensApiRequest } from "../router";
 import { respondJson } from "../utils/http-responses";
 import { getAppVersion } from "../../common/utils";
 

src/main/shell-session/node-shell-session.ts

@@ -19,11 +19,11 @@
  * CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
  */
 
-import * as WebSocket from "ws";
+import type * as WebSocket from "ws";
 import { v4 as uuid } from "uuid";
 import * as k8s from "@kubernetes/client-node";
-import { KubeConfig } from "@kubernetes/client-node";
-import { Cluster } from "../cluster";
+import type { KubeConfig } from "@kubernetes/client-node";
+import type { Cluster } from "../cluster";
 import { ShellOpenError, ShellSession } from "./shell-session";
 
 export class NodeShellSession extends ShellSession {

src/main/shell-session/shell-session.ts

@@ -19,9 +19,9 @@
  * CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
  */
 
-import { Cluster } from "../cluster";
+import type { Cluster } from "../cluster";
 import { Kubectl } from "../kubectl";
-import * as WebSocket from "ws";
+import type * as WebSocket from "ws";
 import shellEnv from "shell-env";
 import { app } from "electron";
 import { clearKubeconfigEnvVars } from "../utils/clear-kube-env-vars";

src/main/tray.ts

@@ -25,7 +25,7 @@ import { Menu, Tray } from "electron";
 import { autorun } from "mobx";
 import { showAbout } from "./menu";
 import { checkForUpdates, isAutoUpdateEnabled } from "./app-updater";
-import { WindowManager } from "./window-manager";
+import type { WindowManager } from "./window-manager";
 import { preferencesURL } from "../renderer/components/+preferences/preferences.route";
 import logger from "./logger";
 import { isDevelopment, isWindows, productName } from "../common/vars";

src/main/utils/get-port.ts

@@ -19,7 +19,7 @@
  * CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
  */
 
-import { Readable } from "stream";
+import type { Readable } from "stream";
 import URLParse from "url-parse";
 
 interface GetPortArgs {

src/main/utils/http-responses.ts

@@ -19,7 +19,7 @@
  * CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
  */
 
-import http from "http";
+import type http from "http";
 
 export function respondJson(res: http.ServerResponse, content: any, status = 200) {
   respond(res, JSON.stringify(content), "application/json", status);