Turn on noUnusedLocals, noImplicitReturns, importsNotUsedAsValues: error, and isolatedModules (#2777)

src/renderer/api/__tests__/crd.test.ts

@@ -20,7 +20,7 @@
  */
 
 import { CustomResourceDefinition } from "../endpoints";
-import { IKubeObjectMetadata } from "../kube-object";
+import type { IKubeObjectMetadata } from "../kube-object";
 
 describe("Crds", () => {
   describe("getVersion", () => {

src/renderer/api/catalog-entity.ts

@@ -21,18 +21,17 @@
 
 import { navigate } from "../navigation";
 import { commandRegistry } from "../../extensions/registries";
-import { CatalogEntity } from "../../common/catalog";
+import type { CatalogEntity } from "../../common/catalog";
 
-export {
-  CatalogCategory,
-  CatalogEntity,
+export { CatalogCategory, CatalogEntity } from "../../common/catalog";
+export type {
   CatalogEntityData,
   CatalogEntityKindData,
   CatalogEntityActionContext,
   CatalogEntityAddMenuContext,
   CatalogEntityAddMenu,
   CatalogEntityContextMenu,
-  CatalogEntityContextMenuContext
+  CatalogEntityContextMenuContext,
 } from "../../common/catalog";
 
 export const catalogEntityRunContext = {

src/renderer/api/endpoints/configmap.api.ts

@@ -20,7 +20,7 @@
  */
 
 import { KubeObject } from "../kube-object";
-import { KubeJsonApiData } from "../kube-json-api";
+import type { KubeJsonApiData } from "../kube-json-api";
 import { autobind } from "../../utils";
 import { KubeApi } from "../kube-api";
 

src/renderer/api/endpoints/cron-job.api.ts

@@ -21,7 +21,7 @@
 
 import moment from "moment";
 import { KubeObject } from "../kube-object";
-import { IPodContainer } from "./pods.api";
+import type { IPodContainer } from "./pods.api";
 import { formatDuration } from "../../utils/formatDuration";
 import { autobind } from "../../utils";
 import { KubeApi } from "../kube-api";

src/renderer/api/endpoints/daemon-set.api.ts

@@ -20,7 +20,7 @@
  */
 
 import get from "lodash/get";
-import { IPodContainer } from "./pods.api";
+import type { IPodContainer } from "./pods.api";
 import { IAffinity, WorkloadKubeObject } from "../workload-kube-object";
 import { autobind } from "../../utils";
 import { KubeApi } from "../kube-api";

src/renderer/api/endpoints/helm-releases.api.ts

@@ -25,9 +25,9 @@ import { autobind, formatDuration } from "../../utils";
 import capitalize from "lodash/capitalize";
 import { apiBase } from "../index";
 import { helmChartStore } from "../../components/+apps-helm-charts/helm-chart.store";
-import { ItemObject } from "../../item.store";
+import type { ItemObject } from "../../item.store";
 import { KubeObject } from "../kube-object";
-import { JsonApiData } from "../json-api";
+import type { JsonApiData } from "../json-api";
 
 interface IReleasePayload {
   name: string;

src/renderer/api/endpoints/job.api.ts

@@ -22,9 +22,9 @@
 import get from "lodash/get";
 import { autobind } from "../../utils";
 import { IAffinity, WorkloadKubeObject } from "../workload-kube-object";
-import { IPodContainer } from "./pods.api";
+import type { IPodContainer } from "./pods.api";
 import { KubeApi } from "../kube-api";
-import { JsonApiParams } from "../json-api";
+import type { JsonApiParams } from "../json-api";
 
 @autobind()
 export class Job extends WorkloadKubeObject {
@@ -106,11 +106,7 @@ export class Job extends WorkloadKubeObject {
   getCondition() {
     // Type of Job condition could be only Complete or Failed
     // https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.14/#jobcondition-v1-batch
-    const { conditions } = this.status;
-
-    if (!conditions) return;
-
-    return conditions.find(({ status }) => status === "True");
+    return this.status.conditions?.find(({ status }) => status === "True");
   }
 
   getImages() {

src/renderer/api/endpoints/metrics.api.ts

@@ -132,11 +132,11 @@ export function normalizeMetrics(metrics: IMetrics, frames = 60): IMetrics {
   return metrics;
 }
 
-export function isMetricsEmpty(metrics: { [key: string]: IMetrics }) {
+export function isMetricsEmpty(metrics: Record<string, IMetrics>) {
   return Object.values(metrics).every(metric => !metric?.data?.result?.length);
 }
 
-export function getItemMetrics(metrics: { [key: string]: IMetrics }, itemName: string): { [key: string]: IMetrics } {
+export function getItemMetrics(metrics: Record<string, IMetrics>, itemName: string): Record<string, IMetrics> | void {
   if (!metrics) return;
   const itemMetrics = { ...metrics };
 
@@ -153,7 +153,7 @@ export function getItemMetrics(metrics: { [key: string]: IMetrics }, itemName: s
   return itemMetrics;
 }
 
-export function getMetricLastPoints(metrics: { [key: string]: IMetrics }) {
+export function getMetricLastPoints(metrics: Record<string, IMetrics>) {
   const result: Partial<{ [metric: string]: number }> = {};
 
   Object.keys(metrics).forEach(metricName => {

src/renderer/api/endpoints/persistent-volume-claims.api.ts

@@ -22,7 +22,7 @@
 import { KubeObject } from "../kube-object";
 import { autobind } from "../../utils";
 import { IMetrics, metricsApi } from "./metrics.api";
-import { Pod } from "./pods.api";
+import type { Pod } from "./pods.api";
 import { KubeApi } from "../kube-api";
 
 export class PersistentVolumeClaimsApi extends KubeApi<PersistentVolumeClaim> {

src/renderer/api/endpoints/persistent-volume.api.ts

@@ -61,7 +61,7 @@ export class PersistentVolume extends KubeObject {
     };
   };
 
-  status: {
+  status?: {
     phase: string;
     reason?: string;
   };
@@ -79,9 +79,7 @@ export class PersistentVolume extends KubeObject {
   }
 
   getStatus() {
-    if (!this.status) return;
-
-    return this.status.phase || "-";
+    return this.status?.phase || "-";
   }
 
   getStorageClass(): string {

src/renderer/api/endpoints/replica-set.api.ts

@@ -22,7 +22,7 @@
 import get from "lodash/get";
 import { autobind } from "../../utils";
 import { WorkloadKubeObject } from "../workload-kube-object";
-import { IPodContainer, Pod } from "./pods.api";
+import type { IPodContainer, Pod } from "./pods.api";
 import { KubeApi } from "../kube-api";
 
 export class ReplicaSetApi extends KubeApi<ReplicaSet> {

src/renderer/api/endpoints/resource-applier.api.ts

@@ -21,7 +21,7 @@
 
 import jsYaml from "js-yaml";
 import { KubeObject } from "../kube-object";
-import { KubeJsonApiData } from "../kube-json-api";
+import type { KubeJsonApiData } from "../kube-json-api";
 import { apiBase } from "../index";
 import { apiManager } from "../api-manager";
 

src/renderer/api/endpoints/resource-quota.api.ts

@@ -21,7 +21,7 @@
 
 import { KubeObject } from "../kube-object";
 import { KubeApi } from "../kube-api";
-import { KubeJsonApiData } from "../kube-json-api";
+import type { KubeJsonApiData } from "../kube-json-api";
 
 export interface IResourceQuotaValues {
   [quota: string]: string;

src/renderer/api/endpoints/secret.api.ts

@@ -20,7 +20,7 @@
  */
 
 import { KubeObject } from "../kube-object";
-import { KubeJsonApiData } from "../kube-json-api";
+import type { KubeJsonApiData } from "../kube-json-api";
 import { autobind } from "../../utils";
 import { KubeApi } from "../kube-api";
 

src/renderer/api/endpoints/stateful-set.api.ts

@@ -20,7 +20,7 @@
  */
 
 import get from "lodash/get";
-import { IPodContainer } from "./pods.api";
+import type { IPodContainer } from "./pods.api";
 import { IAffinity, WorkloadKubeObject } from "../workload-kube-object";
 import { autobind } from "../../utils";
 import { KubeApi } from "../kube-api";

src/renderer/api/kube-api.ts

@@ -30,7 +30,7 @@ import { apiKube } from "./index";
 import { createKubeApiURL, parseKubeApi } from "./kube-api-parse";
 import { IKubeObjectConstructor, KubeObject, KubeStatus } from "./kube-object";
 import byline from "byline";
-import { IKubeWatchEvent } from "./kube-watch-api";
+import type { IKubeWatchEvent } from "./kube-watch-api";
 import { ReadableWebToNodeStream } from "../utils/readableStream";
 import { KubeJsonApi, KubeJsonApiData } from "./kube-json-api";
 import { noop } from "../utils";
@@ -306,7 +306,7 @@ export class KubeApi<T extends KubeObject = any> {
   }
 
   protected parseResponse(data: unknown, namespace?: string): T | T[] | null {
-    if (!data) return;
+    if (!data) return null;
     const KubeObjectConstructor = this.objectConstructor;
 
     // process items list response, check before single item since there is overlap

src/renderer/api/kube-object.ts

@@ -22,11 +22,11 @@
 // Base class for all kubernetes objects
 
 import moment from "moment";
-import { KubeJsonApiData, KubeJsonApiDataList, KubeJsonApiListMetadata, KubeJsonApiMetadata } from "./kube-json-api";
+import type { KubeJsonApiData, KubeJsonApiDataList, KubeJsonApiListMetadata, KubeJsonApiMetadata } from "./kube-json-api";
 import { autobind, formatDuration } from "../utils";
-import { ItemObject } from "../item.store";
+import type { ItemObject } from "../item.store";
 import { apiKube } from "./index";
-import { JsonApiParams } from "./json-api";
+import type { JsonApiParams } from "./json-api";
 import { resourceApplierApi } from "./endpoints/resource-applier.api";
 import { hasOptionalProperty, hasTypedProperty, isObject, isString, bindPredicate, isTypedArray, isRecord } from "../../common/utils/type-narrowing";
 

src/renderer/api/kube-watch-api.ts

@@ -28,8 +28,8 @@ import type { ClusterContext } from "../components/context";
 import plimit from "p-limit";
 import { comparer, IReactionDisposer, observable, reaction, when } from "mobx";
 import { autobind, noop } from "../utils";
-import { KubeApi } from "./kube-api";
-import { KubeJsonApiData } from "./kube-json-api";
+import type { KubeApi } from "./kube-api";
+import type { KubeJsonApiData } from "./kube-json-api";
 import { isDebugging, isProduction } from "../../common/vars";
 
 export interface IKubeWatchEvent<T = KubeJsonApiData> {

src/renderer/api/terminal-api.ts

@@ -108,7 +108,7 @@ export class TerminalApi extends WebSocketApi {
 
   @autobind()
   protected _onReady(data: string) {
-    if (!data) return;
+    if (!data) return true;
     this.isReady = true;
     this.onReady.emit();
     this.onData.removeListener(this._onReady);