Turn on noUnusedLocals, noImplicitReturns, importsNotUsedAsValues: error, and isolatedModules (#2777)

src/renderer/components/+apps-releases/release-menu.tsx

@@ -20,7 +20,7 @@
  */
 
 import React from "react";
-import { HelmRelease } from "../../api/endpoints/helm-releases.api";
+import type { HelmRelease } from "../../api/endpoints/helm-releases.api";
 import { autobind, cssNames } from "../../utils";
 import { releaseStore } from "./release.store";
 import { MenuActions, MenuActionsProps } from "../menu/menu-actions";
@@ -56,7 +56,7 @@ export class HelmReleaseMenu extends React.Component<Props> {
   renderContent() {
     const { release, toolbar } = this.props;
 
-    if (!release) return;
+    if (!release) return null;
     const hasRollback = release && release.getRevision() > 1;
 
     return (

src/renderer/components/+apps-releases/release.store.ts

@@ -24,7 +24,7 @@ import { action, observable, reaction, when } from "mobx";
 import { autobind } from "../../utils";
 import { createRelease, deleteRelease, HelmRelease, IReleaseCreatePayload, IReleaseUpdatePayload, listReleases, rollbackRelease, updateRelease } from "../../api/endpoints/helm-releases.api";
 import { ItemStore } from "../../item.store";
-import { Secret } from "../../api/endpoints";
+import type { Secret } from "../../api/endpoints";
 import { secretsStore } from "../+config-secrets/secrets.store";
 import { namespaceStore } from "../+namespaces/namespace.store";
 import { Notifications } from "../notifications";
@@ -146,8 +146,6 @@ export class ReleaseStore extends ItemStore<HelmRelease> {
   }
 
   async removeSelectedItems() {
-    if (!this.selectedItems.length) return;
-
     return Promise.all(this.selectedItems.map(this.remove));
   }
 }

src/renderer/components/+apps-releases/releases.tsx

@@ -24,10 +24,10 @@ import "./releases.scss";
 import React, { Component } from "react";
 import kebabCase from "lodash/kebabCase";
 import { disposeOnUnmount, observer } from "mobx-react";
-import { RouteComponentProps } from "react-router";
+import type { RouteComponentProps } from "react-router";
 import { releaseStore } from "./release.store";
 import { IReleaseRouteParams, releaseURL } from "./release.route";
-import { HelmRelease } from "../../api/endpoints/helm-releases.api";
+import type { HelmRelease } from "../../api/endpoints/helm-releases.api";
 import { ReleaseDetails } from "./release-details";
 import { ReleaseRollbackDialog } from "./release-rollback-dialog";
 import { navigation } from "../../navigation";