Turn on noUnusedLocals, noImplicitReturns, importsNotUsedAsValues: error, and isolatedModules (#2777)

src/renderer/components/cluster-manager/bottom-bar.test.tsx

@@ -23,6 +23,12 @@ import React from "react";
 import { render } from "@testing-library/react";
 import "@testing-library/jest-dom/extend-expect";
 
+jest.mock("electron", () => ({
+  app: {
+    getPath: () => "/foo",
+  },
+}));
+
 import { BottomBar } from "./bottom-bar";
 jest.mock("../../../extensions/registries");
 import { statusBarRegistry } from "../../../extensions/registries";

src/renderer/components/cluster-manager/bottom-bar.tsx

@@ -44,14 +44,14 @@ export class BottomBar extends React.Component {
     const items = statusBarRegistry.getItems();
 
     if (!Array.isArray(items)) {
-      return;
+      return null;
     }
 
     return (
       <div className="extensions box grow flex gaps justify-flex-end">
         {items.map((registration, index) => {
           if (!registration?.item && !registration?.components?.Item) {
-            return;
+            return null;
           }
 
           return (

src/renderer/components/cluster-manager/cluster-status.tsx

@@ -30,7 +30,7 @@ import { requestMain, subscribeToBroadcast } from "../../../common/ipc";
 import { Icon } from "../icon";
 import { Button } from "../button";
 import { cssNames, IClassName } from "../../utils";
-import { Cluster } from "../../../main/cluster";
+import type { Cluster } from "../../../main/cluster";
 import { ClusterId, ClusterStore } from "../../../common/cluster-store";
 import { CubeSpinner } from "../spinner";
 import { clusterActivateHandler } from "../../../common/cluster-ipc";

src/renderer/components/cluster-manager/cluster-view.tsx

@@ -23,11 +23,11 @@ import "./cluster-view.scss";
 import React from "react";
 import { reaction } from "mobx";
 import { disposeOnUnmount, observer } from "mobx-react";
-import { RouteComponentProps } from "react-router";
-import { IClusterViewRouteParams } from "./cluster-view.route";
+import type { RouteComponentProps } from "react-router";
+import type { IClusterViewRouteParams } from "./cluster-view.route";
 import { ClusterStatus } from "./cluster-status";
 import { hasLoadedView, initView, lensViews, refreshViews } from "./lens-views";
-import { Cluster } from "../../../main/cluster";
+import type { Cluster } from "../../../main/cluster";
 import { ClusterStore } from "../../../common/cluster-store";
 import { requestMain } from "../../../common/ipc";
 import { clusterActivateHandler } from "../../../common/cluster-ipc";