Turn on noUnusedLocals, noImplicitReturns, importsNotUsedAsValues: error, and isolatedModules (#2777)

This commit is contained in:
Sebastian Malton authored and GitHub committed 2021-05-19 12:11:54 -04:00
1 parent 489cef9595
commit 5ed4537979
287 files changed
+704 -628

No files matched your search

@@ -25,7 +25,7 @@ import React from "react";
import { observable, reaction } from "mobx";
import { disposeOnUnmount, observer } from "mobx-react";
import { cssNames } from "../../utils";
import { IDockTab } from "./dock.store";
import type { IDockTab } from "./dock.store";
import { InfoPanel } from "./info-panel";
import { upgradeChartStore } from "./upgrade-chart.store";
import { Spinner } from "../spinner";
@@ -33,7 +33,7 @@ import { releaseStore } from "../+apps-releases/release.store";
import { Badge } from "../badge";
import { EditorPanel } from "./editor-panel";
import { helmChartStore, IChartVersion } from "../+apps-helm-charts/helm-chart.store";
import { HelmRelease } from "../../api/endpoints/helm-releases.api";
import type { HelmRelease } from "../../api/endpoints/helm-releases.api";
import { Select, SelectOption } from "../select";
interface Props {
@@ -62,7 +62,7 @@ export class UpgradeChart extends React.Component<Props> {
get release(): HelmRelease {
const tabData = upgradeChartStore.getData(this.tabId);
if (!tabData) return;
if (!tabData) return null;
return releaseStore.getByName(tabData.releaseName);
}
@@ -87,7 +87,7 @@ export class UpgradeChart extends React.Component<Props> {
};
upgrade = async () => {
if (this.error) return;
if (this.error) return null;
const { version, repo } = this.version;
const releaseName = this.release.getName();
const releaseNs = this.release.getNs();