Turn on noUnusedLocals, noImplicitReturns, importsNotUsedAsValues: error, and isolatedModules (#2777)

src/renderer/components/input/drop-file-input.tsx

@@ -82,9 +82,8 @@ export class DropFileInput<T extends HTMLElement = any> extends React.Component<
       if (disabled) {
         return contentElem;
       }
-      const isValidContentElem = React.isValidElement(contentElem);
 
-      if (isValidContentElem) {
+      if (React.isValidElement(contentElem)) {
         const contentElemProps: React.HTMLProps<HTMLElement> = {
           className: cssNames("DropFileInput", contentElem.props.className, className, {
             droppable: this.dropAreaActive,
@@ -97,6 +96,8 @@ export class DropFileInput<T extends HTMLElement = any> extends React.Component<
 
         return React.cloneElement(contentElem, contentElemProps);
       }
+
+      return null;
     } catch (err) {
       logger.error(`Error: <DropFileInput/> must contain only single child element`);
 

src/renderer/components/input/input.tsx

@@ -26,7 +26,7 @@ import { autobind, cssNames, debouncePromise, getRandId } from "../../utils";
 import { Icon } from "../icon";
 import { Tooltip, TooltipProps } from "../tooltip";
 import * as Validators from "./input_validators";
-import { InputValidator } from "./input_validators";
+import type { InputValidator } from "./input_validators";
 import isString from "lodash/isString";
 import isFunction from "lodash/isFunction";
 import isBoolean from "lodash/isBoolean";
@@ -34,7 +34,8 @@ import uniqueId from "lodash/uniqueId";
 
 const { conditionalValidators, ...InputValidators } = Validators;
 
-export { InputValidators, InputValidator };
+export { InputValidators };
+export type { InputValidator };
 
 type InputElement = HTMLInputElement | HTMLTextAreaElement;
 type InputElementProps = InputHTMLAttributes<InputElement> & TextareaHTMLAttributes<InputElement> & DOMAttributes<InputElement>;

src/renderer/components/input/input_validators.ts

@@ -20,7 +20,7 @@
  */
 
 import type { InputProps } from "./input";
-import { ReactNode } from "react";
+import type { ReactNode } from "react";
 import fse from "fs-extra";
 
 export interface InputValidator {

src/renderer/components/input/search-input-url.tsx

@@ -23,7 +23,7 @@ import React from "react";
 import debounce from "lodash/debounce";
 import { autorun, observable } from "mobx";
 import { disposeOnUnmount, observer } from "mobx-react";
-import { InputProps } from "./input";
+import type { InputProps } from "./input";
 import { SearchInput } from "./search-input";
 import { createPageParam } from "../../navigation";