Turn on noUnusedLocals, noImplicitReturns, importsNotUsedAsValues: error, and isolatedModules (#2777)

src/renderer/components/kube-object/kube-object-details.tsx

@@ -26,7 +26,7 @@ import { disposeOnUnmount, observer } from "mobx-react";
 import { computed, observable, reaction } from "mobx";
 import { createPageParam, navigation } from "../../navigation";
 import { Drawer } from "../drawer";
-import { KubeObject } from "../../api/kube-object";
+import type { KubeObject } from "../../api/kube-object";
 import { Spinner } from "../spinner";
 import { apiManager } from "../../api/api-manager";
 import { crdStore } from "../+custom-resources/crd.store";

src/renderer/components/kube-object/kube-object-list-layout.tsx

@@ -23,9 +23,9 @@ import React from "react";
 import { computed } from "mobx";
 import { disposeOnUnmount, observer } from "mobx-react";
 import { cssNames } from "../../utils";
-import { KubeObject } from "../../api/kube-object";
+import type { KubeObject } from "../../api/kube-object";
 import { ItemListLayout, ItemListLayoutProps } from "../item-object-list/item-list-layout";
-import { KubeObjectStore } from "../../kube-object.store";
+import type { KubeObjectStore } from "../../kube-object.store";
 import { KubeObjectMenu } from "./kube-object-menu";
 import { kubeSelectedUrlParam, showDetails } from "./kube-object-details";
 import { kubeWatchApi } from "../../api/kube-watch-api";

src/renderer/components/kube-object/kube-object-menu.tsx

@@ -21,7 +21,7 @@
 
 import React from "react";
 import { autobind, cssNames } from "../../utils";
-import { KubeObject } from "../../api/kube-object";
+import type { KubeObject } from "../../api/kube-object";
 import { editResourceTab } from "../dock/edit-resource.store";
 import { MenuActions, MenuActionsProps } from "../menu/menu-actions";
 import { hideDetails } from "./kube-object-details";
@@ -38,7 +38,7 @@ export class KubeObjectMenu<T extends KubeObject> extends React.Component<KubeOb
   get store() {
     const { object } = this.props;
 
-    if (!object) return;
+    if (!object) return null;
 
     return apiManager.getStore(object.selfLink);
   }

src/renderer/components/kube-object/kube-object-meta.tsx

@@ -20,7 +20,7 @@
  */
 
 import React from "react";
-import { IKubeMetaField, KubeObject } from "../../api/kube-object";
+import type { IKubeMetaField, KubeObject } from "../../api/kube-object";
 import { DrawerItem, DrawerItemLabels } from "../drawer";
 import { lookupApiLink } from "../../api/kube-api";
 import { Link } from "react-router-dom";