Display zero minAvailable/maxUnavailable as 0 instead of N/A (#7620)

Signed-off-by: Panu Horsmalahti <phorsmalahti@mirantis.com>

packages/core/src/common/k8s-api/endpoints/pod-disruption-budget.api.ts

@@ -60,11 +60,11 @@ export class PodDisruptionBudget extends KubeObject<
   }
 
   getMinAvailable() {
-    return this.spec.minAvailable || "N/A";
+    return this.spec.minAvailable ?? "N/A";
   }
 
   getMaxUnavailable() {
-    return this.spec.maxUnavailable || "N/A";
+    return this.spec.maxUnavailable ?? "N/A";
   }
 
   getCurrentHealthy() {

packages/core/src/renderer/components/+config-pod-disruption-budgets/__tests__/pod-distruption-budgets.test.tsx

@@ -0,0 +1,117 @@
+/**
+ * Copyright (c) OpenLens Authors. All rights reserved.
+ * Licensed under MIT License. See LICENSE in root directory for more information.
+ */
+
+import React from "react";
+import { PodDisruptionBudget } from "../../../../common/k8s-api/endpoints";
+import { getDiForUnitTesting } from "../../../getDiForUnitTesting";
+import { renderFor } from "../../test-utils/renderFor";
+import { PodDisruptionBudgets } from "../pod-disruption-budgets";
+import storesAndApisCanBeCreatedInjectable from "../../../stores-apis-can-be-created.injectable";
+import selectedNamespacesStorageInjectable from "../../../../features/namespace-filtering/renderer/storage.injectable";
+import loggerInjectable from "../../../../common/logger.injectable";
+import maybeKubeApiInjectable from "../../../../common/k8s-api/maybe-kube-api.injectable";
+import podDisruptionBudgetStoreInjectable from "../store.injectable";
+import siblingTabsInjectable from "../../../routes/sibling-tabs.injectable";
+import { Cluster } from "../../../../common/cluster/cluster";
+import hostedClusterInjectable from "../../../cluster-frame-context/hosted-cluster.injectable";
+import userPreferencesStateInjectable from "../../../../features/user-preferences/common/state.injectable";
+import type { DiContainer } from "@ogre-tools/injectable";
+
+describe("<PodDisruptionBudgets />", () => {
+  let di: DiContainer;
+
+  const getPdb = (spec: PodDisruptionBudget["spec"]): PodDisruptionBudget => new PodDisruptionBudget({
+    apiVersion: "policy/v1",
+    kind: "PodDisruptionBudget",
+    metadata: {
+      name: "my-pdb",
+      resourceVersion: "1",
+      selfLink: "/apis/policy/v1/poddistruptionbudgets/my-pdb",
+      uid: "1",
+      namespace: "default",
+    },
+    spec,
+  });
+
+  const getPodDisruptionBudgetStoreInjectableMock = (pdb: PodDisruptionBudget) => ({
+    api: {
+      kind: "PodDisruptionBudget",
+    },
+    getByPath: () => pdb,
+    getTotalCount: () => 1,
+    contextItems: [pdb],
+    pickOnlySelected: (items: any[]) => items,
+    isSelectedAll: () => false,
+    isSelected: () => true,
+  }) as any;
+
+  beforeEach(() => {
+    di = getDiForUnitTesting();
+
+    di.override(hostedClusterInjectable, () => new Cluster({
+      contextName: "some-context-name",
+      id: "some-cluster-id",
+      kubeConfigPath: "/some-path-to-a-kubeconfig",
+    }));
+    di.override(storesAndApisCanBeCreatedInjectable, () => true);
+    di.override(selectedNamespacesStorageInjectable, () => ({
+      get: () => ({}),
+    }) as any);
+    di.override(loggerInjectable, () => null);
+    di.override(maybeKubeApiInjectable, () => (() => null) as any);
+    di.override(siblingTabsInjectable, () => ({ get: () => [] } as any));
+    di.override(userPreferencesStateInjectable, () => ({
+      hiddenTableColumns: {
+        get: () => ({
+          has: () => false,
+        }),
+      } as any,
+    }));
+  });
+
+  describe("PDB with minAvailable 0", () => {
+    const pdb = getPdb(
+      {
+        minAvailable: 0,
+      },
+    );
+
+    it("should display minAvailable as 0", () => {
+      di.override(podDisruptionBudgetStoreInjectable, () => getPodDisruptionBudgetStoreInjectableMock(pdb));
+      const result = renderFor(di)(<PodDisruptionBudgets object={pdb}/>);
+
+      expect(result.container.querySelector(".TableRow .min-available")?.textContent).toEqual("0");
+    });
+
+    it("should display maxUnavailable as N/A", () => {
+      di.override(podDisruptionBudgetStoreInjectable, () => getPodDisruptionBudgetStoreInjectableMock(pdb));
+      const result = renderFor(di)(<PodDisruptionBudgets object={pdb}/>);
+
+      expect(result.container.querySelector(".TableRow .max-unavailable")?.textContent).toEqual("N/A");
+    });
+  });
+
+  describe("PDB with maxUnavailable 0", () => {
+    const pdb = getPdb(
+      {
+        maxUnavailable: 0,
+      },
+    );
+
+    it("should display minAvailable as N/A", () => {
+      di.override(podDisruptionBudgetStoreInjectable, () => getPodDisruptionBudgetStoreInjectableMock(pdb));
+      const result = renderFor(di)(<PodDisruptionBudgets object={pdb}/>);
+
+      expect(result.container.querySelector(".TableRow .min-available")?.textContent).toEqual("N/A");
+    });
+  
+    it("should display maxUnavailable as 0", () => {
+      di.override(podDisruptionBudgetStoreInjectable, () => getPodDisruptionBudgetStoreInjectableMock(pdb));
+      const result = renderFor(di)(<PodDisruptionBudgets object={pdb}/>);
+
+      expect(result.container.querySelector(".TableRow .max-unavailable")?.textContent).toEqual("0");
+    });
+  });
+});