From 5ffa1de7e6634ea111160c1e88c4e5a94392e26c Mon Sep 17 00:00:00 2001 From: Jim Ehrismann <40840436+jim-docker@users.noreply.github.com> Date: Tue, 19 Oct 2021 11:06:02 -0400 Subject: [PATCH] added checkbox for optionally opening browser in the port-forward dialog (#4068) Signed-off-by: Jim Ehrismann --- src/renderer/port-forward/port-forward-dialog.tsx | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/src/renderer/port-forward/port-forward-dialog.tsx b/src/renderer/port-forward/port-forward-dialog.tsx index 6ba05ec1c4..100fdf5b94 100644 --- a/src/renderer/port-forward/port-forward-dialog.tsx +++ b/src/renderer/port-forward/port-forward-dialog.tsx @@ -32,6 +32,7 @@ import { cssNames } from "../utils"; import { addPortForward, modifyPortForward } from "./port-forward.store"; import type { ForwardedPort } from "./port-forward-item"; import { openPortForward } from "."; +import { Checkbox } from "../components/checkbox"; interface Props extends Partial { } @@ -57,7 +58,7 @@ export class PortForwardDialog extends Component { makeObservable(this); } - static open(portForward: ForwardedPort, options : PortForwardDialogOpenOptions = { openInBrowser: false }) { + static open(portForward: ForwardedPort, options: PortForwardDialogOpenOptions = { openInBrowser: false }) { dialogState.isOpen = true; dialogState.data = portForward; dialogState.openInBrowser = options.openInBrowser; @@ -105,7 +106,7 @@ export class PortForwardDialog extends Component { portForward.forwardPort = desiredPort; port = await addPortForward(portForward); } - + if (dialogState.openInBrowser) { portForward.forwardPort = port; openPortForward(portForward); @@ -120,7 +121,7 @@ export class PortForwardDialog extends Component { renderContents() { return ( <> -
+
Local port to forward from: @@ -134,6 +135,13 @@ export class PortForwardDialog extends Component { onChange={this.changePort} />
+ dialogState.openInBrowser = value} + />
);