Log as errors the places where getPortFrom can fail (#3425)

Signed-off-by: Sebastian Malton <sebastian@malton.name>
This commit is contained in:
Sebastian Malton authored and GitHub committed 2021-07-19 13:40:47 -04:00
1 parent 8683735630
commit 600d2c8607
2 files changed
+18 -5

No files matched your search

+14 -3
View File
@@ -134,11 +134,22 @@ export class PortForwardRoute {
name: resourceName,
port,
});
const started = await portForward.start();
if (!started) {
try {
const started = await portForward.start();
if (!started) {
logger.warn("[PORT-FORWARD-ROUTE]: failed to start a port-forward", { namespace, port, resourceType, resourceName });
return respondJson(response, {
message: "Failed to open port-forward"
}, 400);
}
} catch (error) {
logger.warn(`[PORT-FORWARD-ROUTE]: failed to open a port-forward: ${error}`, { namespace, port, resourceType, resourceName });
return respondJson(response, {
message: "Failed to open port-forward"
message: error?.toString() || "Failed to open port-forward",
}, 400);
}
}