hendrik/lens
1
0
Fork 0
mirror of https://github.com/lensapp/lens.git synced 2025-05-20 05:10:56 +00:00
Code Issues Projects Releases Wiki Activity

Rename injectable to getEditorHeightFromLinesCountInjectable

Browse Source 
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
This commit is contained in:
Alex Andreev 2022-12-26 12:43:32 +03:00
parent 66a287437a
commit 60920a456e
3 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/renderer/components/monaco-editor/get-editor-height-from-lines-number.injectable.ts
View File

@ -5,7 +5,7 @@
import { getInjectable } from "@ogre-tools/injectable"; import { getInjectable } from "@ogre-tools/injectable";
const getEditorHeightFromLinesNumberInjectable = getInjectable({ const getEditorHeightFromLinesCountInjectable = getInjectable({
id: "get-editor-height-from-lines-number", id: "get-editor-height-from-lines-number",
instantiate: () => { instantiate: () => {
@ -27,4 +27,4 @@ const getEditorHeightFromLinesNumberInjectable = getInjectable({
} }
}); });
export default getEditorHeightFromLinesNumberInjectable; export default getEditorHeightFromLinesCountInjectable;

4
src/renderer/components/monaco-editor/get-editor-height-from-lines-number.test.ts
View File

@ -4,7 +4,7 @@
*/ */
import { getDiForUnitTesting } from "../../getDiForUnitTesting"; import { getDiForUnitTesting } from "../../getDiForUnitTesting";
import getEditorHeightFromLinesNumberInjectable from "./get-editor-height-from-lines-number.injectable"; import getEditorHeightFromLinesCountInjectable from "./get-editor-height-from-lines-number.injectable";
describe("get-editor-height-from-lines-number", () => { describe("get-editor-height-from-lines-number", () => {
let getEditorHeightFromLinesNumber: (linesNumber: number) => string; let getEditorHeightFromLinesNumber: (linesNumber: number) => string;
@ -12,7 +12,7 @@ describe("get-editor-height-from-lines-number", () => {
beforeEach(() => { beforeEach(() => {
const di = getDiForUnitTesting({ doGeneralOverrides: false }); const di = getDiForUnitTesting({ doGeneralOverrides: false });
getEditorHeightFromLinesNumber = di.inject(getEditorHeightFromLinesNumberInjectable); getEditorHeightFromLinesNumber = di.inject(getEditorHeightFromLinesCountInjectable);
}); });
it("given linesNumber is less than 10, when called, returns small", () => { it("given linesNumber is less than 10, when called, returns small", () => {

8
src/renderer/components/monaco-editor/monaco-editor.tsx
View File

@ -18,7 +18,7 @@ import type { LensTheme } from "../../themes/lens-theme";
import { withInjectables } from "@ogre-tools/injectable-react"; import { withInjectables } from "@ogre-tools/injectable-react";
import userStoreInjectable from "../../../common/user-store/user-store.injectable"; import userStoreInjectable from "../../../common/user-store/user-store.injectable";
import activeThemeInjectable from "../../themes/active.injectable"; import activeThemeInjectable from "../../themes/active.injectable";
import getEditorHeightFromLinesNumberInjectable from "./get-editor-height-from-lines-number.injectable"; import getEditorHeightFromLinesCountInjectable from "./get-editor-height-from-lines-number.injectable";
export type MonacoEditorId = string; export type MonacoEditorId = string;
@ -44,7 +44,7 @@ export interface MonacoEditorProps {
interface Dependencies { interface Dependencies {
userStore: UserStore; userStore: UserStore;
activeTheme: IComputedValue<LensTheme>; activeTheme: IComputedValue<LensTheme>;
getEditorHeightFromLinesNumber: (linesNumber: number) => "small" | "medium" | "large"; getEditorHeightFromLinesCount: (linesNumber: number) => "small" | "medium" | "large";
} }
export function createMonacoUri(id: MonacoEditorId): Uri { export function createMonacoUri(id: MonacoEditorId): Uri {
@ -293,7 +293,7 @@ class NonInjectedMonacoEditor extends React.Component<MonacoEditorProps & Depend
get initialHeightClassName() { get initialHeightClassName() {
return this.props.setInitialHeight ? return this.props.setInitialHeight ?
styles[this.props.getEditorHeightFromLinesNumber(this.model.getLineCount())] : styles[this.props.getEditorHeightFromLinesCount(this.model.getLineCount())] :
null; null;
} }
@ -318,7 +318,7 @@ export const MonacoEditor = withInjectables<Dependencies, MonacoEditorProps, Mon
...props, ...props,
userStore: di.inject(userStoreInjectable), userStore: di.inject(userStoreInjectable),
activeTheme: di.inject(activeThemeInjectable), activeTheme: di.inject(activeThemeInjectable),
getEditorHeightFromLinesNumber: di.inject(getEditorHeightFromLinesNumberInjectable), getEditorHeightFromLinesCount: di.inject(getEditorHeightFromLinesCountInjectable),
}), }),
}, },
); );