Revert 2844 (#2980)

* Revert "review comments"

This reverts commit 97f2ecd88d.

* Revert "Switch to I, remove type parameter default"

This reverts commit a3073cc99b.

* Revert "Improve Table typing and remove annotations on callbacks"

This reverts commit defb0ea0dd.
This commit is contained in:
Sebastian Malton authored and GitHub committed 2021-06-07 12:02:15 -04:00
1 parent 97f2ecd88d
commit 60a19143b4
55 files changed
+471 -479

No files matched your search

@@ -83,14 +83,14 @@ export class HelmCharts extends Component<Props> {
store={helmChartStore}
isSelectable={false}
sortingCallbacks={{
[columnId.name]: chart => chart.getName(),
[columnId.repo]: chart => chart.getRepository(),
[columnId.name]: (chart: HelmChart) => chart.getName(),
[columnId.repo]: (chart: HelmChart) => chart.getRepository(),
}}
searchFilters={[
chart => chart.getName(),
chart => chart.getVersion(),
chart => chart.getAppVersion(),
chart => chart.getKeywords(),
(chart: HelmChart) => chart.getName(),
(chart: HelmChart) => chart.getVersion(),
(chart: HelmChart) => chart.getAppVersion(),
(chart: HelmChart) => chart.getKeywords(),
]}
customizeHeader={() => (
<SearchInputUrl placeholder="Search Helm Charts" />
@@ -103,7 +103,7 @@ export class HelmCharts extends Component<Props> {
{ title: "App Version", className: "app-version", id: columnId.appVersion },
{ title: "Repository", className: "repository", sortBy: columnId.repo, id: columnId.repo },
]}
renderTableContents={chart => [
renderTableContents={(chart: HelmChart) => [
<figure key="image">
<img
src={chart.getIcon() || require("./helm-placeholder.svg")}