Revert 2844 (#2980)

* Revert "review comments"

This reverts commit 97f2ecd88d.

* Revert "Switch to I, remove type parameter default"

This reverts commit a3073cc99b.

* Revert "Improve Table typing and remove annotations on callbacks"

This reverts commit defb0ea0dd.
This commit is contained in:
Sebastian Malton authored and GitHub committed 2021-06-07 12:02:15 -04:00
1 parent 97f2ecd88d
commit 60a19143b4
55 files changed
+471 -479

No files matched your search

+14 -14
View File
@@ -171,21 +171,21 @@ export class Nodes extends React.Component<Props> {
dependentStores={[podsStore]}
isSelectable={false}
sortingCallbacks={{
[columnId.name]: node => node.getName(),
[columnId.cpu]: node => nodesStore.getLastMetricValues(node, ["cpuUsage"]),
[columnId.memory]: node => nodesStore.getLastMetricValues(node, ["memoryUsage"]),
[columnId.disk]: node => nodesStore.getLastMetricValues(node, ["fsUsage"]),
[columnId.conditions]: node => node.getNodeConditionText(),
[columnId.taints]: node => node.getTaints().length,
[columnId.roles]: node => node.getRoleLabels(),
[columnId.age]: node => node.getTimeDiffFromNow(),
[columnId.version]: node => node.getKubeletVersion(),
[columnId.name]: (node: Node) => node.getName(),
[columnId.cpu]: (node: Node) => nodesStore.getLastMetricValues(node, ["cpuUsage"]),
[columnId.memory]: (node: Node) => nodesStore.getLastMetricValues(node, ["memoryUsage"]),
[columnId.disk]: (node: Node) => nodesStore.getLastMetricValues(node, ["fsUsage"]),
[columnId.conditions]: (node: Node) => node.getNodeConditionText(),
[columnId.taints]: (node: Node) => node.getTaints().length,
[columnId.roles]: (node: Node) => node.getRoleLabels(),
[columnId.age]: (node: Node) => node.getTimeDiffFromNow(),
[columnId.version]: (node: Node) => node.getKubeletVersion(),
}}
searchFilters={[
node => node.getSearchFields(),
node => node.getRoleLabels(),
node => node.getKubeletVersion(),
node => node.getNodeConditionText(),
(node: Node) => node.getSearchFields(),
(node: Node) => node.getRoleLabels(),
(node: Node) => node.getKubeletVersion(),
(node: Node) => node.getNodeConditionText(),
]}
renderHeaderTitle="Nodes"
renderTableHeader={[
@@ -200,7 +200,7 @@ export class Nodes extends React.Component<Props> {
{ title: "Age", className: "age", sortBy: columnId.age, id: columnId.age },
{ title: "Conditions", className: "conditions", sortBy: columnId.conditions, id: columnId.conditions },
]}
renderTableContents={node => {
renderTableContents={(node: Node) => {
const tooltipId = `node-taints-${node.getId()}`;
return [