Revert 2844 (#2980)

* Revert "review comments"

This reverts commit 97f2ecd88d.

* Revert "Switch to I, remove type parameter default"

This reverts commit a3073cc99b.

* Revert "Improve Table typing and remove annotations on callbacks"

This reverts commit defb0ea0dd.
This commit is contained in:
Sebastian Malton authored and GitHub committed 2021-06-07 12:02:15 -04:00
1 parent 97f2ecd88d
commit 60a19143b4
55 files changed
+471 -479

No files matched your search

@@ -25,6 +25,7 @@ import React from "react";
import { observer } from "mobx-react";
import { KubeObjectListLayout } from "../kube-object";
import { podSecurityPoliciesStore } from "./pod-security-policies.store";
import type { PodSecurityPolicy } from "../../api/endpoints";
import { KubeObjectStatusIcon } from "../kube-object-status-icon";
enum columnId {
@@ -44,15 +45,15 @@ export class PodSecurityPolicies extends React.Component {
className="PodSecurityPolicies"
store={podSecurityPoliciesStore}
sortingCallbacks={{
[columnId.name]: item => item.getName(),
[columnId.volumes]: item => item.getVolumes(),
[columnId.privileged]: item => +item.isPrivileged(),
[columnId.age]: item => item.getTimeDiffFromNow(),
[columnId.name]: (item: PodSecurityPolicy) => item.getName(),
[columnId.volumes]: (item: PodSecurityPolicy) => item.getVolumes(),
[columnId.privileged]: (item: PodSecurityPolicy) => +item.isPrivileged(),
[columnId.age]: (item: PodSecurityPolicy) => item.getTimeDiffFromNow(),
}}
searchFilters={[
item => item.getSearchFields(),
item => item.getVolumes(),
item => Object.values(item.getRules()),
(item: PodSecurityPolicy) => item.getSearchFields(),
(item: PodSecurityPolicy) => item.getVolumes(),
(item: PodSecurityPolicy) => Object.values(item.getRules()),
]}
renderHeaderTitle="Pod Security Policies"
renderTableHeader={[
@@ -62,7 +63,7 @@ export class PodSecurityPolicies extends React.Component {
{ title: "Volumes", className: "volumes", sortBy: columnId.volumes, id: columnId.volumes },
{ title: "Age", className: "age", sortBy: columnId.age, id: columnId.age },
]}
renderTableContents={item => {
renderTableContents={(item: PodSecurityPolicy) => {
return [
item.getName(),
<KubeObjectStatusIcon key="icon" object={item} />,