Revert 2844 (#2980)

* Revert "review comments"

This reverts commit 97f2ecd88d.

* Revert "Switch to I, remove type parameter default"

This reverts commit a3073cc99b.

* Revert "Improve Table typing and remove annotations on callbacks"

This reverts commit defb0ea0dd.
This commit is contained in:
Sebastian Malton authored and GitHub committed 2021-06-07 12:02:15 -04:00
1 parent 97f2ecd88d
commit 60a19143b4
55 files changed
+471 -479

No files matched your search

@@ -24,6 +24,7 @@ import "./storage-classes.scss";
import React from "react";
import type { RouteComponentProps } from "react-router-dom";
import { observer } from "mobx-react";
import type { StorageClass } from "../../api/endpoints/storage-class.api";
import { KubeObjectListLayout } from "../kube-object";
import type { IStorageClassesRouteParams } from "./storage-classes.route";
import { storageClassStore } from "./storage-class.store";
@@ -50,14 +51,14 @@ export class StorageClasses extends React.Component<Props> {
className="StorageClasses"
store={storageClassStore}
sortingCallbacks={{
[columnId.name]: item => item.getName(),
[columnId.age]: item => item.getTimeDiffFromNow(),
[columnId.provisioner]: item => item.provisioner,
[columnId.reclaimPolicy]: item => item.reclaimPolicy,
[columnId.name]: (item: StorageClass) => item.getName(),
[columnId.age]: (item: StorageClass) => item.getTimeDiffFromNow(),
[columnId.provisioner]: (item: StorageClass) => item.provisioner,
[columnId.reclaimPolicy]: (item: StorageClass) => item.reclaimPolicy,
}}
searchFilters={[
item => item.getSearchFields(),
item => item.provisioner,
(item: StorageClass) => item.getSearchFields(),
(item: StorageClass) => item.provisioner,
]}
renderHeaderTitle="Storage Classes"
renderTableHeader={[
@@ -68,7 +69,7 @@ export class StorageClasses extends React.Component<Props> {
{ title: "Default", className: "is-default", id: columnId.default },
{ title: "Age", className: "age", sortBy: columnId.age, id: columnId.age },
]}
renderTableContents={storageClass => [
renderTableContents={(storageClass: StorageClass) => [
storageClass.getName(),
<KubeObjectStatusIcon key="icon" object={storageClass} />,
storageClass.provisioner,