Revert 2844 (#2980)

* Revert "review comments"

This reverts commit 97f2ecd88d.

* Revert "Switch to I, remove type parameter default"

This reverts commit a3073cc99b.

* Revert "Improve Table typing and remove annotations on callbacks"

This reverts commit defb0ea0dd.
This commit is contained in:
Sebastian Malton authored and GitHub committed 2021-06-07 12:02:15 -04:00
1 parent 97f2ecd88d
commit 60a19143b4
55 files changed
+471 -479

No files matched your search

@@ -24,6 +24,7 @@ import "./volumes.scss";
import React from "react";
import { observer } from "mobx-react";
import { Link, RouteComponentProps } from "react-router-dom";
import type { PersistentVolume } from "../../api/endpoints/persistent-volume.api";
import { getDetailsUrl, KubeObjectListLayout } from "../kube-object";
import type { IVolumesRouteParams } from "./volumes.route";
import { stopPropagation } from "../../utils";
@@ -53,15 +54,15 @@ export class PersistentVolumes extends React.Component<Props> {
className="PersistentVolumes"
store={volumesStore}
sortingCallbacks={{
[columnId.name]: item => item.getName(),
[columnId.storageClass]: item => item.getStorageClass(),
[columnId.capacity]: item => item.getCapacity(true),
[columnId.status]: item => item.getStatus(),
[columnId.age]: item => item.getTimeDiffFromNow(),
[columnId.name]: (item: PersistentVolume) => item.getName(),
[columnId.storageClass]: (item: PersistentVolume) => item.getStorageClass(),
[columnId.capacity]: (item: PersistentVolume) => item.getCapacity(true),
[columnId.status]: (item: PersistentVolume) => item.getStatus(),
[columnId.age]: (item: PersistentVolume) => item.getTimeDiffFromNow(),
}}
searchFilters={[
item => item.getSearchFields(),
item => item.getClaimRefName(),
(item: PersistentVolume) => item.getSearchFields(),
(item: PersistentVolume) => item.getClaimRefName(),
]}
renderHeaderTitle="Persistent Volumes"
renderTableHeader={[
@@ -73,7 +74,7 @@ export class PersistentVolumes extends React.Component<Props> {
{ title: "Age", className: "age", sortBy: columnId.age, id: columnId.age },
{ title: "Status", className: "status", sortBy: columnId.status, id: columnId.status },
]}
renderTableContents={volume => {
renderTableContents={(volume: PersistentVolume) => {
const { claimRef, storageClassName } = volume.spec;
const storageClassDetailsUrl = getDetailsUrl(storageClassApi.getUrl({
name: storageClassName