From 62bc806105e1c485826a3e9eee3e9cabd48a309b Mon Sep 17 00:00:00 2001 From: Sebastian Malton Date: Mon, 14 Jun 2021 09:39:06 -0400 Subject: [PATCH] Don't try watching again if credentials have failed (#3039) Signed-off-by: Sebastian Malton --- src/renderer/item.store.ts | 7 +------ src/renderer/kube-object.store.ts | 4 ++-- 2 files changed, 3 insertions(+), 8 deletions(-) diff --git a/src/renderer/item.store.ts b/src/renderer/item.store.ts index 83733dea41..0a72352649 100644 --- a/src/renderer/item.store.ts +++ b/src/renderer/item.store.ts @@ -20,7 +20,7 @@ */ import orderBy from "lodash/orderBy"; -import { autoBind, noop } from "./utils"; +import { autoBind } from "./utils"; import { action, computed, observable, when, makeObservable } from "mobx"; export interface ItemObject { @@ -213,11 +213,6 @@ export abstract class ItemStore { async removeSelectedItems?(): Promise; - // eslint-disable-next-line unused-imports/no-unused-vars-ts - subscribe(...args: any[]) { - return noop; - } - * [Symbol.iterator]() { yield* this.items; } diff --git a/src/renderer/kube-object.store.ts b/src/renderer/kube-object.store.ts index f869d131d4..0c9f8688a2 100644 --- a/src/renderer/kube-object.store.ts +++ b/src/renderer/kube-object.store.ts @@ -345,8 +345,8 @@ export abstract class KubeObjectStore extends ItemSt if (!this.isLoaded || error instanceof DOMException) return; if (error instanceof Response) { - if (error.status === 404) { - // api has gone, let's not retry + if (error.status === 404 || error.status === 401) { + // api has gone, or credentials are not permitted, let's not retry return; }