hendrik/lens
1
0 Fork 0
mirror of https://github.com/lensapp/lens.git synced 2025-05-20 05:10:56 +00:00
Code Issues Projects Releases Wiki Activity

Fix: incorrect subscribing event name to navigate in cluster view (#2363)

Browse Source 
Co-authored-by: Sebastian Malton <sebastian@malton.name>
This commit is contained in:
RomanandSebastian Malton authored and GitHub committed 2021-03-23 11:04:31 -04:00
1 parent e718b250cc
commit 62c3501011
6 files changed
+31 -16
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

src/renderer/components/cluster-manager/cluster-actions.tsx
+2 -1
View File
@@ -9,9 +9,10 @@ import { clusterDisconnectHandler } from "../../../common/cluster-ipc";
import { ConfirmDialog } from "../confirm-dialog";
import { Cluster } from "../../../main/cluster";
import { Tooltip } from "../../components//tooltip";
import { IpcRendererNavigationEvents } from "../../navigation/events";
const navigate = (route: string) =>
broadcastMessage("renderer:navigate", route);
broadcastMessage(IpcRendererNavigationEvents.NAVIGATE_IN_APP, route);
/**
* Creates handlers for high-level actions
src/renderer/components/layout/__test__/main-layout-header.test.tsx
+4 -3
View File
@@ -10,6 +10,7 @@ import { workspaceStore } from "../../../../common/workspace-store";
import { broadcastMessage, requestMain } from "../../../../common/ipc";
import { clusterDisconnectHandler } from "../../../../common/cluster-ipc";
import { ConfirmDialog } from "../../confirm-dialog";
import { IpcRendererNavigationEvents } from "../../../navigation/events";
const mockBroadcastIpc = broadcastMessage as jest.MockedFunction<typeof broadcastMessage>;
const mockRequestMain = requestMain as jest.MockedFunction<typeof requestMain>;
@@ -76,7 +77,7 @@ describe("<MainLayoutHeader />", () => {
it("navigates to cluster settings", () => {
fireEvent.click(settingsBtn);
expect(mockBroadcastIpc).toBeCalledWith("renderer:navigate", "/cluster/foo/settings");
expect(mockBroadcastIpc).toBeCalledWith(IpcRendererNavigationEvents.NAVIGATE_IN_APP, "/cluster/foo/settings");
});
it("disconnects from cluster", () => {
@@ -86,7 +87,7 @@ describe("<MainLayoutHeader />", () => {
it("opens 'Remove cluster' dialog", async () => {
fireEvent.click(removeBtn);
const dialog = document.querySelector(".ConfirmDialog");
expect(dialog).toBeDefined();
@@ -94,7 +95,7 @@ describe("<MainLayoutHeader />", () => {
const okBtn = dialog.querySelector("button.ok");
expect(okBtn.textContent).toBe("Remove");
expect(okBtn.textContent).toBe("Remove");
});
});
});