From 634245841959d56b540876dfd30ca45dd6afdcaa Mon Sep 17 00:00:00 2001 From: Janne Savolainen Date: Tue, 7 Jun 2022 08:43:46 +0300 Subject: [PATCH] Remove old implementation made redundant with competition for preferences of helm repositories Co-authored-by: Mikko Aspiala Signed-off-by: Janne Savolainen --- ...m-helm-repository-preferences.test.ts.snap | 1406 +---------------- ...tory-from-list-in-preferences.test.ts.snap | 1168 +------------- ...ive-repository-in-preferences.test.ts.snap | 504 +----- ...m-repositories-in-preferences.test.ts.snap | 878 +--------- src/renderer/bootstrap.tsx | 3 - .../+preferences/add-helm-repo-dialog.tsx | 220 --- .../components/+preferences/helm-charts.tsx | 202 --- .../components/+preferences/kubernetes.tsx | 5 +- ...-custom-helm-repository-dialog-content.tsx | 2 +- ...ation-of-custom-helm-repository-dialog.tsx | 2 +- .../add-helm-repo-dialog.scss | 0 .../activation-of-public-helm-repository.tsx | 28 +- .../helm-charts}/helm-charts.module.scss | 0 .../{helm-charts-2.tsx => helm-charts.tsx} | 0 .../helm-charts/helm-repositories.tsx | 2 +- 15 files changed, 228 insertions(+), 4192 deletions(-) delete mode 100644 src/renderer/components/+preferences/add-helm-repo-dialog.tsx delete mode 100644 src/renderer/components/+preferences/helm-charts.tsx rename src/renderer/components/+preferences/{ => kubernetes/helm-charts/activation-of-custom-helm-repository}/add-helm-repo-dialog.scss (100%) rename src/renderer/components/+preferences/{ => kubernetes/helm-charts}/helm-charts.module.scss (100%) rename src/renderer/components/+preferences/kubernetes/helm-charts/{helm-charts-2.tsx => helm-charts.tsx} (100%) diff --git a/src/behaviours/helm-charts/__snapshots__/activate-custom-helm-repository-preferences.test.ts.snap b/src/behaviours/helm-charts/__snapshots__/activate-custom-helm-repository-preferences.test.ts.snap index 402371797a..8f7aea7437 100644 --- a/src/behaviours/helm-charts/__snapshots__/activate-custom-helm-repository-preferences.test.ts.snap +++ b/src/behaviours/helm-charts/__snapshots__/activate-custom-helm-repository-preferences.test.ts.snap @@ -313,7 +313,7 @@ exports[`activate custom helm repository in preferences when navigating to prefe >
Repositories
@@ -339,7 +339,7 @@ exports[`activate custom helm repository in preferences when navigating to prefe > - - -
-
-
-
-
-
-
-
-
-
- - -
-
-
- Repositories -
-
- -
-
-
- - - -
-
-
-
-
-
-
-
-
-
-
-
-
-
-
- - -
-
-
- Repositories -
-
- -
-
-
- - -
-
-
-
-
-
-
-
-
-
-
-
-
-
-
- - -
-
-
- Repositories -
-
- -
-
-
- - -
-
-
-
-
-
-
-
-
-
-
-
-
-
-
- - -
-
-
- Repositories -
-
- -
-
-
- - -
-
-
-
-
-
-
-
-
-
-
-
-
-
-
- - -
-
-
- Repositories -
-
- -
-
-
- - -
-
-
-
-
-
-
-
-
-
-
-
-
-
-
- - -
-
-
- Repositories -
-
- -
-
-
- - -
-
-
-
-
-
-
-
-
-
-
-
-
-
-
- - -
-
-
- Repositories -
-
- -
-
-
- - -
-
-
-
-
-
-
-
-
-
-
-
-
-
-
- - -
-
-
- Repositories -
-
- -
-
-
- - -
-
-
-
-
-
-
-
-
-
-
-
-
-
-
- - -
-
-
- Repositories -
-
- -
-
-
- - -
-
-
-
- -
-
-
-
-
-
-
-
-
-
-
- - -
-
-
- Repositories -
-
- -
-
-
- - - -
-
-
-
- -
-
-
-
-
-
-
-
-
-
-
- - -
-
-
- Repositories -
-
- -
-
-
- - - -
-
-
-
- -
-
-
-
-
-
-
-
-
-
-
- - -
-
-
- Repositories -
-
- -
-
-
- - - -
-
-
-
-
-
-
-
-
-
-
-
-
-
-
- - -
-
-
- Repositories -
-
- -
-
-
- - -
-
-
-
-
-
-
-
-
-
-
-
-
-
-
- - -
-
-
- Repositories -
-
- -
-
-
- - -
-
-
-
-
-
-
-
-
-
-
-
-
-
-
- - -
-
-
- Repositories -
-
- -
-
-
- - -
-
-
-
- -
-
-
-
-
-
-
-
-
-
-
- - -
-
-
- Repositories -
-
- -
-
-
- - - -
-
-
-
-
-
-
-
-
-
-
-
-
-
-
- - -
-
-
- Repositories -
-
- -
-
-
- - -
-
-
-
-
-
-
-
-
-
-
-
-
-
-
- - -
-
-
- Repositories -
-
- -
-
-
- - -
-
-
-
-
-
-
-
-
-
-
-
-
-
-
- - -
-
-
- Repositories -
-
- -
-
-
- - -
-
-
-
- -
-
-
-
-
-
-
-
-
-
-
- - -
-
-
- Repositories -
-
- -
-
-
- - - -
-
-
-
- -
-
-
-
-
-
-
-
-
-
-
- - -
-
-
- Repositories -
-
- -
-
-
- - - -
-
-
-
-
-
-
-
-
-
-
-
-
-
-
- - -
-
-
- Repositories -
-
- -
-
-
- - -
-
-
-
-
-
-
-
-
-
-
-
-
-
-
- - -
-
-
- Repositories -
-
- -
-
-
- - -
-
-
-
- -
-
-
-
-
-
-
-
-
-
-
- - -
-
-
- Repositories -
-
- -
-
-
- - - -
-
-
-
- -
-
-
-
-
-
-
-
-
-
-
- - -
-
-
- Repositories -
-
- -
-
-
- - - -
-
-
-
- -
-
-
-
-
-
-
-
-
-
-
- - -
-
-
- Repositories -
-
- -
-
-
- - - -
-
-
-
-
-
-
-
-
-
-
-
-
-
-
- - -
-
-
- Repositories -
-
- -
-
-
- - -
-
-
-
- -
-
-
-
-
-
-
-
-
-
-
- - -
-
-
- Repositories -
-
- -
-
-
- - - -
-
-
-
- -
-
-
-
-
-
-
-
-
-
-
- - -
-
-
- Repositories -
-
- -
-
-
- - - -
-
-
-
-
-
-
-
-
-
-
-
-
-
-
- - -
-
-
- Repositories -
-
- -
-
-
- - -
-
-
-
-
-
-
-
-
-
-
-
-
-
-
- - -
-
-
- Repositories -
-
- -
-
-
- - -
-
-
-
- {this.showOptions && this.renderOptions()} -
- - - - ); - } -} diff --git a/src/renderer/components/+preferences/helm-charts.tsx b/src/renderer/components/+preferences/helm-charts.tsx deleted file mode 100644 index d4f67902a6..0000000000 --- a/src/renderer/components/+preferences/helm-charts.tsx +++ /dev/null @@ -1,202 +0,0 @@ -/** - * Copyright (c) OpenLens Authors. All rights reserved. - * Licensed under MIT License. See LICENSE in root directory for more information. - */ - -import styles from "./helm-charts.module.scss"; - -import React from "react"; -import { observable, makeObservable, computed } from "mobx"; - -import type { HelmRepo } from "../../../main/helm/helm-repo-manager"; -import { HelmRepoManager } from "../../../main/helm/helm-repo-manager"; -import { Button } from "../button"; -import { Icon } from "../icon"; -import { Notifications } from "../notifications"; -import type { SelectOption } from "../select"; -import { Select } from "../select"; -import { AddHelmRepoDialog } from "./add-helm-repo-dialog"; -import { observer } from "mobx-react"; -import { RemovableItem } from "./removable-item"; -import { Notice } from "../+extensions/notice"; -import { Spinner } from "../spinner"; -import { noop } from "../../utils"; -import type { SingleValue } from "react-select"; - -@observer -export class HelmCharts extends React.Component { - @observable loadingRepos = false; - @observable loadingAvailableRepos = false; - @observable repos: HelmRepo[] = []; - @observable addedRepos = observable.map(); - - constructor(props: {}) { - super(props); - makeObservable(this); - } - - @computed get repoOptions() { - return this.repos.map(repo => ({ - value: repo, - label: repo.name, - isSelected: this.addedRepos.has(repo.name), - })); - } - - componentDidMount() { - this.loadAvailableRepos().catch(noop); - this.loadRepos().catch(noop); - } - - async loadAvailableRepos() { - this.loadingAvailableRepos = true; - - try { - if (!this.repos.length) { - this.repos = await HelmRepoManager.getInstance().loadAvailableRepos(); - } - } catch (err) { - Notifications.error(String(err)); - } - - this.loadingAvailableRepos = false; - } - - async loadRepos() { - this.loadingRepos = true; - - try { - const repos = await HelmRepoManager.getInstance().repositories(); // via helm-cli - - this.addedRepos.replace(repos.map(repo => [repo.name, repo])); - } catch (err) { - Notifications.error(String(err)); - } - - this.loadingRepos = false; - } - - async addRepo(repo: HelmRepo) { - try { - await HelmRepoManager.getInstance().addRepo(repo); - this.addedRepos.set(repo.name, repo); - } catch (err) { - Notifications.error(( - <> - {"Adding helm branch "} - {repo.name} - {" has failed: "} - {String(err)} - - )); - } - } - - async removeRepo(repo: HelmRepo) { - try { - await HelmRepoManager.getInstance().removeRepo(repo); - this.addedRepos.delete(repo.name); - } catch (err) { - Notifications.error( - <> - {"Removing helm branch "} - {repo.name} - {" has failed: "} - {String(err)} - , - ); - } - } - - onRepoSelect = async (option: SingleValue<{ value: HelmRepo }>): Promise => { - if (!option) { - return; - } - - if (this.addedRepos.has(option.value.name)) { - return void Notifications.ok(( - <> - {"Helm repo "} - {option.value.name} - {" already in use."} - - )); - } - - await this.addRepo(option.value); - }; - - formatOptionLabel = ({ value, isSelected }: SelectOption) => ( -
- {value.name} - {isSelected && ( - - )} -
- ); - - renderRepositories() { - const repos = Array.from(this.addedRepos); - - if (this.loadingRepos) { - return
; - } - - if (!repos.length) { - return ( - -
The repositories have not been added yet
-
- ); - } - - return repos.map(([name, repo]) => { - return ( - this.removeRepo(repo)} - className="mt-3" - > -
-
{name}
-
{repo.url}
-
-
- ); - }); - } - - render() { - return ( -
-
- -
+