hendrik/lens
1
0 Fork 0
mirror of https://github.com/lensapp/lens.git synced 2025-05-20 05:10:56 +00:00
Code Issues Projects Releases Wiki Activity

Improve Table typing and remove annotations on callbacks (#2981)

Browse Source 
Signed-off-by: Sebastian Malton <sebastian@malton.name>
This commit is contained in:
Sebastian Malton authored and GitHub committed 2021-07-22 10:42:27 -04:00
1 parent c6a4d55d86
commit 64ac04186b
59 files changed
+487 -482
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

src/renderer/components/+workloads-deployments/deployments.tsx
+9 -11
View File
@@ -81,15 +81,15 @@ export class Deployments extends React.Component<Props> {
className="Deployments" store={deploymentStore}
dependentStores={[replicaSetStore, podsStore, nodesStore, eventStore]}
sortingCallbacks={{
[columnId.name]: (deployment: Deployment) => deployment.getName(),
[columnId.namespace]: (deployment: Deployment) => deployment.getNs(),
[columnId.replicas]: (deployment: Deployment) => deployment.getReplicas(),
[columnId.age]: (deployment: Deployment) => deployment.getTimeDiffFromNow(),
[columnId.condition]: (deployment: Deployment) => deployment.getConditionsText(),
[columnId.name]: deployment => deployment.getName(),
[columnId.namespace]: deployment => deployment.getNs(),
[columnId.replicas]: deployment => deployment.getReplicas(),
[columnId.age]: deployment => deployment.getTimeDiffFromNow(),
[columnId.condition]: deployment => deployment.getConditionsText(),
}}
searchFilters={[
(deployment: Deployment) => deployment.getSearchFields(),
(deployment: Deployment) => deployment.getConditionsText(),
deployment => deployment.getSearchFields(),
deployment => deployment.getConditionsText(),
]}
renderHeaderTitle="Deployments"
renderTableHeader={[
@@ -101,7 +101,7 @@ export class Deployments extends React.Component<Props> {
{ title: "Age", className: "age", sortBy: columnId.age, id: columnId.age },
{ title: "Conditions", className: "conditions", sortBy: columnId.condition, id: columnId.condition },
]}
renderTableContents={(deployment: Deployment) => [
renderTableContents={deployment => [
deployment.getName(),
<KubeObjectStatusIcon key="icon" object={deployment}/>,
deployment.getNs(),
@@ -110,9 +110,7 @@ export class Deployments extends React.Component<Props> {
deployment.getAge(),
this.renderConditions(deployment),
]}
renderItemMenu={(item: Deployment) => {
return <DeploymentMenu object={item}/>;
}}
renderItemMenu={item => <DeploymentMenu object={item} />}
/>
);
}