hendrik/lens
1
0
Fork 0
mirror of https://github.com/lensapp/lens.git synced 2025-05-20 05:10:56 +00:00
Code Issues Projects Releases Wiki Activity

Fix sass warnings (#3783)

Browse Source 
* Fix sass warnings

Signed-off-by: Hung-Han (Henry) Chen <chenhungh@gmail.com>

* Add a space

Signed-off-by: Hung-Han (Henry) Chen <chenhungh@gmail.com>

* Update src/renderer/components/input/input.scss

Co-authored-by: Jim Ehrismann <40840436+jim-docker@users.noreply.github.com>
Signed-off-by: Hung-Han (Henry) Chen <chenhungh@gmail.com>

* Response to comments

Signed-off-by: Hung-Han (Henry) Chen <chenhungh@gmail.com>

Co-authored-by: Jim Ehrismann <40840436+jim-docker@users.noreply.github.com>
This commit is contained in:
chh 2021-09-14 10:09:09 +03:00 committed by GitHub
parent 4fa0b8e329
commit 64fb590377
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
32 changed files with 51 additions and 54 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/renderer/components/+apps-helm-charts/helm-charts.scss
View File

@ -57,7 +57,7 @@
visibility: hidden; visibility: hidden;
border-radius: inherit; border-radius: inherit;
background-color: $helmImgBackground; background-color: $helmImgBackground;
padding: $padding / 2; padding: $padding * 0.5;
&.visible { &.visible {
visibility: visible; visibility: visible;

1
src/renderer/components/+cluster/cluster-issues.scss
View File

@ -44,7 +44,6 @@
.TableCell { .TableCell {
padding-top: 0; padding-top: 0;
padding-bottom: floor($padding / 1.33);
} }
} }

2
src/renderer/components/+config-maps/config-map-details.scss
View File

@ -26,7 +26,7 @@
.name { .name {
color: $textColorSecondary; color: $textColorSecondary;
font-weight: $font-weight-bold; font-weight: $font-weight-bold;
padding-bottom: $padding / 2; padding-bottom: $padding * 0.5;
} }
} }

6
src/renderer/components/+config-resource-quotas/add-quota-dialog.scss
View File

@ -25,7 +25,7 @@
} }
.quota-entries { .quota-entries {
margin: -$margin / 2; margin: -$margin * 0.5;
&:empty { &:empty {
display: none; display: none;
@ -35,8 +35,8 @@
--flex-gap: #{$padding}; --flex-gap: #{$padding};
border: 1px solid $halfGray; border: 1px solid $halfGray;
border-radius: $radius; border-radius: $radius;
margin: $margin / 2; margin: $margin * 0.5;
padding: $padding / 2 $padding; padding: $padding * 0.5 $padding;
transition: all 150ms ease; transition: all 150ms ease;
&:hover { &:hover {

2
src/renderer/components/+config-secrets/add-secret-dialog.scss
View File

@ -35,6 +35,6 @@
display: grid; display: grid;
grid-template-columns: min-content auto; grid-template-columns: min-content auto;
align-items: center; align-items: center;
gap: $margin / 2; gap: $margin * 0.5;
} }
} }

2
src/renderer/components/+config-secrets/secret-details.scss
View File

@ -26,7 +26,7 @@
.name { .name {
color: $textColorSecondary; color: $textColorSecondary;
font-weight: $font-weight-bold; font-weight: $font-weight-bold;
padding-bottom: $padding / 2; padding-bottom: $padding * 0.5;
} }
} }

2
src/renderer/components/+events/events.scss
View File

@ -43,7 +43,7 @@
} }
.help-icon { .help-icon {
margin-left: $margin / 2; margin-left: $margin * 0.5;
} }
.show-all { .show-all {

2
src/renderer/components/+namespaces/namespace-select-filter.scss
View File

@ -61,6 +61,6 @@
} }
.Icon { .Icon {
margin-right: $margin / 2; margin-right: $margin * 0.5;
} }
} }

2
src/renderer/components/+namespaces/namespace-select.scss
View File

@ -21,7 +21,7 @@
@mixin namespaceSelectCommon { @mixin namespaceSelectCommon {
.Icon { .Icon {
margin-right: $margin / 2; margin-right: $margin * 0.5;
} }
} }

2
src/renderer/components/+preferences/add-helm-repo-dialog.scss
View File

@ -38,6 +38,6 @@
display: grid; display: grid;
grid-template-columns: min-content auto; grid-template-columns: min-content auto;
align-items: center; align-items: center;
gap: $margin / 2; gap: $margin * 0.5;
} }
} }

2
src/renderer/components/+user-management/+cluster-role-bindings/dialog.scss
View File

@ -1,6 +1,6 @@
.AddClusterRoleBindingDialog { .AddClusterRoleBindingDialog {
.Select + .Select { .Select + .Select {
margin-top: $margin /2; margin-top: $margin *0.5;
} }
.Checkbox { .Checkbox {
margin-top: $margin; margin-top: $margin;

2
src/renderer/components/+user-management/+cluster-role-bindings/view.scss
View File

@ -1,6 +1,6 @@
.ClusterRoleBindings { .ClusterRoleBindings {
.help-icon { .help-icon {
margin-left: $margin / 2; margin-left: $margin * 0.5;
} }
.TableCell { .TableCell {

2
src/renderer/components/+user-management/+cluster-roles/view.scss
View File

@ -1,6 +1,6 @@
.ClusterRoles { .ClusterRoles {
.help-icon { .help-icon {
margin-left: $margin / 2; margin-left: $margin * 0.5;
} }
.TableCell { .TableCell {

2
src/renderer/components/+user-management/+role-bindings/dialog.scss
View File

@ -21,7 +21,7 @@
.AddRoleBindingDialog { .AddRoleBindingDialog {
.Select + .Select { .Select + .Select {
margin-top: $margin /2; margin-top: $margin *0.5;
} }
.Checkbox { .Checkbox {
margin-top: $margin; margin-top: $margin;

2
src/renderer/components/+user-management/+role-bindings/view.scss
View File

@ -21,7 +21,7 @@
.RoleBindings { .RoleBindings {
.help-icon { .help-icon {
margin-left: $margin / 2; margin-left: $margin * 0.5;
} }
.TableCell { .TableCell {

2
src/renderer/components/+user-management/+roles/view.scss
View File

@ -21,7 +21,7 @@
.Roles { .Roles {
.help-icon { .help-icon {
margin-left: $margin / 2; margin-left: $margin * 0.5;
} }
.TableCell { .TableCell {

2
src/renderer/components/+user-management/+service-accounts/secret.scss
View File

@ -55,7 +55,7 @@
.asterisks { .asterisks {
font-size: large; font-size: large;
margin-right: $margin / 2; margin-right: $margin * 0.5;
line-height: 90%; line-height: 90%;
} }
} }

2
src/renderer/components/app.scss
View File

@ -154,7 +154,7 @@ h4 {
h5 { h5 {
@extend h4; @extend h4;
padding: $padding / 2 0; padding: $padding * 0.5 0;
font-size: 16px; font-size: 16px;
} }

4
src/renderer/components/cluster-manager/bottom-bar.scss
View File

@ -20,7 +20,7 @@
*/ */
.BottomBar { .BottomBar {
$spacing: $padding / 2; $spacing: $padding * 0.5;
--flex-gap: #{$spacing}; --flex-gap: #{$spacing};
background-color: var(--blue); background-color: var(--blue);
@ -31,7 +31,7 @@
font-size: var(--font-size-small); font-size: var(--font-size-small);
color: white; color: white;
.item { .item {
padding: $padding / 4 $padding / 2; padding: $padding * 0.25 $padding * 0.5;
&:hover { &:hover {
background-color: #ffffff33; background-color: #ffffff33;
cursor: pointer; cursor: pointer;

2
src/renderer/components/drawer/drawer-item.scss
View File

@ -58,7 +58,7 @@
} }
&.labelsOnly { &.labelsOnly {
$spacing: $margin / 2; $spacing: $margin * 0.5;
> .value { > .value {
margin: -$spacing; margin: -$spacing;

2
src/renderer/components/icon/icon.scss
View File

@ -123,7 +123,7 @@
color: $textColorAccent; color: $textColorAccent;
border-radius: 50%; border-radius: 50%;
box-sizing: content-box; box-sizing: content-box;
padding: $padding / 2; padding: $padding * 0.5;
} }
&.active { &.active {

9
src/renderer/components/input/input.scss
View File

@ -45,10 +45,9 @@
} }
label { label {
--flex-gap: #{$padding / 1.5}; --flex-gap: $padding * 0.6667;
position: relative; position: relative;
padding: $padding / 4 * 3 0; padding: $padding * 0.75 0;
border-bottom: 1px solid $halfGray; border-bottom: 1px solid $halfGray;
line-height: 1; line-height: 1;
@ -102,7 +101,7 @@
.maxLengthIndicator { .maxLengthIndicator {
text-align: right; text-align: right;
font-size: 80%; font-size: 80%;
padding: $padding / 3; padding: $padding * 0.33333;
} }
} }
@ -119,7 +118,7 @@
border-radius: $radius; border-radius: $radius;
border: 1px solid $halfGray; border: 1px solid $halfGray;
color: inherit; color: inherit;
padding: $padding / 4 * 3 $padding / 4 * 3; padding: $padding * 0.25 * 3 $padding * 0.25 * 3;
&:focus-within { &:focus-within {
border-color: $colorInfo; border-color: $colorInfo;

8
src/renderer/components/item-object-list/page-filters-list.scss
View File

@ -41,12 +41,12 @@
> .header { > .header {
--flex-gap: #{$padding}; --flex-gap: #{$padding};
margin-bottom: $padding / 2; margin-bottom: $padding * 0.5;
text-transform: uppercase; text-transform: uppercase;
} }
> .labels { > .labels {
$gap: $padding / 3; $gap: $padding * 0.33333;
margin-left: -$gap; margin-left: -$gap;
margin-right: -$gap; margin-right: -$gap;
@ -54,9 +54,9 @@
--flex-gap: .25em; --flex-gap: .25em;
display: inline-flex; display: inline-flex;
margin: $gap; margin: $gap;
padding: $padding /3; padding: $padding * 0.33333;
vertical-align: middle; vertical-align: middle;
overflow: visible; overflow: visible;
} }
} }
} }

2
src/renderer/components/kube-object-status-icon/kube-object-status-icon.scss
View File

@ -43,7 +43,7 @@
} }
.msg { .msg {
margin: $margin / 2 margin: $margin * 0.5
} }
.age { .age {

5
src/renderer/components/layout/sidebar-item.scss
View File

@ -20,7 +20,6 @@
*/ */
.SidebarItem { .SidebarItem {
$itemSpacing: floor($unit / 2.6) floor($unit / 1.6);
display: flex; display: flex;
flex-direction: column; flex-direction: column;
@ -30,7 +29,7 @@
> .nav-item { > .nav-item {
text-decoration: none; text-decoration: none;
padding: $itemSpacing; padding: $unit * 0.3846 $unit * 0.625; // ≈ floor($unit / 2.6) floor($unit / 1.6)
width: 100%; width: 100%;
height: 100%; height: 100%;
color: inherit; color: inherit;
@ -81,4 +80,4 @@
} }
} }
} }
} }

2
src/renderer/components/layout/sidebar.module.css
View File

@ -53,4 +53,4 @@
/* Simulate text-overflow:ellipsis styles but for multiple text lines */ /* Simulate text-overflow:ellipsis styles but for multiple text lines */
-webkit-line-clamp: 3; -webkit-line-clamp: 3;
-webkit-box-orient: vertical; -webkit-box-orient: vertical;
} }

2
src/renderer/components/menu/menu-actions.scss
View File

@ -21,7 +21,7 @@
.MenuActions { .MenuActions {
&.toolbar { &.toolbar {
--flex-gap: #{$padding / 2}; --flex-gap: #{$padding * 0.5};
position: static; position: static;
padding: 0; padding: 0;

12
src/renderer/components/resizing-anchor/resizing-anchor.scss
View File

@ -67,15 +67,15 @@ body.resizing {
.resizing & { .resizing & {
$expandedHeight: 200px; $expandedHeight: 200px;
height: $expandedHeight; height: $expandedHeight;
margin-top: -$expandedHeight / 2; margin-top: -$expandedHeight * 0.5;
&::after { &::after {
margin-top: $expandedHeight / 2; margin-top: $expandedHeight * 0.5;
} }
} }
&.trailing { &.trailing {
bottom: -$dimension / 2; bottom: -$dimension * 0.5;
} }
} }
@ -92,16 +92,16 @@ body.resizing {
width: $expandedWidth; width: $expandedWidth;
&.trailing { &.trailing {
right: -$expandedWidth / 2; right: -$expandedWidth * 0.5;
} }
} }
&.leading { &.leading {
left: -$dimension / 2; left: -$dimension * 0.5;
} }
&.trailing { &.trailing {
right: -$dimension / 2; right: -$dimension * 0.5;
} }
} }
} }

8
src/renderer/components/select/select.scss
View File

@ -68,7 +68,7 @@ html {
} }
&__indicator { &__indicator {
padding: $padding /2; padding: $padding *0.5;
opacity: .55; opacity: .55;
&:hover { &:hover {
@ -84,7 +84,7 @@ html {
&__dropdown { &__dropdown {
&-indicator { &-indicator {
color: inherit !important; color: inherit !important;
padding: $padding / 2; padding: $padding * 0.5;
} }
} }
@ -101,7 +101,7 @@ html {
} }
&-notice { &-notice {
padding: $padding / 3; padding: $padding * 0.3333;
} }
} }
@ -200,7 +200,7 @@ html {
color: $primary; color: $primary;
.Select__value-container { .Select__value-container {
padding: 0 $padding / 2; padding: 0 $padding * 0.5;
} }
.Select__dropdown-indicator { .Select__dropdown-indicator {

2
src/renderer/components/stepper/stepper.scss
View File

@ -68,7 +68,7 @@
position: absolute; position: absolute;
width: 100%; width: 100%;
height: 1px; height: 1px;
top: $pointSize / 2; top: $pointSize * 0.5;
background: var(--stepper-color-point); background: var(--stepper-color-point);
} }
} }

6
src/renderer/components/table/table.mixins.scss
View File

@ -25,7 +25,7 @@
flex: 0 0 55px !important; flex: 0 0 55px !important;
> * { > * {
margin: floor($margin / 1.3) auto; margin: 6px auto;
} }
} }
@ -47,6 +47,6 @@
} }
@mixin table-cell-labels-offsets { @mixin table-cell-labels-offsets {
padding-top: $padding / 2; padding-top: $padding * 0.5;
padding-bottom: 0; padding-bottom: 0;
} }

2
src/renderer/components/tabs/tabs.scss
View File

@ -71,7 +71,7 @@
right: 0; right: 0;
bottom: 0; bottom: 0;
width: 0; width: 0;
height: $unit /2; height: $unit * 0.5;
transition: width 150ms; transition: width 150ms;
background: currentColor; background: currentColor;
color: $halfGray color: $halfGray