1
0
mirror of https://github.com/lensapp/lens.git synced 2025-05-20 05:10:56 +00:00

Tweak UI in a dialog

Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Mikko Aspiala <mikko.aspiala@houston-inc.com>
This commit is contained in:
Mikko Aspiala 2021-11-05 13:40:09 +02:00 committed by Janne Savolainen
parent 293cdb87ec
commit 653958d8f9
2 changed files with 16 additions and 18 deletions

View File

@ -111,8 +111,14 @@ exports[`kube-object-menu given kube object when removing kube object renders 1`
<div> <div>
<p> <p>
Remove Remove
some-kind
<b> <b>
Some cluster name/some-kind/some-name some-name
</b>
from
<b>
Some cluster name
</b> </b>
? ?
</p> </p>

View File

@ -92,9 +92,7 @@ export class KubeObjectMenu<
} }
const breadcrumbParts = [ const breadcrumbParts = [
this.dependencies.clusterName,
object.getNs(), object.getNs(),
object.kind,
object.getName(), object.getName(),
]; ];
@ -102,7 +100,7 @@ export class KubeObjectMenu<
return ( return (
<p> <p>
Remove <b>{breadcrumb}</b>? Remove {object.kind} <b>{breadcrumb}</b> from <b>{this.dependencies.clusterName}</b>?
</p> </p>
); );
} }
@ -116,20 +114,14 @@ export class KubeObjectMenu<
return this.dependencies.kubeObjectMenuRegistry return this.dependencies.kubeObjectMenuRegistry
.getItemsForKind(object.kind, object.apiVersion) .getItemsForKind(object.kind, object.apiVersion)
.map( .map(({ components: { MenuItem }}: { components: { MenuItem: React.ReactType<any> }}, index: number) => (
( <MenuItem
{ object={object}
components: { MenuItem }, toolbar={toolbar}
}: { components: { MenuItem: React.ReactType<any> }}, // TODO: Fix misuse of index in key
index: number, key={`menu-item-${index}`}
) => ( />
<MenuItem ),
object={object}
toolbar={toolbar}
// TODO: Fix misuse of index in key
key={`menu-item-${index}`}
/>
),
); );
} }