From 65b6908bf18c6a787a8efe408bf4585741ccd31e Mon Sep 17 00:00:00 2001
From: Jim Ehrismann <40840436+jim-docker@users.noreply.github.com>
Date: Wed, 27 Oct 2021 18:19:03 -0400
Subject: [PATCH] improved port-forward error reporting (#4155)

Signed-off-by: Jim Ehrismann <jehrismann@mirantis.com>
---
 src/main/routes/port-forward-route.ts                         | 4 ++++
 .../components/+network-services/service-port-component.tsx   | 2 +-
 .../components/+workloads-pods/pod-container-port.tsx         | 2 +-
 src/renderer/port-forward/port-forward-dialog.tsx             | 2 +-
 4 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/src/main/routes/port-forward-route.ts b/src/main/routes/port-forward-route.ts
index 56934628dd..9951967ffe 100644
--- a/src/main/routes/port-forward-route.ts
+++ b/src/main/routes/port-forward-route.ts
@@ -94,6 +94,10 @@ class PortForward {
       }
     });
 
+    this.process.stderr.on("data", (data) => {
+      logger.warn(`[PORT-FORWARD-ROUTE]: kubectl port-forward process stderr: ${data}`);
+    });
+
     const internalPort = await getPortFrom(this.process.stdout, {
       lineRegex: internalPortRegex,
     });
diff --git a/src/renderer/components/+network-services/service-port-component.tsx b/src/renderer/components/+network-services/service-port-component.tsx
index 6a95846e04..05eedeaece 100644
--- a/src/renderer/components/+network-services/service-port-component.tsx
+++ b/src/renderer/components/+network-services/service-port-component.tsx
@@ -101,7 +101,7 @@ export class ServicePortComponent extends React.Component<Props> {
         this.isPortForwarded = true;
       }
     } catch (error) {
-      Notifications.error("Error occurred starting port-forward, the local port may not be available");
+      Notifications.error(`Error occurred starting port-forward, the local port may not be available or the ${portForward.kind} ${portForward.name} may not be reachable`);
       this.checkExistingPortForwarding();
     } finally {
       this.waiting = false;
diff --git a/src/renderer/components/+workloads-pods/pod-container-port.tsx b/src/renderer/components/+workloads-pods/pod-container-port.tsx
index 19f0c5446b..0ff1645f65 100644
--- a/src/renderer/components/+workloads-pods/pod-container-port.tsx
+++ b/src/renderer/components/+workloads-pods/pod-container-port.tsx
@@ -105,7 +105,7 @@ export class PodContainerPort extends React.Component<Props> {
         this.isPortForwarded = true;
       }
     } catch (error) {
-      Notifications.error("Error occurred starting port-forward, the local port may not be available");
+      Notifications.error(`Error occurred starting port-forward, the local port may not be available or the ${portForward.kind} ${portForward.name} may not be reachable`);
       this.checkExistingPortForwarding();
     } finally {
       this.waiting = false;
diff --git a/src/renderer/port-forward/port-forward-dialog.tsx b/src/renderer/port-forward/port-forward-dialog.tsx
index 3c1306fe33..85e0837508 100644
--- a/src/renderer/port-forward/port-forward-dialog.tsx
+++ b/src/renderer/port-forward/port-forward-dialog.tsx
@@ -112,7 +112,7 @@ export class PortForwardDialog extends Component<Props> {
         openPortForward(portForward);
       }
     } catch (err) {
-      Notifications.error("Error occurred starting port-forward, the local port may not be available");
+      Notifications.error(`Error occurred starting port-forward, the local port may not be available or the ${portForward.kind} ${portForward.name} may not be reachable`);
     } finally {
       close();
     }