diff --git a/src/common/logger.ts b/src/common/logger.ts index 7df4db08c7..fd9345d61e 100644 --- a/src/common/logger.ts +++ b/src/common/logger.ts @@ -78,4 +78,4 @@ export default winston.createLogger({ format.simple(), ), transports, -}); +}) as Logger; diff --git a/src/main/kubectl/kubectl.ts b/src/main/kubectl/kubectl.ts index 55f7e4675d..6fde083de5 100644 --- a/src/main/kubectl/kubectl.ts +++ b/src/main/kubectl/kubectl.ts @@ -132,8 +132,7 @@ export class Kubectl { return this.path; } catch (err) { - logger.error("Failed to ensure kubectl, fallback to the bundled version"); - logger.error(err); + logger.error("Failed to ensure kubectl, fallback to the bundled version", err); return this.getBundledPath(); } @@ -146,7 +145,7 @@ export class Kubectl { return this.dirname; } catch (err) { - logger.error(err); + logger.error("Failed to get biniary directory", err); return ""; } diff --git a/src/main/routes/metrics/add-metrics-route.injectable.ts b/src/main/routes/metrics/add-metrics-route.injectable.ts index 8bd6ad2c72..b97a08d827 100644 --- a/src/main/routes/metrics/add-metrics-route.injectable.ts +++ b/src/main/routes/metrics/add-metrics-route.injectable.ts @@ -31,11 +31,11 @@ const loadMetricsFor = (getMetrics: GetMetrics) => async (promQueries: string[], } catch (error) { if (isRequestError(error)) { if (lastAttempt || (error.statusCode && error.statusCode >= 400 && error.statusCode < 500)) { - logger.error("[Metrics]: metrics not available", error?.response ? error.response?.body : error); - throw new Error("Metrics not available"); + throw new Error("Metrics not available", { cause: error }); } + } else if (error instanceof Error) { + throw new Error("Metrics not available", { cause: error }); } else { - logger.error("[Metrics]: metrics not available", error); throw new Error("Metrics not available"); } diff --git a/src/renderer/themes/store.ts b/src/renderer/themes/store.ts index acd68866d9..0acd81bbcd 100644 --- a/src/renderer/themes/store.ts +++ b/src/renderer/themes/store.ts @@ -121,7 +121,7 @@ export class ThemeStore { try { this.applyActiveTheme(); } catch (err) { - logger.error(err); + logger.error(`Failed to apply active theme: ${err}`); this.dependencies.userStore.resetTheme(); } }, {