From 66b8a9130c144d320bb7358838bd43c9ac2f8743 Mon Sep 17 00:00:00 2001 From: Panu Horsmalahti Date: Fri, 4 Feb 2022 09:50:44 +0200 Subject: [PATCH] Return extensions that failed to be activated from loadExtensions to match old behavior. Signed-off-by: Panu Horsmalahti --- src/extensions/extension-loader/extension-loader.ts | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/extensions/extension-loader/extension-loader.ts b/src/extensions/extension-loader/extension-loader.ts index 6c4090e2e1..a3d7c7a353 100644 --- a/src/extensions/extension-loader/extension-loader.ts +++ b/src/extensions/extension-loader/extension-loader.ts @@ -327,7 +327,6 @@ export class ExtensionLoader { installedExtension: extension, isBundled: extension.isBundled, activated: instance.activate(), - activationError: null, }; } catch (err) { logger.error(`${logModule}: error loading extension`, { ext: extension, err }); @@ -347,7 +346,6 @@ export class ExtensionLoader { extensions.map(extension => // If extension activation fails, log error extension.activated.catch((error) => { - extension.activationError = error; logger.error(`${logModule}: activation extension error`, { ext: extension.installedExtension, error }); }), ), @@ -355,7 +353,6 @@ export class ExtensionLoader { // Return ExtensionLoading[] return extensions - .filter(extension =>!extension.activationError) .map(extension => { const loaded = extension.instance.enable(register).catch((err) => { logger.error(`${logModule}: failed to enable`, { ext: extension, err });