hendrik/lens
1
0
Fork 0
mirror of https://github.com/lensapp/lens.git synced 2025-05-20 05:10:56 +00:00
Code Issues Projects Releases Wiki Activity

PR comment fixes for @jari

Browse Source 
Signed-off-by: Roman <ixrock@gmail.com>
This commit is contained in:
Roman 2020-08-14 15:21:30 +03:00
parent 5fc56da22b
commit 6725a6f7e7
3 changed files with 3 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/common/base-store.ts
View File

@ -135,8 +135,4 @@ export class BaseStore<T = any> extends Singleton {
recurseEverything: true, recurseEverything: true,
}) })
} }
* [Symbol.iterator]() {
yield* Object.entries(this.toJSON());
}
} }

5
src/common/kube-helpers.ts
View File

@ -1,11 +1,10 @@
import { app, remote } from "electron"; import { app, remote } from "electron";
import { KubeConfig, V1Node, V1Pod } from "@kubernetes/client-node" import { KubeConfig, V1Node, V1Pod } from "@kubernetes/client-node"
import { ensureDirSync, readFile, writeFileSync } from "fs-extra"; import fse, { ensureDirSync, readFile, writeFileSync } from "fs-extra";
import path from "path" import path from "path"
import os from "os" import os from "os"
import yaml from "js-yaml" import yaml from "js-yaml"
import logger from "../main/logger"; import logger from "../main/logger";
import fse from "fs-extra"
function resolveTilde(filePath: string) { function resolveTilde(filePath: string) {
if (filePath[0] === "~" && (filePath[1] === "/" || filePath.length === 1)) { if (filePath[0] === "~" && (filePath[1] === "/" || filePath.length === 1)) {
@ -135,8 +134,6 @@ export function podHasIssues(pod: V1Pod) {
) )
} }
// Logic adapted from dashboard
// see: https://github.com/kontena/kontena-k8s-dashboard/blob/7d8f9cb678cc817a22dd1886c5e79415b212b9bf/client/api/endpoints/nodes.api.ts#L147
export function getNodeWarningConditions(node: V1Node) { export function getNodeWarningConditions(node: V1Node) {
return node.status.conditions.filter(c => return node.status.conditions.filter(c =>
c.status.toLowerCase() === "true" && c.type !== "Ready" && c.type !== "HostUpgrades" c.status.toLowerCase() === "true" && c.type !== "Ready" && c.type !== "HostUpgrades"

3
src/common/tracker.ts
View File

@ -3,6 +3,7 @@ import ua from "universal-analytics"
import { machineIdSync } from "node-machine-id" import { machineIdSync } from "node-machine-id"
import Singleton from "./utils/singleton"; import Singleton from "./utils/singleton";
import { userStore } from "./user-store" import { userStore } from "./user-store"
import logger from "../main/logger";
export class Tracker extends Singleton { export class Tracker extends Singleton {
static readonly GA_ID = "UA-159377374-1" static readonly GA_ID = "UA-159377374-1"
@ -40,7 +41,7 @@ export class Tracker extends Singleton {
...otherParams, ...otherParams,
}).send() }).send()
} catch (err) { } catch (err) {
console.error(`Failed to track "${eventCategory}:${eventAction}"`, err) logger.error(`Failed to track "${eventCategory}:${eventAction}"`, err)
} }
} }
} }