Clean up versioning and packageJson uses (#6196)

src/extensions/__tests__/is-compatible-extension.test.ts

@@ -3,65 +3,53 @@
  * Licensed under MIT License. See LICENSE in root directory for more information.
  */
 
-import assert from "assert";
-import semver from "semver";
 import { isCompatibleExtension } from "../extension-discovery/is-compatible-extension/is-compatible-extension";
 import type { LensExtensionManifest } from "../lens-extension";
 
 describe("Extension/App versions compatibility checks", () => {
   it("is compatible with exact version matching", () => {
-    expect(isCompatible({ extLensEngineVersion: "5.5.0", appVersion: "5.5.0" })).toBeTruthy();
+    expect(isCompatible({ extLensEngineVersion: "5.5.0", extensionApiVersion: "5.5.0" })).toBeTruthy();
   });
 
   it("is compatible with upper %PATCH versions of base app", () => {
-    expect(isCompatible({ extLensEngineVersion: "5.5.0", appVersion: "5.5.5" })).toBeTruthy();
+    expect(isCompatible({ extLensEngineVersion: "5.5.0", extensionApiVersion: "5.5.5" })).toBeTruthy();
   });
 
   it("is compatible with higher %MINOR version of base app", () => {
-    expect(isCompatible({ extLensEngineVersion: "5.5.0", appVersion: "5.6.0" })).toBeTruthy();
+    expect(isCompatible({ extLensEngineVersion: "5.5.0", extensionApiVersion: "5.6.0" })).toBeTruthy();
   });
 
   it("is not compatible with higher %MAJOR version of base app", () => {
-    expect(isCompatible({ extLensEngineVersion: "5.6.0", appVersion: "6.0.0" })).toBeFalsy(); // extension for lens@5 not compatible with lens@6
-    expect(isCompatible({ extLensEngineVersion: "6.0.0", appVersion: "5.6.0" })).toBeFalsy();
-  });
-
-  it("is compatible with lensEngine with prerelease", () => {
-    expect(isCompatible({
-      extLensEngineVersion: "^5.4.0-alpha.0",
-      appVersion: "5.5.0-alpha.0",
-    })).toBeTruthy();
+    expect(isCompatible({ extLensEngineVersion: "5.6.0", extensionApiVersion: "6.0.0" })).toBeFalsy(); // extension for lens@5 not compatible with lens@6
+    expect(isCompatible({ extLensEngineVersion: "6.0.0", extensionApiVersion: "5.6.0" })).toBeFalsy();
   });
 
   it("supports short version format for manifest.engines.lens", () => {
-    expect(isCompatible({ extLensEngineVersion: "5.5", appVersion: "5.5.1" })).toBeTruthy();
+    expect(isCompatible({ extLensEngineVersion: "5.5", extensionApiVersion: "5.5.1" })).toBeTruthy();
   });
 
   it("throws for incorrect or not supported version format", () => {
     expect(() => isCompatible({
       extLensEngineVersion: ">=2.0",
-      appVersion: "2.0",
+      extensionApiVersion: "2.0",
     })).toThrow(/Invalid format/i);
 
     expect(() => isCompatible({
       extLensEngineVersion: "~2.0",
-      appVersion: "2.0",
+      extensionApiVersion: "2.0",
     })).toThrow(/Invalid format/i);
 
     expect(() => isCompatible({
       extLensEngineVersion: "*",
-      appVersion: "1.0",
+      extensionApiVersion: "1.0",
     })).toThrow(/Invalid format/i);
   });
 });
 
-function isCompatible({ extLensEngineVersion = "^1.0", appVersion = "1.0" } = {}): boolean {
-  const appSemVer = semver.coerce(appVersion);
+function isCompatible({ extLensEngineVersion = "^1.0", extensionApiVersion = "1.0" } = {}): boolean {
   const extensionManifestMock = getExtensionManifestMock(extLensEngineVersion);
 
-  assert(appSemVer);
-
-  return isCompatibleExtension({ appSemVer })(extensionManifestMock);
+  return isCompatibleExtension({ extensionApiVersion })(extensionManifestMock);
 }
 
 function getExtensionManifestMock(lensEngine = "1.0"): LensExtensionManifest {