From 67da7d7f5bfc8a106eddd2a7f8fa784c047a0549 Mon Sep 17 00:00:00 2001 From: Sebastian Malton Date: Fri, 31 Mar 2023 15:17:50 -0400 Subject: [PATCH] Rename helper function to better communicate intent Signed-off-by: Sebastian Malton --- .../src/features/cluster/storage/common/add.injectable.ts | 4 ++-- .../utility-features/utilities/src/collection-functions.ts | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/core/src/features/cluster/storage/common/add.injectable.ts b/packages/core/src/features/cluster/storage/common/add.injectable.ts index 006032f3fe..ff4ad8d828 100644 --- a/packages/core/src/features/cluster/storage/common/add.injectable.ts +++ b/packages/core/src/features/cluster/storage/common/add.injectable.ts @@ -8,7 +8,7 @@ import emitAppEventInjectable from "../../../../common/app-event-bus/emit-event. import type { ClusterModel } from "../../../../common/cluster-types"; import { Cluster } from "../../../../common/cluster/cluster"; import clustersStateInjectable from "./state.injectable"; -import { setAndInsert } from "@k8slens/utilities"; +import { setAndGet } from "@k8slens/utilities"; export type AddCluster = (clusterModel: ClusterModel) => Cluster; @@ -21,7 +21,7 @@ const addClusterInjectable = getInjectable({ return action((clusterModel) => { emitAppEvent({ name: "cluster", action: "add" }); - return setAndInsert(clustersState, clusterModel.id, new Cluster(clusterModel)); + return setAndGet(clustersState, clusterModel.id, new Cluster(clusterModel)); }); }, }); diff --git a/packages/utility-features/utilities/src/collection-functions.ts b/packages/utility-features/utilities/src/collection-functions.ts index 5961fde37f..9a50bb917f 100644 --- a/packages/utility-features/utilities/src/collection-functions.ts +++ b/packages/utility-features/utilities/src/collection-functions.ts @@ -88,7 +88,7 @@ export async function getOrInsertWithAsync(map: Map, key: K, asyncBu /** * Insert `val` into `map` under `key` and then get the value back */ -export function setAndInsert(map: Map, key: K, val: V): V { +export function setAndGet(map: Map, key: K, val: V): V { map.set(key, val); return map.get(key)!;