Add extensionId to AppPreferencesRegistration items

Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
This commit is contained in:
Alex Andreev committed 2021-12-28 15:13:04 +03:00
1 parent 41aacb3db2
commit 67df2ce127
2 files changed
+5 -2

No files matched your search

@@ -259,7 +259,7 @@ export class ExtensionLoader {
return this.autoInitExtensions(async (extension: LensRendererExtension) => { return this.autoInitExtensions(async (extension: LensRendererExtension) => {
const removeItems = [ const removeItems = [
registries.GlobalPageRegistry.getInstance().add(extension.globalPages, extension), registries.GlobalPageRegistry.getInstance().add(extension.globalPages, extension),
registries.AppPreferenceRegistry.getInstance().add(extension.appPreferences), registries.AppPreferenceRegistry.getInstance().add(extension.appPreferences, extension),
registries.EntitySettingRegistry.getInstance().add(extension.entitySettings), registries.EntitySettingRegistry.getInstance().add(extension.entitySettings),
registries.StatusBarRegistry.getInstance().add(extension.statusBarItems), registries.StatusBarRegistry.getInstance().add(extension.statusBarItems),
registries.CommandRegistry.getInstance().add(extension.commands), registries.CommandRegistry.getInstance().add(extension.commands),
@@ -20,6 +20,7 @@
*/ */
import type React from "react"; import type React from "react";
import type { LensExtension } from "../lens-extension";
import { BaseRegistry } from "./base-registry"; import { BaseRegistry } from "./base-registry";
export interface AppPreferenceComponents { export interface AppPreferenceComponents {
@@ -29,6 +30,7 @@ export interface AppPreferenceComponents {
export interface AppPreferenceRegistration { export interface AppPreferenceRegistration {
title: string; title: string;
extensionId: string;
id?: string; id?: string;
showInPreferencesTab?: string; showInPreferencesTab?: string;
components: AppPreferenceComponents; components: AppPreferenceComponents;
@@ -39,8 +41,9 @@ export interface RegisteredAppPreference extends AppPreferenceRegistration {
} }
export class AppPreferenceRegistry extends BaseRegistry<AppPreferenceRegistration, RegisteredAppPreference> { export class AppPreferenceRegistry extends BaseRegistry<AppPreferenceRegistration, RegisteredAppPreference> {
getRegisteredItem(item: AppPreferenceRegistration): RegisteredAppPreference { getRegisteredItem(item: AppPreferenceRegistration, extension: LensExtension): RegisteredAppPreference {
return { return {
extensionId: extension.id,
id: item.id || item.title.toLowerCase().replace(/[^0-9a-zA-Z]+/g, "-"), id: item.id || item.title.toLowerCase().replace(/[^0-9a-zA-Z]+/g, "-"),
...item, ...item,
}; };