Preventing to create empty and existent workspaces

Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>

src/common/workspace-store.ts

@@ -51,6 +51,10 @@ export class WorkspaceStore extends BaseStore<WorkspaceStoreModel> {
     return this.workspaces.get(id);
   }
 
+  getByName(name: string): Workspace {
+    return this.workspacesList.find(workspace => workspace.name === name);
+  }
+
   @action
   setActive(id = WorkspaceStore.defaultId, { redirectToLanding = true, resetActiveCluster = true } = {}) {
     if (id === this.currentWorkspaceId) return;
@@ -67,14 +71,20 @@ export class WorkspaceStore extends BaseStore<WorkspaceStoreModel> {
   }
 
   @action
-  saveWorkspace(workspace: Workspace) {
+  saveWorkspace(workspace: Workspace): { workspace?: Workspace, error?: string} {
-    const id = workspace.id;
+    const { id, name } = workspace;
     const existingWorkspace = this.getById(id);
-    if (existingWorkspace) {
+    if (!name) {
-      Object.assign(existingWorkspace, workspace);
+      return { error: "Workspace should has a name." };
-    } else {
-      this.workspaces.set(id, workspace);
     }
+    if (this.getByName(name)) {
+      return { error: `Workspace '${name}' already exist.` };
+    }
+    if (existingWorkspace) {
+      return { workspace: Object.assign(existingWorkspace, workspace) };
+    }
+    this.workspaces.set(id, workspace);
+    return { workspace };
   }
 
   @action

src/common/workspace-store_test.ts

@@ -92,6 +92,28 @@ describe("workspace store tests", () => {
 
       expect(ws.workspaces.size).toBe(2);
     })
+
+    it("cannot create namespace with existent name", () => {
+      const ws = WorkspaceStore.getInstance<WorkspaceStore>();
+
+      ws.saveWorkspace({
+        id: "someid",
+        name: "default",
+      });
+
+      expect(ws.workspacesList.length).toBe(1);  // default workspace only
+    })
+
+    it("cannot create namespace with empty name", () => {
+      const ws = WorkspaceStore.getInstance<WorkspaceStore>();
+
+      ws.saveWorkspace({
+        id: "random",
+        name: "",
+      });
+
+      expect(ws.workspacesList.length).toBe(1);  // default workspace only
+    })
   })
 
   describe("for a non-empty config", () => {

src/renderer/components/+workspaces/workspaces.tsx

@@ -12,6 +12,7 @@ import { Icon } from "../icon";
 import { Input } from "../input";
 import { cssNames, prevDefault } from "../../utils";
 import { Button } from "../button";
+import { Notifications } from "../notifications";
 
 @observer
 export class Workspaces extends React.Component {
@@ -41,10 +42,12 @@ export class Workspaces extends React.Component {
 
   saveWorkspace = (id: WorkspaceId) => {
     const draft = toJS(this.editingWorkspaces.get(id));
-    if (draft) {
+    const { error } = workspaceStore.saveWorkspace(draft);
+    if (!error) {
       this.clearEditing(id);
-      workspaceStore.saveWorkspace(draft);
+      return;
     }
+    Notifications.error(error);
   }
 
   addWorkspace = () => {