1
0
mirror of https://github.com/lensapp/lens.git synced 2025-05-20 05:10:56 +00:00

cleanup extension manager

Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com>
This commit is contained in:
Jari Kolehmainen 2020-10-05 10:15:48 +03:00
parent 21ab580144
commit 688ff75f77

View File

@ -41,7 +41,7 @@ export class ExtensionManager {
manifest: manifestJson manifest: manifestJson
} }
} catch (err) { } catch (err) {
console.error(`[EXTENSION-MANAGER]: can't install extension at ${manifestPath}: ${err}`, { manifestJson, mainJs }); logger.error(`[EXTENSION-MANAGER]: can't install extension at ${manifestPath}: ${err}`, { manifestJson, mainJs });
} }
} }
@ -51,35 +51,15 @@ export class ExtensionManager {
production: true, production: true,
global: false, global: false,
prefix: this.extensionPackagesRoot, prefix: this.extensionPackagesRoot,
loglevel: "silent", dev: false,
dev: false spin: false,
"ignore-scripts": true,
loglevel: "error"
}, (err) => { }, (err) => {
npm.commands.install([ npm.commands.install([
path path
], (err) => { ], (err) => {
if (err) { if (err) {
logger.error(err)
reject(err)
} else {
resolve()
}
})
})
})
}
protected installPackage(name: string, version: string | number): Promise<void> {
return new Promise((resolve, reject) => {
npm.load({
production: true,
global: false,
prefix: this.extensionPackagesRoot
}, (err) => {
npm.commands.install([
`${name}@${version}`
], (err) => {
if (err) {
logger.error(err)
reject(err) reject(err)
} else { } else {
resolve() resolve()
@ -105,7 +85,7 @@ export class ExtensionManager {
}); });
let extensions = await Promise.all(manifestsLoading); let extensions = await Promise.all(manifestsLoading);
extensions = extensions.filter(v => !!v); // filter out files and invalid folders (without manifest.json) extensions = extensions.filter(v => !!v); // filter out files and invalid folders (without manifest.json)
console.info(`[EXTENSION-MANAGER]: ${extensions.length} extensions loaded`, { folderPath, extensions }); logger.debug(`[EXTENSION-MANAGER]: ${extensions.length} extensions loaded`, { folderPath, extensions });
return extensions; return extensions;
} }
} }