hendrik/lens
1
0
Fork 0
mirror of https://github.com/lensapp/lens.git synced 2025-05-20 05:10:56 +00:00
Code Issues Projects Releases Wiki Activity

fix

Browse Source 
Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com>
This commit is contained in:
Jari Kolehmainen 2020-11-13 15:03:32 +02:00
parent 7077dba9f3
commit 697587514d
3 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
docs/extensions/capabilities/common-capabilities.md
View File

@ -100,6 +100,8 @@ import { ExamplePage } from "./src/example-page"
export default class ExampleRendererExtension extends LensRendererExtension { export default class ExampleRendererExtension extends LensRendererExtension {
globalPages = [ globalPages = [
{ {
id: "example",
routePath: "/example",
components: { components: {
Page: ExamplePage, Page: ExamplePage,
} }
@ -109,6 +111,7 @@ export default class ExampleRendererExtension extends LensRendererExtension {
globalPageMenus = [ globalPageMenus = [
{ {
title: "Example page", // used in icon's tooltip title: "Example page", // used in icon's tooltip
target: { pageId: "example" }
components: { components: {
Icon: () => <Component.Icon material="arrow"/>, Icon: () => <Component.Icon material="arrow"/>,
} }

3
src/extensions/registries/page-menu-registry.ts
View File

@ -33,7 +33,8 @@ export class PageMenuRegistry<T extends PageMenuRegistration> extends BaseRegist
@action @action
add(items: T[], ext?: LensExtension) { add(items: T[], ext?: LensExtension) {
const normalizedItems = items.map((i) => { const normalizedItems = items.map((i) => {
if (!i.target.extensionId) { console.log(i)
if (i.target && !i.target.extensionId) {
i.target.extensionId = ext.name i.target.extensionId = ext.name
} }
return i return i

3
src/extensions/registries/page-registry.ts
View File

@ -43,6 +43,9 @@ export class PageRegistry<T extends PageRegistration> extends BaseRegistry<T> {
} }
getByPageMenuTarget(target: PageMenuTarget) { getByPageMenuTarget(target: PageMenuTarget) {
if (!target) {
return null
}
return this.getItems().find((page) => page.routePath.startsWith(`/extension/${target.extensionId}/`) && page.id === target.pageId) return this.getItems().find((page) => page.routePath.startsWith(`/extension/${target.extensionId}/`) && page.id === target.pageId)
} }
} }