Introduce eslint and prettier for features and start using it (#7306)

* Introduce package for sharing eslint and prettier configurations

Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>

* Start using eslint and prettier in packages

Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>

---------

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
This commit is contained in:
Janne SavolainenandMikko Aspiala authored and GitHub committed 2023-03-10 12:25:04 +02:00
1 parent 2789bcebcb
commit 699fc0309e
36 files changed
+2973 -610

No files matched your search

@@ -1,14 +1,14 @@
import electronAppInjectable from "./electron-app.injectable";
import { app } from 'electron';
import { app } from "electron";
import { createContainer } from "@ogre-tools/injectable";
import { applicationFeatureForElectronMain } from "../feature";
import { registerFeature } from "@k8slens/feature-core";
describe('electron-app', () => {
it('is electron app', () => {
const di = createContainer('irrelevant');
describe("electron-app", () => {
it("is electron app", () => {
const di = createContainer("irrelevant");
registerFeature(di, applicationFeatureForElectronMain)
registerFeature(di, applicationFeatureForElectronMain);
const actual = di.inject(electronAppInjectable);
@@ -1,6 +1,6 @@
import { getFeature } from "@k8slens/feature-core";
import { autoRegister } from "@ogre-tools/injectable-extension-for-auto-registration";
import { applicationFeature } from '@k8slens/application';
import { applicationFeature } from "@k8slens/application";
export const applicationFeatureForElectronMain = getFeature({
id: "application-for-electron-main",
@@ -10,13 +10,9 @@ export const applicationFeatureForElectronMain = getFeature({
di,
targetModule: module,
getRequireContexts: () => [
require.context("./", true, /\.injectable\.(ts|tsx)$/),
],
getRequireContexts: () => [require.context("./", true, /\.injectable\.(ts|tsx)$/)],
});
},
dependencies: [
applicationFeature
]
dependencies: [applicationFeature],
});
@@ -2,5 +2,5 @@ import type { DiContainer } from "@ogre-tools/injectable";
import whenAppIsReadyInjectable from "./start-application/when-app-is-ready.injectable";
export const overrideSideEffectsWithFakes = (di: DiContainer) => {
di.override(whenAppIsReadyInjectable, () => () => Promise.resolve())
di.override(whenAppIsReadyInjectable, () => () => Promise.resolve());
};
@@ -18,10 +18,7 @@ describe("when-app-is-ready", () => {
whenReadyMock = asyncFn();
di.override(
electronAppInjectable,
() => ({ whenReady: whenReadyMock } as unknown)
);
di.override(electronAppInjectable, () => ({ whenReady: whenReadyMock } as unknown));
});
describe("when called", () => {
@@ -1,8 +1,4 @@
import {
createContainer,
DiContainer,
getInjectable,
} from "@ogre-tools/injectable";
import { createContainer, DiContainer, getInjectable } from "@ogre-tools/injectable";
import { registerFeature } from "@k8slens/feature-core";
import { applicationFeatureForElectronMain } from "./feature";
import {
@@ -52,7 +48,7 @@ describe("starting-of-electron-main-application", () => {
di.register(
beforeAnythingIsLoadingInjectable,
beforeElectronIsReadyIsLoadingInjectable,
beforeApplicationIsLoadingInjectable
beforeApplicationIsLoadingInjectable,
);
di.override(whenAppIsReadyInjectable, () => whenAppIsReadyMock);
@@ -62,7 +58,7 @@ describe("starting-of-electron-main-application", () => {
beforeEach(() => {
const startApplication = di.inject(startApplicationInjectionToken);
startApplication();
void startApplication();
});
it("calls for synchronous runnables for before anything", () => {