From 6c7f4d7f0cdd53cbddd36c3e670264a96b24d4b5 Mon Sep 17 00:00:00 2001
From: alexfront <alex.andreev.email@gmail.com>
Date: Fri, 7 Aug 2020 14:53:52 +0300
Subject: [PATCH] Fix Cluster select behavior

Now clicking cluster icon in sidebar
always leads to / dashboard. And
'Settings' submenu switches active
cluster at first and only the showing
Cluster Settings

Signed-off-by: alexfront <alex.andreev.email@gmail.com>
---
 src/common/cluster-store.ts                          |  4 ++++
 .../components/cluster-manager/clusters-menu.tsx     | 12 ++++++------
 2 files changed, 10 insertions(+), 6 deletions(-)

diff --git a/src/common/cluster-store.ts b/src/common/cluster-store.ts
index e4febf532a..efed98d00a 100644
--- a/src/common/cluster-store.ts
+++ b/src/common/cluster-store.ts
@@ -86,6 +86,10 @@ export class ClusterStore extends BaseStore<ClusterStoreModel> {
     return Array.from(this.clusters.values());
   }
 
+  setActive(id: ClusterId) {
+    this.activeClusterId = id;
+  }
+
   hasClusters() {
     return this.clusters.size > 0;
   }
diff --git a/src/renderer/components/cluster-manager/clusters-menu.tsx b/src/renderer/components/cluster-manager/clusters-menu.tsx
index e4adeb8951..fdfe6a1b67 100644
--- a/src/renderer/components/cluster-manager/clusters-menu.tsx
+++ b/src/renderer/components/cluster-manager/clusters-menu.tsx
@@ -33,11 +33,8 @@ export class ClustersMenu extends React.Component<Props> {
   @observable showHint = true;
 
   showCluster = (clusterId: ClusterId) => {
-    if (clusterStore.activeClusterId === clusterId) {
-      navigate("/"); // redirect to index
-    } else {
-      clusterStore.activeClusterId = clusterId;
-    }
+    clusterStore.setActive(clusterId);
+    navigate("/"); // redirect to index
   }
 
   addCluster = () => {
@@ -50,7 +47,10 @@ export class ClustersMenu extends React.Component<Props> {
 
     menu.append(new MenuItem({
       label: _i18n._(t`Settings`),
-      click: () => navigate(clusterSettingsURL())
+      click: () => {
+        clusterStore.setActive(cluster.id);
+        navigate(clusterSettingsURL())
+      }
     }));
     if (cluster.online) {
       menu.append(new MenuItem({