hendrik/lens
1
0
Fork 0
mirror of https://github.com/lensapp/lens.git synced 2025-05-20 05:10:56 +00:00
Code Issues Projects Releases Wiki Activity

resolve pr comments

Browse Source 
Signed-off-by: Sebastian Malton <sebastian@malton.name>
This commit is contained in:
Sebastian Malton 2021-04-07 10:35:39 -04:00
parent 4f9b5a8a3a
commit 6d067b68e2
3 changed files with 4 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/renderer/components/+extensions/extensions.tsx
View File

@ -313,7 +313,7 @@ export async function attemptInstallByInfo({ name, version, requireConfirmation
const url = json.versions[version].dist.tarball; const url = json.versions[version].dist.tarball;
const fileName = path.basename(url); const fileName = path.basename(url);
const { promise: dataP } = downloadFile({ url, timeout: 60000 /*1m*/ }); const { promise: dataP } = downloadFile({ url, timeout: 10 * 60 * 1000 });
return attemptInstall({ fileName, dataP }, disposer); return attemptInstall({ fileName, dataP }, disposer);
} }
@ -405,7 +405,7 @@ async function installFromInput(input: string) {
if (InputValidators.isUrl.validate(input)) { if (InputValidators.isUrl.validate(input)) {
// install via url // install via url
disposer = ExtensionInstallationStateStore.startPreInstall(); disposer = ExtensionInstallationStateStore.startPreInstall();
const { promise } = downloadFile({ url: input, timeout: 60000 /*1m*/ }); const { promise } = downloadFile({ url: input, timeout: 10 * 60 * 1000 });
const fileName = path.basename(input); const fileName = path.basename(input);
await attemptInstall({ fileName, dataP: promise }, disposer); await attemptInstall({ fileName, dataP: promise }, disposer);
@ -589,7 +589,7 @@ export class Extensions extends React.Component {
className="box grow" className="box grow"
theme="round-black" theme="round-black"
disabled={ExtensionInstallationStateStore.anyPreInstallingOrInstalling} disabled={ExtensionInstallationStateStore.anyPreInstallingOrInstalling}
placeholder={`Path or URL to an extension package (${supportedFormats.join(", ")})`} placeholder={`Name or file path or URL to an extension package (${supportedFormats.join(", ")})`}
showErrorsAsTooltip={{ preferredPositions: TooltipPosition.BOTTOM }} showErrorsAsTooltip={{ preferredPositions: TooltipPosition.BOTTOM }}
validators={installPath ? Extensions.installInputValidator : undefined} validators={installPath ? Extensions.installInputValidator : undefined}
value={installPath} value={installPath}

4
src/renderer/components/confirm-dialog/confirm-dialog.tsx
View File

@ -48,10 +48,6 @@ export class ConfirmDialog extends React.Component<ConfirmDialogProps> {
}); });
} }
private static closeDialog() {
ConfirmDialog.isOpen = false;
}
public defaultParams: ConfirmDialogParams = { public defaultParams: ConfirmDialogParams = {
ok: noop, ok: noop,
labelOk: "Ok", labelOk: "Ok",

2
src/renderer/protocol-handler/app-handlers.ts
View File

@ -56,7 +56,7 @@ export function bindProtocolAddRouteHandlers() {
.addInternalHandler("/extensions", () => { .addInternalHandler("/extensions", () => {
navigate(extensionsURL()); navigate(extensionsURL());
}) })
.addInternalHandler(`/extensions${LensProtocolRouter.ExtensionUrlSchema}`, ({ pathname, search: { version } }) => { .addInternalHandler(`/extensions/install${LensProtocolRouter.ExtensionUrlSchema}`, ({ pathname, search: { version } }) => {
const name = [ const name = [
pathname[EXTENSION_PUBLISHER_MATCH], pathname[EXTENSION_PUBLISHER_MATCH],
pathname[EXTENSION_NAME_MATCH], pathname[EXTENSION_NAME_MATCH],