hendrik/lens
1
0
Fork 0
mirror of https://github.com/lensapp/lens.git synced 2025-05-20 05:10:56 +00:00
Code Issues Projects Releases Wiki Activity

Simplify test

Browse Source 
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
This commit is contained in:
Janne Savolainen 2021-12-03 07:41:58 +02:00
parent 79f53845ce
commit 6d192a22d5
1 changed files with 8 additions and 23 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
src/renderer/components/kube-object-menu/kube-object-menu.test.tsx
View File

@ -36,14 +36,13 @@ import hideDetailsInjectable from "./dependencies/hide-details.injectable";
import editResourceTabInjectable from "./dependencies/edit-resource-tab.injectable"; import editResourceTabInjectable from "./dependencies/edit-resource-tab.injectable";
import { TabKind } from "../dock/dock.store"; import { TabKind } from "../dock/dock.store";
import kubeObjectMenuRegistryInjectable from "./dependencies/kube-object-menu-items/kube-object-menu-registry.injectable"; import kubeObjectMenuRegistryInjectable from "./dependencies/kube-object-menu-items/kube-object-menu-registry.injectable";
import { renderFor, DiRender } from "../test-utils/renderFor"; import { DiRender, renderFor } from "../test-utils/renderFor";
import type { Cluster } from "../../../main/cluster"; import type { Cluster } from "../../../main/cluster";
import type { ApiManager } from "../../../common/k8s-api/api-manager"; import type { ApiManager } from "../../../common/k8s-api/api-manager";
import apiManagerInjectable from "./dependencies/api-manager.injectable"; import apiManagerInjectable from "./dependencies/api-manager.injectable";
import { KubeObjectMenu } from "./index"; import { KubeObjectMenu } from "./index";
describe("kube-object-menu", () => { describe("kube-object-menu", () => {
let objectStub: KubeObject | null;
let di: ConfigurableDependencyInjectionContainer; let di: ConfigurableDependencyInjectionContainer;
let render: DiRender; let render: DiRender;
@ -62,7 +61,7 @@ describe("kube-object-menu", () => {
di.override(apiManagerInjectable, { di.override(apiManagerInjectable, {
// eslint-disable-next-line unused-imports/no-unused-vars-ts // eslint-disable-next-line unused-imports/no-unused-vars-ts
getStore: (api) => undefined, getStore: api => undefined,
} as ApiManager); } as ApiManager);
di.override(hideDetailsInjectable, () => {}); di.override(hideDetailsInjectable, () => {});
@ -96,26 +95,14 @@ describe("kube-object-menu", () => {
it("given no cluster, does not crash", () => { it("given no cluster, does not crash", () => {
di.override(clusterInjectable, null); di.override(clusterInjectable, null);
objectStub = null;
expect(() => { expect(() => {
render( render(<KubeObjectMenu object={null} toolbar={true} />);
<KubeObjectMenu
object={objectStub}
toolbar={true}
/>,
);
}).not.toThrow(); }).not.toThrow();
}); });
it("given no kube object, renders", () => { it("given no kube object, renders", () => {
objectStub = null;
const { baseElement } = render( const { baseElement } = render(
<KubeObjectMenu <KubeObjectMenu object={null} toolbar={true} />,
object={objectStub}
toolbar={true}
/>,
); );
expect(baseElement).toMatchSnapshot(); expect(baseElement).toMatchSnapshot();
@ -126,7 +113,7 @@ describe("kube-object-menu", () => {
let removeActionMock: AsyncFnMock<Function>; let removeActionMock: AsyncFnMock<Function>;
beforeEach(async () => { beforeEach(async () => {
objectStub = KubeObject.create({ const objectStub = KubeObject.create({
apiVersion: "some-api-version", apiVersion: "some-api-version",
kind: "some-kind", kind: "some-kind",
metadata: { metadata: {
@ -203,7 +190,7 @@ describe("kube-object-menu", () => {
let baseElement: Element; let baseElement: Element;
beforeEach(async () => { beforeEach(async () => {
objectStub = KubeObject.create({ const objectStub = KubeObject.create({
apiVersion: "some-api-version", apiVersion: "some-api-version",
kind: "some-kind", kind: "some-kind",
metadata: { metadata: {
@ -240,7 +227,7 @@ describe("kube-object-menu", () => {
let baseElement: Element; let baseElement: Element;
beforeEach(async () => { beforeEach(async () => {
objectStub = KubeObject.create({ const objectStub = KubeObject.create({
apiVersion: "some-api-version", apiVersion: "some-api-version",
kind: "some-kind", kind: "some-kind",
metadata: { metadata: {
@ -291,9 +278,7 @@ const addDynamicMenuItem = ({
components: { MenuItem: MenuItemComponent }, components: { MenuItem: MenuItemComponent },
}; };
const kubeObjectMenuRegistry = di.inject( const kubeObjectMenuRegistry = di.inject(kubeObjectMenuRegistryInjectable);
kubeObjectMenuRegistryInjectable,
);
kubeObjectMenuRegistry.add(dynamicMenuItemStub); kubeObjectMenuRegistry.add(dynamicMenuItemStub);
}; };