From 6e79144b6dd19f8f842de7e3af9e2386efabff62 Mon Sep 17 00:00:00 2001 From: Jari Kolehmainen Date: Wed, 7 Apr 2021 19:19:29 +0300 Subject: [PATCH] cleanup Signed-off-by: Jari Kolehmainen --- src/renderer/components/+catalog/catalog.tsx | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/src/renderer/components/+catalog/catalog.tsx b/src/renderer/components/+catalog/catalog.tsx index 9a3f7ab54f..db3dc28370 100644 --- a/src/renderer/components/+catalog/catalog.tsx +++ b/src/renderer/components/+catalog/catalog.tsx @@ -1,8 +1,8 @@ import "./catalog.scss"; import React from "react"; -import { observer } from "mobx-react"; +import { disposeOnUnmount, observer } from "mobx-react"; import { ItemListLayout } from "../item-object-list"; -import { IReactionDisposer, observable } from "mobx"; +import { observable } from "mobx"; import { CatalogEntityItem, CatalogEntityStore } from "./catalog-entity.store"; import { navigate } from "../../navigation"; import { kebabCase } from "lodash"; @@ -26,7 +26,6 @@ enum sortBy { export class Catalog extends React.Component { @observable private catalogEntityStore?: CatalogEntityStore; @observable.deep private contextMenu: CatalogEntityContextMenuContext; - private disposers: IReactionDisposer[] = []; componentDidMount() { this.contextMenu = { @@ -34,7 +33,9 @@ export class Catalog extends React.Component { navigate: (url: string) => navigate(url) }; this.catalogEntityStore = new CatalogEntityStore(); - this.disposers.push(this.catalogEntityStore.watch()); + disposeOnUnmount(this, [ + this.catalogEntityStore.watch() + ]); if (this.catalogEntityStore.items.length === 0) { Notifications.info(<>Welcome!

Get started by associating one or more clusters to Lens

, { @@ -44,10 +45,6 @@ export class Catalog extends React.Component { } } - componentWillUnmount() { - this.disposers.forEach((d) => d()); - } - addToHotbar(item: CatalogEntityItem) { const hotbar = hotbarStore.getByName("default"); // FIXME