hendrik/lens
1
0
Fork 0
mirror of https://github.com/lensapp/lens.git synced 2025-05-20 05:10:56 +00:00
Code Issues Projects Releases Wiki Activity

Remove code made redundant with hiding of preference tabs without content

Browse Source 
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
This commit is contained in:
Iku-turso 2022-10-17 12:21:31 +03:00 committed by Janne Savolainen
parent ca5e5034e6
commit 6f4a6c95fc
No known key found for this signature in database
GPG Key ID: 8C6CFB2FFFE8F68A
2 changed files with 17 additions and 29 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/features/preferences/renderer/preference-items/telemetry/telemetry-preference-page.injectable.tsx
View File

@ -6,24 +6,18 @@ import { getInjectable } from "@ogre-tools/injectable";
import { preferenceItemInjectionToken } from "../preference-item-injection-token"; import { preferenceItemInjectionToken } from "../preference-item-injection-token";
import { TelemetryPage } from "./telemetry-page"; import { TelemetryPage } from "./telemetry-page";
import React from "react"; import React from "react";
import sentryDataSourceNameInjectable from "../../../../../common/vars/sentry-dsn-url.injectable";
const telemetryPreferencePageInjectable = getInjectable({ const telemetryPreferencePageInjectable = getInjectable({
id: "telemetry-preference-page", id: "telemetry-preference-page",
instantiate: (di) => { instantiate: () => ({
const sentryDnsUrl = di.inject(sentryDataSourceNameInjectable);
return {
kind: "page" as const, kind: "page" as const,
id: "telemetry-page", id: "telemetry-page",
parentId: "telemetry-tab", parentId: "telemetry-tab",
orderNumber: 0, orderNumber: 0,
Component: TelemetryPage, Component: TelemetryPage,
childrenSeparator: () => <hr className="small" />, childrenSeparator: () => <hr className="small" />,
isShown: !!sentryDnsUrl, }),
};
},
injectionToken: preferenceItemInjectionToken, injectionToken: preferenceItemInjectionToken,
}); });

10
src/features/preferences/renderer/preference-items/telemetry/telemetry-preference-tab.injectable.ts
View File

@ -4,15 +4,11 @@
*/ */
import { getInjectable } from "@ogre-tools/injectable"; import { getInjectable } from "@ogre-tools/injectable";
import { preferenceItemInjectionToken } from "../preference-item-injection-token"; import { preferenceItemInjectionToken } from "../preference-item-injection-token";
import sentryDataSourceNameInjectable from "../../../../../common/vars/sentry-dsn-url.injectable";
const telemetryPreferenceTabInjectable = getInjectable({ const telemetryPreferenceTabInjectable = getInjectable({
id: "telemetry-preference-tab", id: "telemetry-preference-tab",
instantiate: (di) => { instantiate: () => ({
const sentryDnsUrl = di.inject(sentryDataSourceNameInjectable);
return {
kind: "tab" as const, kind: "tab" as const,
id: "telemetry-tab", id: "telemetry-tab",
parentId: "general-tab-group" as const, parentId: "general-tab-group" as const,
@ -20,9 +16,7 @@ const telemetryPreferenceTabInjectable = getInjectable({
testId: "terminal-preferences-page", testId: "terminal-preferences-page",
label: "Telemetry", label: "Telemetry",
orderNumber: 60, orderNumber: 60,
isShown: !!sentryDnsUrl, }),
};
},
injectionToken: preferenceItemInjectionToken, injectionToken: preferenceItemInjectionToken,
}); });