Release/v5.4.2 (#5005)

* Fix annotation for cronjob when is manually triggered (#4976)

Signed-off-by: Carlos René Mederos Arias <krlosmederos@gmail.com>

* Fix HelmChart validator requiring digest field (#4920)

* Fix HelmChart validator requiring digest field

Signed-off-by: Sebastian Malton <sebastian@malton.name>

* fix tests

Signed-off-by: Sebastian Malton <sebastian@malton.name>

* fixed non-virtual list row rendering (#4983)

* Remove listener for online event (#4970)

* Fix "logs from" date (#4987)

* release v5.4.2

Signed-off-by: Jim Ehrismann <jehrismann@mirantis.com>

Co-authored-by: Carlos René Mederos Arias <krlosmederos@gmail.com>
Co-authored-by: Sebastian Malton <sebastian@malton.name>
Co-authored-by: Alex Andreev <alex.andreev.email@gmail.com>

src/common/k8s-api/__tests__/helm-charts.api.test.ts

@@ -36,13 +36,6 @@ describe("HelmChart tests", () => {
         version: "!",
         repo: "!",
       } as any)).toThrowError('"created" is required');
-      expect(() => HelmChart.create({
-        apiVersion: "!",
-        name: "!",
-        version: "!",
-        repo: "!",
-        created: "!",
-      } as any)).toThrowError('"digest" is required');
     });
 
     it("should throw on fields being wrong type", () => {
@@ -62,6 +55,14 @@ describe("HelmChart tests", () => {
         created: "!",
         digest: "!",
       } as any)).toThrowError('"name" must be a string');
+      expect(() => HelmChart.create({
+        apiVersion: "!",
+        name: "!",
+        version: "!",
+        repo: "!",
+        created: "!",
+        digest: 1,
+      } as any)).toThrowError('"digest" must be a string');
       expect(() => HelmChart.create({
         apiVersion: "1",
         name: "",

src/common/k8s-api/endpoints/helm-charts.api.ts

@@ -75,7 +75,7 @@ export interface RawHelmChart {
   version: string;
   repo: string;
   created: string;
-  digest: string;
+  digest?: string;
   kubeVersion?: string;
   description?: string;
   home?: string;
@@ -142,7 +142,7 @@ const helmChartValidator = Joi.object<HelmChart, true, RawHelmChart>({
     .required(),
   digest: Joi
     .string()
-    .required(),
+    .optional(),
   kubeVersion: Joi
     .string()
     .optional(),
@@ -247,22 +247,22 @@ export interface HelmChart {
   name: string;
   version: string;
   repo: string;
-  kubeVersion?: string;
   created: string;
   description: string;
-  digest: string;
   keywords: string[];
-  home?: string;
   sources: string[];
   urls: string[];
   annotations: Record<string, string>;
   dependencies: HelmChartDependency[];
   maintainers: HelmChartMaintainer[];
+  deprecated: boolean;
+  kubeVersion?: string;
+  digest?: string;
+  home?: string;
   engine?: string;
   icon?: string;
   appVersion?: string;
   type?: string;
-  deprecated: boolean;
   tillerVersion?: string;
 }
 
@@ -324,7 +324,11 @@ export class HelmChart {
   }
 
   getId(): string {
-    return `${this.repo}:${this.apiVersion}/${this.name}@${this.getAppVersion()}+${this.digest}`;
+    const digestPart = this.digest
+      ? `+${this.digest}`
+      : "";
+
+    return `${this.repo}:${this.apiVersion}/${this.name}@${this.getAppVersion()}${digestPart}`;
   }
 
   getName(): string {