hendrik/lens
1
0
Fork 0
mirror of https://github.com/lensapp/lens.git synced 2025-05-20 05:10:56 +00:00
Code Issues Projects Releases Wiki Activity

Specifying types a bit more

Browse Source 
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
This commit is contained in:
Alex Andreev 2021-03-26 13:40:02 +03:00
parent 06c42ab9ae
commit 71ed501f07
1 changed files with 9 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
src/renderer/components/select/select.tsx
View File

@ -12,18 +12,21 @@ import { themeStore } from "../../theme.store";
const { Menu } = components; const { Menu } = components;
type OptionType = { label: string; value: string };
type GroupType = GroupTypeBase<OptionType>;
export interface GroupSelectOption<T extends SelectOption = SelectOption> { export interface GroupSelectOption<T extends SelectOption = SelectOption> {
label: ReactNode; label: ReactNode;
options: T[]; options: T[];
} }
export interface SelectOption<T = any> { export interface SelectOption<T = any> {
value: T; value?: T;
label?: React.ReactNode; label?: React.ReactNode;
} }
export interface SelectProps<T = any> extends ReactSelectProps<OptionTypeBase, boolean, GroupTypeBase<OptionTypeBase>> { export interface SelectProps<T = any> extends ReactSelectProps<OptionTypeBase, boolean> {
options?: readonly any[]; options?: ReadonlyArray<OptionType | GroupType | unknown>;
value?: T; value?: T;
themeName?: "dark" | "light" | "outlined"; themeName?: "dark" | "light" | "outlined";
menuClass?: string; menuClass?: string;
@ -70,15 +73,9 @@ export class Select extends React.Component<SelectProps> {
} }
@computed get options(): readonly SelectOption[] { @computed get options(): readonly SelectOption[] {
const { autoConvertOptions, options } = this.props; return this.props.options.map(opt => {
return this.isValidOption(opt) ? opt : { value: opt, label: String(opt) };
if (autoConvertOptions && Array.isArray(options)) { });
return options.map(opt => {
return this.isValidOption(opt) ? opt : { value: opt, label: String(opt) };
});
}
return options;
} }
@autobind() @autobind()