diff --git a/package.json b/package.json index 732b89c8cb..27721b6e7a 100644 --- a/package.json +++ b/package.json @@ -16,7 +16,7 @@ "dev-run": "nodemon --watch static/build/main.js --exec \"electron --inspect .\"", "dev:main": "yarn run compile:main --watch", "dev:renderer": "yarn run webpack-dev-server --config webpack.renderer.ts", - "dev:extension-types": "yarn run compile:extension-types --watch", + "dev:extension-types": "yarn run compile:extension-types --watch --progress", "compile": "env NODE_ENV=production concurrently yarn:compile:*", "compile:main": "yarn run webpack --config webpack.main.ts", "compile:renderer": "yarn run webpack --config webpack.renderer.ts", diff --git a/src/renderer/components/dialog/dialog.tsx b/src/renderer/components/dialog/dialog.tsx index 232fee6475..81851616e8 100644 --- a/src/renderer/components/dialog/dialog.tsx +++ b/src/renderer/components/dialog/dialog.tsx @@ -146,11 +146,10 @@ export class Dialog extends React.PureComponent { {dialog} ); - } - else if (!this.isOpen) { + } else if (!this.isOpen) { return null; } - return createPortal(dialog, document.body); + return createPortal(dialog, document.body) as React.ReactPortal; } } diff --git a/webpack.extensions.ts b/webpack.extensions.ts index 0c2829a406..1b9c812868 100644 --- a/webpack.extensions.ts +++ b/webpack.extensions.ts @@ -1,9 +1,9 @@ import path from "path"; import webpack from "webpack"; -import { sassCommonVars } from "./src/common/vars"; +import { sassCommonVars, isDevelopment } from "./src/common/vars"; -export default function (): webpack.Configuration { +export default function generateExtensionTypes(): webpack.Configuration { const entry = "./src/extensions/extension-api.ts"; const outDir = "./src/extensions/npm/extensions/dist"; @@ -22,6 +22,10 @@ export default function (): webpack.Configuration { // e.g. require('@k8slens/extensions') libraryTarget: "commonjs" }, + cache: isDevelopment, + optimization: { + minimize: false, // speed up types compilation + }, module: { rules: [ {